Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c75ba6c3-938d-14a5-2fc8-3e846eeba23f@amd.com>
Date:   Sat, 1 Oct 2022 10:43:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4] perf test: Introduce script for data symbol testing
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>, Leo Yan <leo.yan@linaro.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220930120939.353315-1-leo.yan@linaro.org>
 <CAM9d7cibbdOb04qhKkfyRmwtHvttb6-bOu_uAN6D8ke-EJUWZw@mail.gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAM9d7cibbdOb04qhKkfyRmwtHvttb6-bOu_uAN6D8ke-EJUWZw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWlFb094NTQ4Y3V5dHZLVW81cmtTSzRiZ0FBYlBKM25Mc1dCZExmUHRSZnlO?=
 =?utf-8?B?WVI2Z0VDMzNGZzA3NzBPR0JkN3dVWlB2OTlhblVPb2xNcWJ3Ty9EUmVPT2ps?=
 =?utf-8?B?WXUvaGJQWnI1UDRuUDgvSmU4ZGk1V0lRZGx1U0RkVWRLdXJ1SmdOR2dxeTF0?=
 =?utf-8?B?R2djWW5jbUF1ZFgrOUhzaytNZ2RiR3lKU3dwWkl6Vm15ZTJ0QkxtZGE4dCtC?=
 =?utf-8?B?c0txM2NrVGx6YVdjZVRTTmFYUTlBRVQ0Yjlob0JJWDYwSGxiZzVORGJ6Q0cx?=
 =?utf-8?B?Qm9IQXZpS1VUR2o0dFNsSEV2dFRXWEsraVQxTWs1Vzdkbis3ekxjSmhMeHly?=
 =?utf-8?B?bkRvd0NzZzk1WEpGN1lEQXdETERoTlQ5SXlHL1NOaWhxWi9JTmcrR0FtRThw?=
 =?utf-8?B?ZCtMTXNRWkJuSmpqS0ZQTEcxRE1QYWh3L2dwY3NldVA5U2VEbm8rVmh1Zlgy?=
 =?utf-8?B?WDE1YkZnT2xaSkFsdnAwMWkxTWRvam1yTUg5RnBQVXJ2Vm1oYzg2STE0Rk55?=
 =?utf-8?B?dk9hWUsxNmtkYXZnT0NCT1JaRnhJbjFGT1FhaXVNR2w4U2tybjVlYWlZNjR3?=
 =?utf-8?B?UGZJMmU4d1hHeFV0VzNQeWZOMTBNL1VuL0xQQ2Q5NjhUNmJZWnZFMEJwM2pF?=
 =?utf-8?B?Tlpwa1FMZE4zUmJQOEFxVWRCUCtTNWdlM2Z5TWg2Z095Y0pLVFFYMmFmS0Vh?=
 =?utf-8?B?WUhiTEtVR2lKcG1uL0NRSEhSK1BCZ0ZjbnBocnRQa0JyNjVCbmkzRy80VWs4?=
 =?utf-8?B?Z3dSS2RnM2hjQ1JsR04yRmJBMlBiUGJPMDBUUHdtR1FVNkVtclAyS1AyK1Z0?=
 =?utf-8?B?Skd3Q0RaVk9kdzRrMjdwQ3RKRmIzZ2xHQ0lMd3JvQmFKeCt0Y25KQzBqZHJt?=
 =?utf-8?B?TWw3Z3ZydmVDUmowQy9GYVpJa0x1ay9mM1M5YmdqNFJ5VFFuSjZGQTZDNDBM?=
 =?utf-8?B?OU9aT1hzd1JZTncrRXh6dm9hamg1eHhScitXOGtLUHNJRUg0NHBMck1lcnY1?=
 =?utf-8?B?NVYrRVFYRWY5Nlc1ZkJLRzB4bzY1M0JWOTlrQnVLUzdXSWpBa09WeHNieUZr?=
 =?utf-8?B?ejZCaVRIZ2RaK0RMekg5WkdNb3lBOXIxRVhJTzUrLytZVlJDTFZFSkdZTE9E?=
 =?utf-8?B?dUxYOUJZS1VuenJPcHRXNEhGYVNJMGE0ZW5jeXpPa3FYejNWZ1JERk5LNkl5?=
 =?utf-8?B?L214US9raEo2RlJhRHl0dzNJaXRsNkhCZWR4bng2UHgxRkczMVpLc25iMXVH?=
 =?utf-8?B?d3BXZFBhZ0VyaSsrbVJONWkvWElZbnVObldQRHpoTGNSSG1TaEdwSG5Xcy9v?=
 =?utf-8?B?dW1GbnBTUmNlSUErcmg5Qy9BSmRmY0dyTzMwNmdNQm5CR2c5QU5pNGg3SkZG?=
 =?utf-8?B?cjlsb1I0U1dhVnQyR2hJN0NMTWNkQWpYRG12WnhkUWh3ek53YXV0NkIvRVlV?=
 =?utf-8?B?WkNqTEtKUC9LN2ZuSGc1d0pibm8rdU5wY1gzZ1I1alJqQ01tQyt0TDFoNnQr?=
 =?utf-8?B?OUhXb0FMSUx3TUpST3ZVNmoxaHdoNE56MDhVSUNFZGQvajJLMFQ3U2hQQ21G?=
 =?utf-8?B?Y213RU5lQ3gzYWRHV1ovOCs3Z0VJb3I2UXhKNEl0S2ZxK0dCUVc2ZHZXeEt0?=
 =?utf-8?B?dlFGSy9RaGFvVTBMZ0Q5TVY5QUNVTmRmb2JWYmk3OVdueVlMZTB4Wi8xRm9Z?=
 =?utf-8?B?dHJ6cjhoZ1ZXNEp6NUlOUFRNNWRyL3hmTmJPVnd6Zm5WVGRWRHpPbmhpOXNJ?=
 =?utf-8?B?cXV1ck01UG9RTkFzNy9rWWM0ekU5V3E0cmFjQ3ovbGxZRGZZUk1lSjhFWGph?=
 =?utf-8?B?U1RESDFLWFJESmQ1NmNDWlBoSHREVjVEY0NwejVBY2hGdzZmTzN2clJCTDE2?=
 =?utf-8?B?aXNCSVFlTjNEQnN6TWs1bFNwMVpNRlR3SElXUWhtMUVRbkorWk5wMVZ3TGJC?=
 =?utf-8?B?N1p1VmN0VHRzVWdlTGdOUGw5U3cyU25yZnJ5cmd4QlhNVURRZWw0czJRT0hi?=
 =?utf-8?B?aGJaemlRb0pPOTEyYmE1MjdaSHhManlMM3lJY05wdHdNbGhSMXB1d01RbUdP?=
 =?utf-8?B?R3dhSldyOXc1QysxK1B5WXVBMTVjd0NDSzhNWi9nUkh3bUcyL25Lbk45U0xt?=
 =?utf-8?Q?Z0gX55hWKx7lE1lHsTaSIFHll?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaa1f517-16fb-498b-0a6f-08daa36ba930
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 05:13:22.5265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nFkmf7DPz66BNiqF/A7icmfeDvYe7Y9SW/jHM+1RXww45MMHPy4RHqEw+CgAjjdbNbXYuGTtevBXuvjb/P5cDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6425
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +# perf mem/c2c internally uses IBS PMU on AMD CPU which doesn't support
>> +# user/kernel filtering and per-process monitoring, spin program on
>> +# specific CPU and test in per-CPU mode.
>> +is_amd=$(egrep -c 'vendor_id.*AuthenticAMD' /proc/cpuinfo)
>> +if (($is_amd >= 1)); then
>> +       perf mem record -o ${PERF_DATA} -- -C 0 -- taskset -c 0 $TEST_PROGRAM &
> 
> I'm curious why it has "--" before "-C 0"..

IIRC, any command line options placed after -- will be carry forwarded
as is to perf record.

perf mem record [options] does not support -C option. Which means -C 0
will be ignored if user run `perf mem record -C 0`. Ex:

  $ sudo ./perf --debug perf-event-open mem record -C 0
  [...]
  sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0 = 5
  sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0 = 6
  sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0 = 7
  sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0 = 8

OTOH, if I place -C 0 after -- then perf opens event only on cpu0:

  $ sudo ./perf --debug perf-event-open mem record -- -C 0
  [...]
  sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0 = 7

Now, perf mem [options] supports -C options but I don't know why
it's not working for me:

  $ sudo ./perf --debug perf-event-open mem -C 0 record
  [...]
  sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0 = 5
  sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0 = 6
  sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0 = 7
  sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0 = 8

Thanks,
Ravi