Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221001030656.29365-1-quic_molvera@quicinc.com>
In-Reply-To: <20221001030656.29365-1-quic_molvera@quicinc.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Sat, 1 Oct 2022 10:32:20 +0300
Message-ID: <CAA8EJpr7i6iQ3PYzRbwHQP1-gS9oTGwuNkbJPVh0ieaD+7Jbpg@mail.gmail.com>
Subject: Re: [PATCH 00/19] Add base device tree files for QDU1000/QRU1000
To:     Melody Olvera <quic_molvera@quicinc.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 1 Oct 2022 at 06:09, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
> This series adds the base device tree files and DTS support for the
> Qualcomm QDU1000 and QRU1000 IDP SoCs, including the clocks, tlmm, smmu,
> regulators, mmc, interconnects, cpufreq, and qup.
>
> This patchset is based off of [1] which adds support for the PMIC arb used
> on these SoCs.
>
> The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit
> 1000 are new SoCs meant for enabling Open RAN solutions. See more at
> https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf
>
> [1] https://lore.kernel.org/all/20220914165212.3705892-3-vkoul@kernel.org/
>
> Melody Olvera (19):
>   arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs
>   arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs

No need to split IDT commits too much. Splitting the main DT is fine
for me, it eases review. For IDT, I'd just squash them together.

>   arm64: dts: qcom: qdru1000: Add tlmm nodes
>   arm64: dts: qcom: qdu1000: Add reserved memory nodes
>   arm64: dts: qcom: qru1000: Add reserved memory nodes
>   arm64: dts: qcom: qdru1000: Add smmu nodes
>   arm64: dts: qcom: qdu1000-idp: Add RPMH regulators nodes
>   arm64: dts: qcom: qru1000-idp: Add RPMH regulators nodes
>   arm64: dts: qcom: qdru1000: Add interconnect nodes
>   arm64: dts: qcom: qdru1000: Add rpmhpd node
>   arm64: dts: qcom: qdru1000: Add spmi node
>   arm64: dts: qcom: qdu1000-idp: Include pmic file
>   arm64: dts: qcom: qru1000-idp: Include pmic file
>   arm64: dts: qcom: qdru1000: Add cpufreq support
>   arm64: dts: qcom: qdru1000: Add additional QUP nodes
>   arm64: dts: qcom: qdru1000: Add gpi_dma nodes
>   arm64: dts: qcom: qdru1000: Add I2C nodes for QUP
>   arm64: dts: qcom: qdru1000: Add SPI devices to QUP nodes
>   arm64: dts: qcom: qdru1000: Add additional UART instances
>
>  arch/arm64/boot/dts/qcom/Makefile        |    2 +
>  arch/arm64/boot/dts/qcom/qdru1000.dtsi   | 1499 ++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/qdu1000-idp.dts |  231 ++++
>  arch/arm64/boot/dts/qcom/qdu1000.dtsi    |  160 +++
>  arch/arm64/boot/dts/qcom/qru1000-idp.dts |  231 ++++
>  arch/arm64/boot/dts/qcom/qru1000.dtsi    |  155 +++
>  6 files changed, 2278 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qdru1000.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/qdu1000.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/qru1000.dtsi
>
>
> base-commit: 987a926c1d8a40e4256953b04771fbdb63bc7938
> prerequisite-patch-id: 79eb132c9ff1a0feb653bef87e3e93f6841f81ee
> prerequisite-patch-id: e25ad91d89a9d4a24f1081e5c03cb20678c6e94b
> prerequisite-patch-id: e882ee6dbd8d55069a313e9c2b10a1ea7f6b80fb
> prerequisite-patch-id: 85c1f1845b2e69ef50e7e8391426e6cab6c66381
> prerequisite-patch-id: 5fd7e4f92a95a7dedc49fd39fdffd5e02c838190
> prerequisite-patch-id: c8d9475d6bb2d24102e5bfee65f74d2c0365db68
> prerequisite-patch-id: a03c3288ed927cbab6a42d3ad49df4347cfc9722
> prerequisite-patch-id: aa7ddf85d2a1c02e4d649632425910e44f73a567
> prerequisite-patch-id: 5e7a02607aecd3f5346a2f450982601cf6935e54
> --
> 2.37.3
>


-- 
With best wishes
Dmitry