Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
Cc:     James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Gaurav Srivastava <gaurav.srivastava@broadcom.com>,
        Hannes Reinecke <hare@suse.de>,
        Muneendra Kumar <muneendra.kumar@broadcom.com>,
        James Smart <jsmart2021@gmail.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: Fix memory leak in lpfc_create_port()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfk7j21y.fsf@ca-mkp.ca.oracle.com>
References: <20220916035908.712799-1-rafaelmendsr@gmail.com>
Date:   Sat, 01 Oct 2022 06:01:32 -0400
In-Reply-To: <20220916035908.712799-1-rafaelmendsr@gmail.com> (Rafael
        Mendonca's message of "Fri, 16 Sep 2022 00:59:07 -0300")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mas6XxesUcE1gdR+ot2oegZpxrGnKYnQpqVMGSncwm2+Huz+oYV72IzTNB5M?=
 =?us-ascii?Q?/+u/JWwezwq/X05hvEPrpZJD3HyOGudrBYUVtGzcaU8smojhvHrRT/nj4Ofo?=
 =?us-ascii?Q?HGbOWvHBf6+6NwXlvHKIV+PTwLvAEmhS4nG1nKDMfNGAtApbilD9wyfEJI8j?=
 =?us-ascii?Q?KQD+jUsX8JWrO7dDMFLqW4kYTjKhJC12RZ4BvgXAEP5eFcVJzjgC2rsyWVS2?=
 =?us-ascii?Q?9/bvhn1L6HOF+5rqDK5MVnsQUjvSRuGG+VJ5Intl0AdNY3Z+MnT7ZqSfz7oc?=
 =?us-ascii?Q?7vRIpHhYNQAgskVEndxG1tch74dwHaLqL+N+ESSEb709YtxbkoGPR/oEs64w?=
 =?us-ascii?Q?ZpoAI4zLpCQGPoYHBlwQCV7Ds17gV5IGNahFFm86KbHWNPyfFi9BKE4JVYTq?=
 =?us-ascii?Q?EJGn9jSM8I/s2/DoeE7cmtUc8q836o9tzaxtspLN5ykPvF8RU0Tr5gh4b9j9?=
 =?us-ascii?Q?+VOIsdU1IyikM9mA6bIQyeeMr5MeBmXkLI2S1pqhgcLg5GAb1FUDezxfv8vC?=
 =?us-ascii?Q?1eQRUljUQaFIrFhuxN7gMuyYMA2WjXdivuABatg1mMoCms3iyZkoa02z4ymL?=
 =?us-ascii?Q?ZDfxUU9DCvGhJEqAN11Wr3YC/wrmC/nnQjwsT5bwEACWNSwBq+6TuxYbx9ep?=
 =?us-ascii?Q?N7hPRvY3Elwp3XMEPbRBAO8CUiUNAYgiZv3H7jUtnj+Tu42rC2uuf2lZkVcW?=
 =?us-ascii?Q?pADIMa/oMpoY2niQj3JlfddfdiENF20kwk1xDaEuLka7GX6dnbRED/NnDk4u?=
 =?us-ascii?Q?HkgVOfzX8MDVX98N1zhPG8UozY+wo7i49MH3DlXkNijOK+tdhIYyIhVv7+eY?=
 =?us-ascii?Q?nC3t5JvYwYVPJnZhZEv5aTzt6Hg7Dzaj7swhaNdJzXB/LJz9uAd9rJpw0j56?=
 =?us-ascii?Q?IVUVGtAlLN9JrRGQ5vzXRUlpsyPd5XuOs8kuYOH5u0Njn4us6ZcK8YDXYIQf?=
 =?us-ascii?Q?vLM6ai00iC21qiDZcuwfHnL8WGFwkw6tyq7/oVU8dua6Sb9hUeuIOvvHFuti?=
 =?us-ascii?Q?PhHGgfhH1pOa021hHaWgjfylVL583nCiojVsXrqmgh9VhMp+jGtGhjddQI66?=
 =?us-ascii?Q?8m85K/p+5CDRh+2+DIh7H4TIyJzHb2dyP6xkmth1CqDa+4iHUiKY4hzIWaPf?=
 =?us-ascii?Q?xX9k1ZdQ4J8BeyER269yjL57Ou5AGnCEvOZEljzA3J7vJZHgbS+h7WX3PWm6?=
 =?us-ascii?Q?ik6TwGU7zkiagg/H4eMriJ8NwcOERZLMNwe9WG3fQoOUzAaR46Vn0eIU6Sug?=
 =?us-ascii?Q?70JUJ1qn4dYLZlT4sDZr6WAz9sFMUzZ/BqXWhQ21uqUyxTpJ4eJ+Xl56+H0I?=
 =?us-ascii?Q?qYuPKDoWfL9Zh8S/hEK8iRTeS528uX80RI16BOVCNluIlLLAzgZSOykHOzqt?=
 =?us-ascii?Q?ZqEofg9dFkynwD+2fTMOCat7dGDBqpIxCwQrFHwgCN7ogd8xMKSG9FM+2PbY?=
 =?us-ascii?Q?r3bqvP86f38gsowvUfoDKGelos9EO0Wp3qI+xnJzFUX8xjZ0va9Xs9w6nvTg?=
 =?us-ascii?Q?WwUarPqUkNWd76SS3HwZyacLQOQyOj2OShsEhIcH3z3vAntUmMLtH429VIiC?=
 =?us-ascii?Q?q1EKLwzF6OswVeN5dakEe8qbeomfdGDf3oxKUSHqBez18+2Gj7OHB/nJRCBp?=
 =?us-ascii?Q?zA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36fc6526-b932-4890-c6a1-08daa393ec1a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 10:01:34.4606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9w/3pqzXuBShpLkjTXO2tzoMVP1PG4n2h3sRhaj3Z5hUaE42aZNjrhsBrq2is5hdz/GqcM0ACLiyWUfux0Qi8E8GBpwhl6tTTzyUK31zTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6311
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-01_06,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=920
 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210010063
X-Proofpoint-GUID: aEK5kggikroCWJf0yEqQ9tbnCoj7ftIc
X-Proofpoint-ORIG-GUID: aEK5kggikroCWJf0yEqQ9tbnCoj7ftIc
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Commit 5e633302ace1 ("scsi: lpfc: vmid: Add support for VMID in mailbox
> command") introduced allocations for the VMID resources in
> lpfc_create_port() after the call to scsi_host_alloc(). Upon failure on the
> VMID allocations, the new code would branch to the 'out' label, which
> returns NULL without unwinding anything, thus skipping the call to
> scsi_host_put().

Broadcom: Please review, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering