Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Rafael Mendonca <rafaelmendsr@gmail.com>
Cc:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Himanshu Madhani <himanshu.madhani@cavium.com>,
        Quinn Tran <quinn.tran@cavium.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Fix serialization of DCBX TLV data request
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1lepzkh4j.fsf@ca-mkp.ca.oracle.com>
References: <20220926230245.790508-1-rafaelmendsr@gmail.com>
Date:   Sat, 01 Oct 2022 05:50:19 -0400
In-Reply-To: <20220926230245.790508-1-rafaelmendsr@gmail.com> (Rafael
        Mendonca's message of "Mon, 26 Sep 2022 20:02:44 -0300")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?74T6c7jyJRdARgzRjonlCwBkmcTUPEgpPq8WHZbLPy0Wi76OJKmRDR3i1Wkf?=
 =?us-ascii?Q?1BF06qMYcTAB3nRyq4M0Hj7+09GlbmYqnrJLiE91mxc9JidLJzi/NDpxQahY?=
 =?us-ascii?Q?cgWQ6wrzUo5nSuteck0Y/5K7zOy3ffnbZi8uLgV/WTfCGSit8IR6mqDz00hd?=
 =?us-ascii?Q?oRAP6C0Zeadx4dfnktCum+6f4RtNPSOG71U2slcW01vXrOGFDDrja3uWAq9J?=
 =?us-ascii?Q?SAB5/TopnaYUBsNgs8LEwNtosREGN913GQGzLMKVVnuUiJMjdzEI6S7RaCvF?=
 =?us-ascii?Q?99DmAB/W8Jkyh30I9FkU7VzfQwuqaVtORd+x73toHPfwK2THsxagkndLwsBy?=
 =?us-ascii?Q?cRXN4iiX11mL1hfzxMBNL+LgIgmdiedxOBucZbLth77chUQa0EOgqZFisN0F?=
 =?us-ascii?Q?H1nytRrOC83+nhXKhkRikgT4Lcnz6KiZ9vPyWDEApAApQccoqx5A6hFhTHTU?=
 =?us-ascii?Q?XcXba9jhdW55N4gEqLQJ3zQurhKvPdt/SHjhStVo8b8MywzT+Pg/OiLm0oR2?=
 =?us-ascii?Q?mMGSsAI+HYRdh/OmhXLYarqRdg+toC/nEIiXRAqnNiP6oy5MacJ29BhaESdc?=
 =?us-ascii?Q?Be7h6bj0gCnEi/iZQnjzVecfIENJcNCxe8hasUMLymLJgBo+SSxPUX6ylCNw?=
 =?us-ascii?Q?FOg1FLUBiRwt1lF58CjtYCpmJ/9bml6R4eBMtioqKWBS0aAo3quDJIvdvBg3?=
 =?us-ascii?Q?8A9TylJ25VgqJpOHPyXucDNYjSnUjCiyDcDxjTw4U1qdJzfIU/9/63laVZFD?=
 =?us-ascii?Q?kdUACTFk+l4o9Ka++IVLTIi4AcB8Oj56cIlMmSbR2XTpmC0cEX+4Be4q3YWN?=
 =?us-ascii?Q?XJyA7c6iy5iP/HK51rw9T0MB3bQRmO4QHtur5kULlK5QeyRcK0eU40q35o4L?=
 =?us-ascii?Q?pDvuxv5NMeByNrb2xpMamv+okrgZrWmAGS8a71c7o44uBtXManVkTujDhX8O?=
 =?us-ascii?Q?Z7uJnsw2uFWWAqM1VyUAJMFICW30hT0zBVU/th5Fnxap4wrW4UtiyWyT9M55?=
 =?us-ascii?Q?PtJwBz0sREjw09BVadqUft5RRZWf1gVK/vuK6PErUFTnjT0+Q6IFnRPTTwZo?=
 =?us-ascii?Q?dCqi+RI5s2EcrUzu4ri8DGWtRjlbIZSaHqwoiTgQ2MtsBNGhe2NWhWi06eWM?=
 =?us-ascii?Q?wNew2e/VmxhGwm9E7sWvaG7ruhlvTKk3b+3KII9sBmMQq8u7L8JbcYol+ZFX?=
 =?us-ascii?Q?2NtUknXwkFvTEd5pqhzgng5NtKm6lOe6VJ7WSFgcdnNzaBbRtN/F0XSkX0hs?=
 =?us-ascii?Q?APFbGu/w9o29e1QYpYolesd37B4TX6ubl42uQsgNIIlvFBFXnw4RasyK0dIu?=
 =?us-ascii?Q?DH9WUo+CAhgkkCUL8+z8bSdhFbPStYfV1np10Bbc7OcMKOoGF1tf6tU3FFiW?=
 =?us-ascii?Q?FGm+AmAOCRdyNfSnOv4oljjGtqMhyk2XBmmp4iBdlvDe9aqah6wRcfy/3z6U?=
 =?us-ascii?Q?d8RMQl6p7nVc1/wyQZCGs72i5/t0M5BenkPYVL0ZahxA91vL0njHVmQFR82N?=
 =?us-ascii?Q?O6HxLi5HmOwOtdFW/jSvFVo4svtC2Xd9XOItX+8w6+T3BJlkoy6m8CcZxyas?=
 =?us-ascii?Q?uIh/4UqShfY+hyh7lnKECv6+1Ivsr0EokTZvf10kezyzTGOvaGSkf6utM5VU?=
 =?us-ascii?Q?tQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5ec7e41-e737-4b52-6ba7-08daa3925b79
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 09:50:22.5801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8oBoTLFFqw+UaFRuUJ3Ve9j9TpDGDYL16PmDhuOUf9ECw4m6oih635HFmNsyI+H1Y/ZeSqAxINmNu7AEcgs7pKhDgqTH+HTqXz0nXvpnDpc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6616
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-01_06,2022-09-29_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=867 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210010061
X-Proofpoint-GUID: SR1nbTKjQIG75pMV0Gsjjlcnyb3qn-qp
X-Proofpoint-ORIG-GUID: SR1nbTKjQIG75pMV0Gsjjlcnyb3qn-qp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Rafael,

> Commit b6faaaf796d7 ("scsi: qla2xxx: Serialize mailbox request")
> serialized mailbox requests from userspace using the 'optrom'
> mutex. However, in the case of DCBX TLV data, if the memory for it is
> already allocated, then the mailbox request ends up not being
> serialized because it is done without holding the 'optrom' mutex.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering