Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: [PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading
Date:   Sat,  1 Oct 2022 12:34:08 +0300
Message-Id: <20221001093417.22388-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GXm/Qs2piqAGrt1TJK+ZG0HKFL74LeRQ6HPahp9Zko/ck0xkQm8sh9z/oakn?=
 =?us-ascii?Q?YshGRI7UJFQuflS3NYhrSIyt/40eMA2zwt+fYpgxAh0m6jLUPM7+wSF1caMl?=
 =?us-ascii?Q?jzJ5Vys+5DTZ3B7rs7Wj1yCp7ur3dq2Vs9v7DCPxrIQN4kYAYLgeqgetEwzo?=
 =?us-ascii?Q?tTkdiOAHK191GVSpz2CNeZSzJJh92Xvw/IbFt6BhMN0K0bcX+CdGWARFeZgV?=
 =?us-ascii?Q?kKNdhNJnXqSEaPxF6gkHbcAXFrcKhP+J6y8DrARdvHnQXmEJuCJOyLNzOcp/?=
 =?us-ascii?Q?mswf91hZMQJyYeg72dKetMloE8+erz0/+/cQ4w5CP3ycMAy8SBhB74wZsHA5?=
 =?us-ascii?Q?fc/8vmlVm+hNG9CdUDyS/ORNB7nMQTAn7S2bMwdlxEZp/MsVJRFD2d+97NQd?=
 =?us-ascii?Q?OowjUhKnLL6B9Jk2X91tRG5gj1DCpwUWnTmLpcs4zbtwlpUR6H1NbUL02SEz?=
 =?us-ascii?Q?vqr1zRlAPrJyiwnDQtdydPfi3HLVJz5J9eOmVY8SqePxuU+j/nUR+X2oDiaQ?=
 =?us-ascii?Q?KDzXAFc5SiIoT3LZCs2+3j6nH+d29jLVoVowyqWuMNCRoXI+H8Oc0nxy9nGt?=
 =?us-ascii?Q?lT1IaKB60xmsLpVYb2XQugpdpLMKm9CJe29JsQLW732yRr8DKBc9ncFhn+s4?=
 =?us-ascii?Q?2Gbrw7llDqoCnaLRXITn2fEiEWiEg48tnQ7ufZfgck8btV/heLuGCCL1L3qI?=
 =?us-ascii?Q?FhF9IqGm+2vxkRdQIrC3CE/ujcbCvWQsp5xKu+JXHOaIUxgZ2Imv/KPZz1PM?=
 =?us-ascii?Q?b6a9yh7LcgwzYkrU19d50KY6YFnEk2OsSdqNQj+WTCZ06nSROTt5gsiiAIFn?=
 =?us-ascii?Q?ydsO7CEr0PAmlE8qF53eW612WdTjQjAVg8znlyltSBFxIZGmi+PyeRnAnCoV?=
 =?us-ascii?Q?pqKXNkqkuaokK7CrPPv67w3ZSuqrn2wnX//4PlOXXJIDa9xCuZaIyjz4lJJa?=
 =?us-ascii?Q?Wl/uKW8dbR7a+4hbgCx6sHY08pcv8fUh34AW/eoZlrwvlXYtRYy1mmhCQvGN?=
 =?us-ascii?Q?npXVoJ1j51ifIePC3AR/DeQ6xS+taVKTrm9JRjPUY2NZHmHc6/sLFYPHjgo0?=
 =?us-ascii?Q?Rg1BBRgvElOKd7H4fuipqLBJwz1DWYkV+7TVRm1eh+n1zxyNtXJgD6rG+g40?=
 =?us-ascii?Q?zpxxZkNBgjt4Zra8JIUkILQ7xAaR1/0xvNIty3o1redMFnagsAVqq228lQk1?=
 =?us-ascii?Q?4fimLYVzYqIM6/2B9nu7uJaq2MD4sExJqIZ84iv4A7qkIBSA+JAO8KIaysyT?=
 =?us-ascii?Q?VIUZZJqDRjCLntSmLW3wXCdu6pkZJIJEZmjBPhPM+oALBP3Hx6aLZkuHywKK?=
 =?us-ascii?Q?5LJu+ieRK9f63rgnu4nj+8srTk8XCKVE5ftRY2pOXRxb0ANFdZjhBPVvWs+R?=
 =?us-ascii?Q?FrleDOEcXyL1A7Uqx6d66upHMCqlIGl6aaZyd9KXi2iqLprk14RdX1F0yYRb?=
 =?us-ascii?Q?IpEKbZksvQjElBdCoCyVhVIMIs9vjpw6BTfhYndRiTQRGBic8RfoFXkQq4kx?=
 =?us-ascii?Q?2KGbPilIwpgPiEW9UIhZiIC7OfgOI1zM9RX28b+YuA0eCOLKn7RJAQo/xJM+?=
 =?us-ascii?Q?4N+Kxd02SZRQ4D073jYTmI/sbq9eCaqqa3cZDQmhEdPU+xLBbk7Jmuu+N14z?=
 =?us-ascii?Q?xQ=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: f93afe28-0beb-42d4-36d5-08daa3902243
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 09:34:27.3837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9mgzMdTynL0+pzuq8gmroIIWhA0TLxpzouW4F8nmrimAFvlSIt1IMqkNuwGUT+n6o5e66U46JovaeRswhlQFHNtnCPONYj4hW0Q1I2fAdAk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1P190MB0733
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add support for nexthop routes for Marvell Prestera driver.
Subscribe on NEIGH_UPDATE events.

Add features:
 - Support connected route adding
   e.g.: "ip address add 1.1.1.1/24 dev sw1p1"
   e.g.: "ip route add 6.6.6/24 dev sw1p1"
 - Support nexthop route adding
   e.g.: "ip route add 5.5.5/24 via 1.1.1.2"
 - Support ECMP route adding
   e.g.: "ip route add 5.5.5/24 nexthop via 1.1.1.2 nexthop via 1.1.1.3"
 - Support "offload" and "trap" flags per each nexthop
 - Support "offload" flag for neighbours

Limitations:
 - Only "local" and "main" tables supported
 - Only generic interfaces supported for router (no bridges or vlans)

Flags meaning:
  ip route add 5.5.5/24 nexthop via 2.2.2.2 nexthop via 2.2.2.3
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 trap
        nexthop via 2.2.2.3 dev sw1p31 weight 1 trap
  ...
  # When you just add route - lpm entry became occupied
  # in HW ("rt_offload" flag), but related to nexthops neighbours
  # still not resolved ("trap" flag).
  #
  # After some time...
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 offload
        nexthop via 2.2.2.3 dev sw1p31 weight 1 offload
  ...
  # You will see, that appropriate neighbours was resolved and nexthop
  # entries occupied in HW too ("offload" flag)

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>

Changes for v2:
* Add more reviewers in CC
* Check if route nexthop or direct with fib_nh_gw_family instead of fib_nh_scope
  This is needed after,
  747c14307214 ("ip: fix dflt addr selection for connected nexthop"),
  because direct route is now with the same scope as nexthop (RT_SCOPE_LINK)

Changes for v3:
* Resolve "unused functions" warnings, after
  patch ("net: marvell: prestera: Add heplers to interact ... "), and before
  patch ("net: marvell: prestera: Add neighbour cache accounting")

Changes for v4:
* Rebase to the latest master to resolve patch applying issues

Changes for v5:
* Repack structures to prevent holes
* Remove unused variables
* Fix misspeling issues

Changes for v6:
* Rebase on top of master
* Fix smatch warnings

Changes for v7:
* Rebase on top of master
* Refactor: use "fib_lookup" instead of "fib_new_table"+"fib_table_lookup",
  according to Paolo Abeni suggestion
* Refactor: use "rhashtable_free_and_destroy" instead of rhashtable
  walk, according to Paolo Abeni suggestion

Yevhen Orlov (9):
  net: marvell: prestera: Add router nexthops ABI
  net: marvell: prestera: Add cleanup of allocated fib_nodes
  net: marvell: prestera: Add strict cleanup of fib arbiter
  net: marvell: prestera: add delayed wq and flush wq on deinit
  net: marvell: prestera: Add length macros for prestera_ip_addr
  net: marvell: prestera: Add heplers to interact with fib_notifier_info
  net: marvell: prestera: add stub handler neighbour events
  net: marvell: prestera: Add neighbour cache accounting
  net: marvell: prestera: Propagate nh state from hw to kernel

 .../net/ethernet/marvell/prestera/prestera.h  |   12 +
 .../ethernet/marvell/prestera/prestera_hw.c   |  130 ++
 .../ethernet/marvell/prestera/prestera_hw.h   |   11 +
 .../ethernet/marvell/prestera/prestera_main.c |   11 +
 .../marvell/prestera/prestera_router.c        | 1119 ++++++++++++++++-
 .../marvell/prestera/prestera_router_hw.c     |  366 +++++-
 .../marvell/prestera/prestera_router_hw.h     |   76 +-
 7 files changed, 1683 insertions(+), 42 deletions(-)

-- 
2.17.1