Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221001020045.8324-1-lizhijian@fujitsu.com>
In-Reply-To: <20221001020045.8324-1-lizhijian@fujitsu.com>
From:   Zhu Yanjun <zyjzyj2000@gmail.com>
Date:   Sat, 1 Oct 2022 18:50:47 +0800
Message-ID: <CAD=hENegJLuWZUvCVk66MFUE_m64PbqY7+mG2jZz3+Wyu4i6+w@mail.gmail.com>
Subject: Re: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     Bob Pearson <rpearsonhpe@gmail.com>,
        Leon Romanovsky <leon@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 1, 2022 at 10:00 AM Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> ib_reg_mr(3) which is used to register a MR with specific access flags
> for specific HCA will set errno when something go wrong.
> So, here we should return the specific -EOPNOTSUPP when the being
> requested ODP access flag is unspported by the HCA(such as RXE).
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Thanks.
Zhu Yanjun
> ---
>  include/rdma/ib_verbs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 975d6e9efbcb..a1f4d53a4bb6 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -4334,7 +4334,7 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,
>
>         if (flags & IB_ACCESS_ON_DEMAND &&
>             !(ib_dev->attrs.kernel_cap_flags & IBK_ON_DEMAND_PAGING))
> -               return -EINVAL;
> +               return -EOPNOTSUPP;
>         return 0;
>  }
>
> --
> 2.31.1
>