Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Oct 2022 20:00:48 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Zhang Rui <rui.zhang@intel.com>
CC:     Yu Liao <liaoyu15@huawei.com>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        <len.brown@intel.com>, Xie XiuQi <xiexiuqi@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk
Message-ID: <Yzgr8CedVK60orIG@feng-clx>
References: <20201127061131.GB105524@shbuild999.sh.intel.com>
 <87eekairc0.fsf@nanos.tec.linutronix.de>
 <bd5b97f89ab2887543fc262348d1c7cafcaae536.camel@intel.com>
 <9d3bf570-3108-0336-9c52-9bee15767d29@huawei.com>
 <YzY6e0UwDAyU1GrX@feng-clx>
 <44206484-620d-abaf-4fb9-fc4ef1c9184f@huawei.com>
 <YzZDLBKbDTbNr45b@feng-clx>
 <119b669e-aafb-4d73-e94e-ef119f909cfa@huawei.com>
 <YzbBOuX37XpUiP4y@feng-clx>
 <6491ee0f8d29d1498c79a91d712920ee96879b15.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6491ee0f8d29d1498c79a91d712920ee96879b15.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YBN6PGB5QQy60YyTuB/HHBQ/8ZbjkOjmbqEWacdkartOPCPhvixHOG431UOC?=
 =?us-ascii?Q?Sfkj+jMdWtPVzWTto57XUUbtY8ne2c1DvCdmhIhCQAWccEIFde0g0hB3vJ54?=
 =?us-ascii?Q?jzJOS4yxKWmr7fn65wdNISVeU8M+JGikZKUv0C9NHy2LO1p8Kb9bswx7LbTZ?=
 =?us-ascii?Q?hPAEEC2XAF6iw0h0SZA9CV3fnyud6dkanDal7ZZRV38I6vdj5qpws0PgSd3h?=
 =?us-ascii?Q?dp4C67BaKTxytJit3ycjjin6fteaJVvEnzIIzfao1gVE+IrUHREcIHsoyB19?=
 =?us-ascii?Q?7FRYHYGVNlYhSuIGsxjfrCZZsVyOHG2X/XSbqQdqt5vqpGE4oBG0gsZs6eWj?=
 =?us-ascii?Q?MiC6DScspBbuljZ1lbBKXXwGHLuGgyCDFxR3KCsW21sSCHV/nj3fWRIE7zMl?=
 =?us-ascii?Q?uh4lF7Z6thCiO4YlWaC3Y8TdHDJAsITOcL4OncRPWNbiF7JLqWqIm05QCQB1?=
 =?us-ascii?Q?4oC13EPA1NPix9G1bWiQfDt5BRfY5f8/Dcw/F4CEaTrlhLAzdJCXXOUU1Kgz?=
 =?us-ascii?Q?U8zzMHn1ELoN9s3vrikmKJq4ch0D6UT0vvj76ffWcpPKEgob798d1neL6oua?=
 =?us-ascii?Q?iZxPcjrbQs1tIFruhBQjMXjG9T3rTM+Axu/oTvXhS499Su1upl1Q8ZOIrBAf?=
 =?us-ascii?Q?gX6EOZRQNZA+SyLNzZI17bZddjnE6Tf2b51JVD4xLA5Ap4BulOgwVESouH/c?=
 =?us-ascii?Q?buvyigdWQoVMtUcDJUnQfV6202UtGuKPbLnzZKqAH8X6k/bxf7YD5wHVYjU6?=
 =?us-ascii?Q?g4ugpdFQdNgMnJc03BosqDI1iNUmKw+HuYfYC/5vtLfqQ5QEWWW0CzpJIGmG?=
 =?us-ascii?Q?D5Cu7BzB/r+YEwgvPFPZYMUUx52f3pImJYWjv3dXvgJnH/cNmRauqQABt5zO?=
 =?us-ascii?Q?3sUAv7Z9gqtMEin7cZpAfsX/Lz15/p7IbtxbDC0Apu2nav4/R6i7O1O80d7w?=
 =?us-ascii?Q?A28KsC+ob1GzZ/7T4VBOVZXzqAwVjGrIdcs7txVd+sQe56uTlVT8Xb6PlTKF?=
 =?us-ascii?Q?eEpJRWGmS4JjWcKODAHAw/KwMcyKDMIBlTImDazJt3UMK9DGxh064goySh4z?=
 =?us-ascii?Q?yPFrCkOziK+5WGJmUOwMErTw2gG+ylIKv/Xo7BnnMJa1678aBuf2dAiAVg7d?=
 =?us-ascii?Q?rdf3pq1rQvW3Sr0EmVOPXkSy62/LAL5TU1fCqH0WNDNNo4N0H9NHoVr1yUfX?=
 =?us-ascii?Q?dX6B81vN3FL/vVdKpYznlgDJbNZHOSzhxHYBwLXBsCwbh/jRQLGBppd0JjF1?=
 =?us-ascii?Q?bYZKT90CqAwZUYt7lfDmzWpe3zXOtvvgSn1/UmXfZjnbN8tI2/mCaTzyOkLE?=
 =?us-ascii?Q?xwAYEg9QsrhaNy/Jfnj53T0p+ANqIxzSRSrpVuRfetPqnnmjw++jVL5zyGTn?=
 =?us-ascii?Q?rDEHsV5AoURcQRM3n0CmdjA8UYHlRLNo2BF34WmvjAwZ24gUvVvpmCNJRcJT?=
 =?us-ascii?Q?H/P9RR4umxOdtDkBcCOirBYnyOPpWJlTBH0nZGS5DLgs4qcaMekPqqMQvxxq?=
 =?us-ascii?Q?wpmdUXcGh/3gFnFBGzep0mUEUkQyFPwvCCAF3bDIuGmvTyu/2BgOKqNuK7WN?=
 =?us-ascii?Q?DV5s0WuL/FyJGJiYx6qCzmSaypFQlyo+RlRqN1MU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fd5a931-29b3-4edf-496c-08daa3a4a1c3
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2022 12:01:11.4206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xnjp9onnnbYSV+BCEkZLtiyDoO9Ox63sKhIG60bmM8tpppDwm+GVrtRP0KZgtWvh9vcxqnJ4ubSiDaDOzDSvJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6112
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 01, 2022 at 01:18:05PM +0800, Zhang Rui wrote:
[...]
> > > > Thanks Xiaofeng for the info.
> > > > 
> > > > Could you try the below patch? It is kinda extension of 
> > > > 
> > > > b50db7095fe0 ("x86/tsc: Disable clocksource watchdog for TSC on
> > > > qualified platorms") 
> > > > 
> > > > which I have run limited test on some 4 sockets Haswell and
> > > > Cascadelake
> > > > AP x86 servers.
> > > > 
> > > > 
> > > > Thanks,
> > > > Feng
> > > > ---
> > > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> > > > index cafacb2e58cc..b4ea79cb1d1a 100644
> > > > --- a/arch/x86/kernel/tsc.c
> > > > +++ b/arch/x86/kernel/tsc.c
> > > > @@ -1217,7 +1217,7 @@ static void __init
> > > > check_system_tsc_reliable(void)
> > > >  	if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC) &&
> > > >  	    boot_cpu_has(X86_FEATURE_NONSTOP_TSC) &&
> > > >  	    boot_cpu_has(X86_FEATURE_TSC_ADJUST) &&
> > > > -	    nr_online_nodes <= 2)
> > > > +	    nr_online_nodes <= 8)
> > > >  		tsc_disable_clocksource_watchdog();
> > > >  }
> > > >  
> > > > 
> > > Hi Feng,
> > > 
> > > I tested this patch on a previous server and it fixes the issue.
> >  
> > Thanks for the testing, please do let us know if there is any TSC
> > problem after long time or stress running.
> > 
> > Plan to send the patch for merging.
> > 
> 
> Good to know.
> 
> This patch fixes the TSC issue for IA.
> while the patch at 
> https://lore.kernel.org/lkml/YzZDLBKbDTbNr45b@feng-clx/T/#m34094630193e8320c6d75e9c8aeabe7633e051d2
> impacts more Arches but I'm not sure if similar problem is observed on
> other Arches as well. So I will hold it for now.

I think your patch is more general and architecture independent. We've
seen quite some cases in boot phase on IA platforms, but I guess this
is also possible for other ARCHs.

Thanks,
Feng

> thanks,
> rui
>