Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0aeb2c5e-9a5e-90c6-a974-f2a0b866d64f@linaro.org>
Date:   Sat, 1 Oct 2022 18:21:18 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to
 yaml
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org
Cc:     linux-arm-msm@vger.kernel.org, agross@kernel.org,
        bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, netdev@vger.kernel.org,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        David Miller <davem@davemloft.net>
References: <20220929060405.2445745-1-bhupesh.sharma@linaro.org>
 <20220929060405.2445745-4-bhupesh.sharma@linaro.org>
 <4e896382-c666-55c6-f50b-5c442e428a2b@linaro.org>
 <1163e862-d36a-9b5e-2019-c69be41cc220@linaro.org>
 <9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org>
From:   Bhupesh Sharma <bhupesh.sharma@linaro.org>
In-Reply-To: <9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/30/22 3:56 PM, Krzysztof Kozlowski wrote:
> On 30/09/2022 10:12, Bhupesh Sharma wrote:
>>>> +  snps,reset-gpio:
>>>> +    maxItems: 1
>>>
>>> Why is this one here? It's already in snps,dwmac.
>>>
>>> Actually this applies to several other properties. You have
>>> unevaluatedProperties:false, so you do not have to duplicate snps,dwmac.
>>> You only need to constrain it, like we said about interrupts in your
>>> previous patch.
>>
>> I was actually getting errors like the following without the same:
>>
>> arm64/boot/dts/qcom/qcs404-evb-1000.dtb: ethernet@7a80000: Unevaluated
>> properties are not allowed ('snps,tso' was unexpected)
>> 	From schema: Documentation/devicetree/bindings/net/qcom,ethqos.yaml
>>
>> So, its not clear to me that even though 'snps,dwmac.yaml' is referenced
>> here, the property appears as unevaluated.
> 
> Because snps,tso is not allowed, but the rest is.
> 
>>
>>>> +
>>>> +  power-domains:
>>>> +    maxItems: 1
>>>> +
>>>> +  resets:
>>>> +    maxItems: 1
>>>> +
>>>> +  rx-fifo-depth:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +
>>>> +  tx-fifo-depth:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +
>>>> +  snps,tso:
>>>> +    type: boolean
>>>> +    description: Enables the TSO feature (otherwise managed by MAC HW capability register).
>>>
>>> You add here several new properties. Mention in commit msg changes from
>>> pure conversion with answer to "why".
>>
>> Right, most of them are to avoid the make dtbs_check errors / warnings
>> like the one mentioned above.
> 
> All of them should not be here.

I guess only 'snps,reset-gpio' need not be replicated here, as for 
others I still see 'dtbs_check' error, if they are not replicated here:


arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated 
properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth', 
'tx-fifo-depth' were unexpected)
	From schema: /Documentation/devicetree/bindings/net/qcom,ethqos.yaml

Am I missing something here?

Thanks.