Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Oct 2022 18:10:59 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Lukas Wunner <lukas@wunner.de>
Cc:     Vidya Sagar <vidyas@nvidia.com>, bhelgaas@google.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        lpieralisi@kernel.org, kw@linux.com, thierry.reding@gmail.com,
        jonathanh@nvidia.com, mani@kernel.org,
        Sergey.Semin@baikalelectronics.ru, jszhang@kernel.org,
        linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        Jonathan Derrick <jonathan.derrick@linux.dev>
Subject: Re: [PATCH V1 1/4] dt-bindings: Add "hotplug-gpios" PCIe property
Message-ID: <20221001161059.5ymdptqzslh3d55x@pali>
References: <20220930192747.21471-1-vidyas@nvidia.com>
 <20220930192747.21471-2-vidyas@nvidia.com>
 <20221001155626.GA9324@wunner.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221001155626.GA9324@wunner.de>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Saturday 01 October 2022 17:56:26 Lukas Wunner wrote:
> On Sat, Oct 01, 2022 at 12:57:44AM +0530, Vidya Sagar wrote:
> > Provide a way for the firmware to tell the OS about the GPIO that can be
> > used to get the Hot-Plug and Unplug events.
> [...]
> > --- a/Documentation/devicetree/bindings/pci/pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci.txt
> > @@ -32,6 +32,10 @@ driver implementation may support the following properties:
> >     root port to downstream device and host bridge drivers can do programming
> >     which depends on CLKREQ signal existence. For example, programming root port
> >     not to advertise ASPM L1 Sub-States support if there is no CLKREQ signal.
> > +- hotplug-gpios:
> > +   If present this property specifies the GPIO to be used for Hot-Plug/Unplug
> > +   functionality. It is used by the PCIe GPIO Hot-Plug core driver for
> > +   PCIe device Hot-Plug/Unplug events.
> 
> Please specify the GPIO's semantics in more detail:
> Is the pin high as long as presence of a card is detected?

Hello! In PCIe is this semantics called "Presence Detect" (see PCIe Slot
Capabilities). So should it be rather named "presence-detect-gpios"
instead of hotplug?

> Or does it pulse when a hotplug/unplug event occurs?
> 
> Thanks,
> 
> Lukas