Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?UTF-8?q?Micha=C5=82=20Grzelak?= <mig@semihalf.com>
To:     krzysztof.kozlowski@linaro.org
Cc:     davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, mig@semihalf.com, mw@semihalf.com,
        netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
        upstream@semihalf.com
Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema
Date:   Sat,  1 Oct 2022 17:53:53 +0200
Message-Id: <20221001155353.10211-1-mig@semihalf.com>
In-Reply-To: <db7055da-b01f-3ca6-20f8-e9bc7ed892bc@linaro.org>
References: <db7055da-b01f-3ca6-20f8-e9bc7ed892bc@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Krzysztof,

Thanks for your comments and time spent on reviewing my patch.
All of those improvements will be included in next version. 
Also, I would like to know your opinion about one. 

>> +
>> +  marvell,system-controller:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: a phandle to the system controller.
>> +
>> +patternProperties:
>> +  '^eth[0-9a-f]*(@.*)?$':
> 
> The name should be "(ethernet-)?port", unless anything depends on
> particular naming?

What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"?
It resembles pattern found in net/ethernet-phy.yaml like
properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while 
still passing `dt_binding_check' and `dtbs_check'. It should also 
comply with your comment.

Best regards,
Michał