Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp971263rwb; Sat, 1 Oct 2022 12:10:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5W/ex4hhdiFHqWErIwILegkqcrpr48jw/Y8hjMsrCyPWtmuvG3gbCNHZ3Z+nkp60OQ0UOr X-Received: by 2002:a62:3082:0:b0:55f:8fe4:a050 with SMTP id w124-20020a623082000000b0055f8fe4a050mr3870243pfw.85.1664651403511; Sat, 01 Oct 2022 12:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664651403; cv=none; d=google.com; s=arc-20160816; b=bKvRV7QV85gKmTCcnpM4Q+PMi0tvmpr+Pek0mRrMH6/ijemAQ4D8GqLahEqOPm37A1 Xsa7uie0/kRTf+izjSDgBlA/Yl9YMlrwRmU1bZsk8+YJ70mehdfZ+74uTbLAeHWcv8Jh IeWL5A9eMquhlYdPglxInuNJMhHoeNBjh54sZmjmYdoJQti6zRoqK7hfisQ8I01k4Keg GZ5LCtz2AYzYNa39BCZm9bbbibO3ULR+jeMajXJ2QGImlQUC9AuuLvhzSXfsoXpyCLAp auxJrD3cqq44+T+nWFhWmQArZSlNCRdTYp4SYs5WA8IHe8hMAReqfe2QoRF4/u5gTQGE 0ZMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9d6vGB/iMPv4rPd8u71u/RaRQeV8mLFoa5SC547lZzM=; b=jJyqP9tUU+uw0kyBcUvbM7/puYor4slB9ttr5OpJzalMG7GCffxNz9KfcQ1YABzSfK YJCQDQOhYmZbN5lB+I9EPw2e/S904HTTy4nBG9htCub1MZCuA+9kJdp9W8/f3HIAjY4b QTu9oC9GcA0/mjKW7/j10D0+u3OBR6+LE+YT1/43vvrsd8M1MUNmh3dUQkJZnJdBvh1S xVU5kRSI6v++g+7BLow+7B3PTjE8hY6iYy3c5r7d2e5nuKwtljdtYpbN331vxY4y6Y6X dSQBw7qv9+zFF78DVvrQKH1xsIIpzt8PZyBbXCGY+KaEss8gSsQkrrCIWGa4QeujUiOC /rQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 78-20020a630051000000b0044b536693ccsi1089407pga.792.2022.10.01.12.09.48; Sat, 01 Oct 2022 12:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiJATIX (ORCPT + 99 others); Sat, 1 Oct 2022 15:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbiJATIW (ORCPT ); Sat, 1 Oct 2022 15:08:22 -0400 Received: from relay01.th.seeweb.it (relay01.th.seeweb.it [IPv6:2001:4b7a:2000:18::162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59E618B08 for ; Sat, 1 Oct 2022 12:08:21 -0700 (PDT) Received: from localhost.localdomain (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id BB91F2036C; Sat, 1 Oct 2022 21:08:19 +0200 (CEST) From: Marijn Suijten To: phone-devel@vger.kernel.org, Rob Clark , Dmitry Baryshkov , Vinod Koul Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Marijn Suijten , David Airlie , Daniel Vetter , Abhinav Kumar , Sean Paul , Thomas Zimmermann , Javier Martinez Canillas , Alex Deucher , Douglas Anderson , Vladimir Lypak , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Marek Vasut Subject: [PATCH 1/5] drm/msm/dsi: Remove useless math in DSC calculation Date: Sat, 1 Oct 2022 21:08:03 +0200 Message-Id: <20221001190807.358691-2-marijn.suijten@somainline.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221001190807.358691-1-marijn.suijten@somainline.org> References: <20221001190807.358691-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Multiplying a value by 2 and adding 1 to it always results in a value that is uneven, and that 1 gets truncated immediately when performing integer division by 2 again. There is no "rounding" possible here. Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data") Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/dsi/dsi_host.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 8e4bc586c262..e05bae647431 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1864,12 +1864,7 @@ static int dsi_populate_dsc_params(struct drm_dsc_config *dsc) data = 2048 * (dsc->rc_model_size - dsc->initial_offset + num_extra_mux_bits); dsc->slice_bpg_offset = DIV_ROUND_UP(data, groups_total); - /* bpp * 16 + 0.5 */ - data = dsc->bits_per_pixel * 16; - data *= 2; - data++; - data /= 2; - target_bpp_x16 = data; + target_bpp_x16 = dsc->bits_per_pixel * 16; data = (dsc->initial_xmit_delay * target_bpp_x16) / 16; final_value = dsc->rc_model_size - data + num_extra_mux_bits; -- 2.37.3