Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Oct 2022 19:30:15 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Al Viro <viro@zeniv.linux.org.uk>
CC:     Jens Wiklander <jens.wiklander@linaro.org>,
        Sumit Garg <sumit.garg@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Christoph Hellwig <hch@lst.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        <op-tee@lists.trustedfirmware.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>
Subject: Re: [PATCH 3/4] tee: Remove call to get_kernel_pages()
Message-ID: <Yzj3t6PDIFNPyI35@iweiny-mobl>
References: <20221002002326.946620-1-ira.weiny@intel.com>
 <20221002002326.946620-4-ira.weiny@intel.com>
 <YzjfcW6OGcPP075q@ZenIV>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YzjfcW6OGcPP075q@ZenIV>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8/TDak67IWo8qZ1Lx2ZYMSZnF7+lXJuJvI+R0eTlOFixkE5aBc+JIA1K85N5?=
 =?us-ascii?Q?UVGBnV3Jft9BzuPmy0i24+wJ4eEhfO0QMR63U3dCFnppFh0vuDu0XgCiYja0?=
 =?us-ascii?Q?pKW8LFuySSCTIQOghX3qoPEoZktoG5DE8fI7k40C/ixL69ijpoYPQi+A85FC?=
 =?us-ascii?Q?X8kGvxac+YmcaPC1z+Z+3sBmwe/yIi5QqeBdcHQ5Yjhd1ZD/vkWucgAaOcUZ?=
 =?us-ascii?Q?utsKaZgQZTrq/551PG1Jsb4fnjVD3U/XQY1w2dg+qM0m5au+kh033KZrFpJ/?=
 =?us-ascii?Q?4B/j03oVqvAx+uaK0c5vhjR1kQKQZ6yBTgVGIJxv7dlLmdCL7SGUDUZHYChi?=
 =?us-ascii?Q?zPjq6SJSHOli8J3ISw0GGDQjtaj6Z9MWUQWOk3kVQg28o6Tfl7yXlHeeZF9S?=
 =?us-ascii?Q?H0SFZ4I8O3KozdunXBl2Rramw2LdO1p3uq13bHTiNyrMtewyreHLJteiFjjp?=
 =?us-ascii?Q?Shf0CgGemml+VsM+kxOA8a3kpE006mZBigL8wK5kvBKrqexPFA8Kv5vMmnih?=
 =?us-ascii?Q?8vrqdyNmrV8tmt2hLbFu1W613MBVwj1LH1vYbqU5sVqu9Iu6oVhMOqv3pAwS?=
 =?us-ascii?Q?EvsC2bJjcmYGJeyYEILpVu1QVXblaDad4XYWKA+CrOLieDTqOtOLYDh1vsoQ?=
 =?us-ascii?Q?480u1lizykRwhI261tKteU7b/6MO4Hg2EQxG+ZxFSaYGoB2OpxtlUSeq2Anh?=
 =?us-ascii?Q?0a/ZK5fo8ToRnUFuEIAnHST5uDS3cqa0UXYd6vEgHcBtZhnFyT79PXiQNKbC?=
 =?us-ascii?Q?jDSI/xVMu3b5LyqyFIW0SbQ9EY4GGjK4HzabghXbO/vBTBQoDsBiovL9RMW0?=
 =?us-ascii?Q?8aiXfC5HyogRbhxP1Tw+qOQw9fPff2u3bmJxhW7YAY52MtNDhaFwutSPcXvK?=
 =?us-ascii?Q?vaVld5XwsAip2MPlLXuo0YushLeBXNoOlLvycj4koS4uyHEcDxMUPVPIkIoA?=
 =?us-ascii?Q?u6crbgWYXoMsQgz10Ke3xjTSrxU5QflWNZo/udDUux0R2xa+wGGQ40OWbYWx?=
 =?us-ascii?Q?clthvaFyr48wyJjYyMyThjBGllRUEFnM/ZAJpjcMq0KyPR68jfMkTuhJf1SA?=
 =?us-ascii?Q?ID8asI07e0c7aISWjfzSuj8yxrMkeq74zskm2th596e0he+taOUe3wpA6cLk?=
 =?us-ascii?Q?pUIzguoHup0jJHBuVWvJJPlAwRMF/6H/uI4zPX/83ZCzr6ll7MUrU5N1j4q5?=
 =?us-ascii?Q?cZSNnZ9MqX0JlsnrSQyjZWkiDDRV1aPfXGNp+5YG9MlvlKcz23If1IzQvGJG?=
 =?us-ascii?Q?rLfCBUwhxWXcWXsebgIdXei/p34nJjgZYiVXHGQ2H21AQqdKrgdT9zyBV3mA?=
 =?us-ascii?Q?L3AlI30pNvopMh/y3a64gIO9lvHjAIYC7Hybaa+oviPk+MBP48529y770u5x?=
 =?us-ascii?Q?TowLHQW87uR2z9q75KmmQtceam/lYz8yL5vdJS1uxXwQXzoHUgHzDZ3//QGQ?=
 =?us-ascii?Q?wzSVwZSn5MMpEWV+Mh1TKNrkHGGmn2dZRw9CBfLcNg1+TNb4cm5BvqX7xE4K?=
 =?us-ascii?Q?87AlXk2DgafyfzTdyhje/oWDIafjSiUXJjDDTE7KwoxK64Jp1wqykWQsRElr?=
 =?us-ascii?Q?B9cUHdwiFWwsCIhEPnXx4yLzlWm8OCGAUnzoFhRE?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e54e00b0-3572-48a0-b9a1-08daa41e0d05
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2022 02:30:20.2205
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gmgqsp68ivwe+chd4M8crHRP+2Cip01xUXC6j87Q39xceIcx1811mRWJ14lekdD06Vb1CeyqIUgnZUKHJgGcVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5309
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 02, 2022 at 01:46:41AM +0100, Al Viro wrote:
> On Sat, Oct 01, 2022 at 05:23:25PM -0700, ira.weiny@intel.com wrote:
> 
> >  	kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL);
> > @@ -38,12 +39,12 @@ static int shm_get_kernel_pages(unsigned long start, size_t page_count,
> >  	for (n = 0; n < page_count; n++) {
> >  		kiov[n].iov_base = (void *)(start + n * PAGE_SIZE);
> >  		kiov[n].iov_len = PAGE_SIZE;
> > +		pages[n] = virt_to_page(kiov[n].iov_base);
> > +		get_page(pages[n]);
> >  	}
> > -
> > -	rc = get_kernel_pages(kiov, page_count, 0, pages);
> >  	kfree(kiov);
> 
> IDGI.  The only thing in kiov[...] you are every reading is
> ->iov_base.  And you fetch it once, right after the assignment.

:-(  Good point.  Thanks for catching that.  I was too focused on just
replacing get_kernel_pages() with get_page() and I should have refactored
more.

> 
> Why bother with allocating the array at all?
> 		pages[n] = virt_to_page((void *)start + n * PAGE_SIZE);
> would do just as well, not to mention the fact that since you reject
> vmalloc and kmap, you might simply do
> 
> 	page = virt_to_page(start);
> 	for (int n = 0; n < page_count; n++)
> 		get_page(pages[n] = page + n);

I think I'd avoid the assignment in the parameter as I would miss that if I
came back and looked at this code later.

I'll get rid of the kiov in v2.

Sorry for not cleaning it up more and thanks for the review!

Ira