Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <db7055da-b01f-3ca6-20f8-e9bc7ed892bc@linaro.org>
 <20221001155353.10211-1-mig@semihalf.com> <3b234066-268d-8da9-caa6-ca4d693dc0d0@linaro.org>
In-Reply-To: <3b234066-268d-8da9-caa6-ca4d693dc0d0@linaro.org>
From:   Marcin Wojtas <mw@semihalf.com>
Date:   Sun, 2 Oct 2022 12:23:27 +0200
Message-ID: <CAPv3WKcW+O_CYd2vY2xhTKojVobo=Bm5tdFdJ8w33FHximPTcA@mail.gmail.com>
Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     =?UTF-8?Q?Micha=C5=82_Grzelak?= <mig@semihalf.com>,
        davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
        kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, netdev@vger.kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, upstream@semihalf.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

niedz., 2 pa=C5=BA 2022 o 10:00 Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> napisa=C5=82(a):
>
> On 01/10/2022 17:53, Micha=C5=82 Grzelak wrote:
> > Hi Krzysztof,
> >
> > Thanks for your comments and time spent on reviewing my patch.
> > All of those improvements will be included in next version.
> > Also, I would like to know your opinion about one.
> >
> >>> +
> >>> +  marvell,system-controller:
> >>> +    $ref: /schemas/types.yaml#/definitions/phandle
> >>> +    description: a phandle to the system controller.
> >>> +
> >>> +patternProperties:
> >>> +  '^eth[0-9a-f]*(@.*)?$':
> >>
> >> The name should be "(ethernet-)?port", unless anything depends on
> >> particular naming?
> >
> > What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"?
> > It resembles pattern found in net/ethernet-phy.yaml like
> > properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while
> > still passing `dt_binding_check' and `dtbs_check'. It should also
> > comply with your comment.
>
> Node names like ethernet-eth do not make much sense because they contain
> redundant ethernet or eth. AFAIK, all other bindings like that call
> these ethernet-ports (or sometimes shorter - ports). Unless this device
> is different than all others?
>

IMO "^(ethernet-)?port@[0-9]+$" for the subnodes' names could be fine
(as long as we don't have to modify the existing .dtsi files) - there
is no dependency in the driver code on that.

Best regards,
Marcin