Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1595121rwb; Sun, 2 Oct 2022 04:25:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QeTqk63bEJLFnCxQDF2xDoW1tjIwTza2ntcs9GtW6ar0kAQPIYzeAYR5dbTUh5u0onekn X-Received: by 2002:a05:6402:2709:b0:451:d665:e787 with SMTP id y9-20020a056402270900b00451d665e787mr14599077edd.317.1664709954746; Sun, 02 Oct 2022 04:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664709954; cv=none; d=google.com; s=arc-20160816; b=UMki1jjd2Jd3TXnbGA8IqAqFByUGJDnpArSt/tJNK6FLqREchTCMC+amxCfvt/Aj89 7pq3uL38OiceUOogyZjvxTu8OoBUfkj/uLugPZ8HTJXDm6Xhjr2iAqbHeriMBzroOEdl tnxrM8VVKh2b4nexiPzhb1zRwC+Ml4EkqjUYe7gjnFTmAhauI+MqlmOCkHm45x/mx0fi rrCyiBZQ8HF63AYtGRSrP4WzbQ/xif2BmAdA6pAmDsYIBuMpOUDz9R+nmYJqSQxeWGTQ p0YaChDC8BLXB4nPtNpgW3EB0+JLvNdlVsE7G7RyoLFzqZR3GEuQBfk7ZiJOEMDCNBxF ByLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ms4JzvzezU1WSWXx+goApoM8T5CU3BXIVv8NBjXF9Nc=; b=FkIk8DQ7DA8jcoECPAm+baWQKIgy+9exfHxFOxqKApnRl3AeyWwNsfwkIUgVE5zYix q+cx7jHUSADT3AcUqFjY8jwtiv+aKsgqIXsrE0SZLGWdbjSUbBevhHW3TFOXxjHUdT5L LewtPdjBSIPhhf2VDnKHmfQ8Oj0Vqc7iB9LaqjOMR27UfEGu6WNXI8I5FGX/KMyLwvCa ojxcv9p1nv6mLZduM2DoC86cqYr9QJ2hscbnDdfCuWoE7Pz2w33NlWcfcJWRIGXUtpT8 06APU1StXVcPpzMflHnNgBu0OISl7vf68Qc8/+BSSyTmuX9+imKVWx9pD8nVJHKfWRKU y9/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="co9/w5K/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a1709063f8f00b0073d9c29892csi5328248ejj.939.2022.10.02.04.25.27; Sun, 02 Oct 2022 04:25:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="co9/w5K/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiJBKpZ (ORCPT + 99 others); Sun, 2 Oct 2022 06:45:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbiJBKoz (ORCPT ); Sun, 2 Oct 2022 06:44:55 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8859B3FECF for ; Sun, 2 Oct 2022 03:44:26 -0700 (PDT) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29292lsO000969; Sun, 2 Oct 2022 10:44:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=Ms4JzvzezU1WSWXx+goApoM8T5CU3BXIVv8NBjXF9Nc=; b=co9/w5K/ahSx4GJb3jKoLl1eBAfBJSktTXGhnLJmNq1NLllh64IsHPwzkvHsAmH6F2PK LEIEuoIviktwDvI6EqF8EMQxJYLhmVo+0AoPhst7qtCYumefBFATuL418/UYz32N8nJA cA7UX5Pdq3iEkljtsWY2WYhxSL9lm2NLldK8hD1OA5K4GfFlDhQhkWUf6TyM1lrc0qOI yREFovxBCClPhgYhmB3eireMR6YYYNGzbF8QiIQ53ywrBOGt6SB4XYrxRH05k1YPUn1V oZml9y8M4H9THT49hCpHtQmQyKSLK5T2WUPHf1YiXohadBk5/wAzq4js3N1LNf+X1Vq8 rg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jxxuv9stk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 02 Oct 2022 10:44:11 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 292AbRuN016899; Sun, 2 Oct 2022 10:44:11 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jxxuv9st0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 02 Oct 2022 10:44:11 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 292Aawjk031295; Sun, 2 Oct 2022 10:44:08 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 3jxd68ry96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 02 Oct 2022 10:44:08 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 292Adg2r49152292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 2 Oct 2022 10:39:42 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5EC6152050; Sun, 2 Oct 2022 10:44:06 +0000 (GMT) Received: from li-c3569c4c-1ef8-11b2-a85c-ee139cda3133.ibm.com.com (unknown [9.43.71.20]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id B96875204E; Sun, 2 Oct 2022 10:44:02 +0000 (GMT) From: Sathvika Vasireddy To: linuxppc-dev@lists.ozlabs.org Cc: jpoimboe@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, aik@ozlabs.ru, mpe@ellerman.id.au, mingo@redhat.com, christophe.leroy@csgroup.eu, rostedt@goodmis.org, mbenes@suse.cz, npiggin@gmail.com, chenzhongjin@huawei.com, naveen.n.rao@linux.vnet.ibm.com, sv@linux.ibm.com Subject: [PATCH v4 08/16] objtool: Fix SEGFAULT Date: Sun, 2 Oct 2022 16:12:32 +0530 Message-Id: <20221002104240.1316480-9-sv@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221002104240.1316480-1-sv@linux.ibm.com> References: <20221002104240.1316480-1-sv@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: qs_gTw61sfl9brztelJwRL2L3648iRKz X-Proofpoint-GUID: q8QAX2R2rJ8IS9sgxCmsvIcRrM1eGsjQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-01_15,2022-09-29_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 spamscore=0 mlxlogscore=995 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210020068 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Leroy find_insn() will return NULL in case of failure. Check insn in order to avoid a kernel Oops for NULL pointer dereference. Acked-by: Peter Zijlstra (Intel) Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index e55fdf952a3a..fe935f19447b 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -207,7 +207,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, return false; insn = find_insn(file, func->sec, func->offset); - if (!insn->func) + if (!insn || !insn->func) return false; func_for_each_insn(file, func, insn) { -- 2.31.1