Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Oct 2022 15:28:43 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Shravan.Chippa@microchip.com
Cc:     paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
        mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Conor.Dooley@microchip.com,
        Prakash.Battu@microchip.com
Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
Message-ID: <YzmD+yNv0Ryj/8IC@valkosipuli.retiisi.eu>
References: <20220920051023.12330-1-shravan.chippa@microchip.com>
 <YymuoFhxHBQLAicQ@valkosipuli.retiisi.eu>
 <PH0PR11MB56118BCE8F6B5E045485A71C81529@PH0PR11MB5611.namprd11.prod.outlook.com>
 <YzHYi2FQN1R+Ge4w@valkosipuli.retiisi.eu>
 <PH0PR11MB5611B27A6A2EFA9ABD79AB5E81599@PH0PR11MB5611.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR11MB5611B27A6A2EFA9ABD79AB5E81599@PH0PR11MB5611.namprd11.prod.outlook.com>
Precedence: bulk

On Sat, Oct 01, 2022 at 08:51:46AM +0000, Shravan.Chippa@microchip.com wrote:
> > > > > +     case MEDIA_BUS_FMT_SRGGB12_1X12:
> > > > > +             return imx334_write_regs(imx334,
> > > > > + raw12_framefmt_regs,
> > > > > +
> > > > > + ARRAY_SIZE(raw12_framefmt_regs));
> > > >
> > > > I think you'll also need changes to the pixel clock calculation.
> > > >
> > > In this driver pixel clock read only variable.
> > > Pixel clock change maybe in different series.
> > 
> > Please address it in this patch.
> > 
> > Is the link frequency affected by this patch as well?
> 
> I will try to modify my patch with the default link frequency available in the driver

Also check the frequencies the driver enables will be available in
link-frequencies.

-- 
Sakari Ailus