Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Oct 2022 13:28:41 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Sven Peter <sven@svenpeter.dev>
Cc:     Arminder Singh <arminders208@outlook.com>,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        asahi@lists.linux.dev, Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Hector Martin <marcan@marcan.st>,
        Paul Mackerras <paulus@samba.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Darren Stevens <darren@stevens-zone.net>,
        Christian Zigotzky <chzigotzky@xenosoft.de>
Subject: Re: [PATCH v2] i2c/pasemi: PASemi I2C controller IRQ enablement
Message-ID: <Yzl16W6+poH8/8h4@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Sven Peter <sven@svenpeter.dev>,
        Arminder Singh <arminders208@outlook.com>,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, asahi@lists.linux.dev,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Hector Martin <marcan@marcan.st>, Paul Mackerras <paulus@samba.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Darren Stevens <darren@stevens-zone.net>,
        Christian Zigotzky <chzigotzky@xenosoft.de>
References: <MN2PR01MB535821C8058C7814B2F8EEDF9F599@MN2PR01MB5358.prod.exchangelabs.com>
 <88f8c24a-70df-4b47-a3e8-033f6580d0d4@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="GOnV7v5ujai9iybn"
Content-Disposition: inline
In-Reply-To: <88f8c24a-70df-4b47-a3e8-033f6580d0d4@app.fastmail.com>
Precedence: bulk


--GOnV7v5ujai9iybn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

some comments from me. Thanks for the patch and review!

> > This version of the patch has been tested on an M1 Ultra Mac Studio,
> > as well as an M1 MacBook Pro, and userspace launches successfully
> > while using the IRQ path for I2C transactions.
> >
> > Tested-by: Arminder Singh <arminders208@outlook.com>
>=20
> I think it's usually implied that you tested your own patches ;)

Yes, the tag is superfluous. The paragraph before is nice, though, to
learn which testing has been applied.

> > make sure to be more responsive this time around! Also wasn't sure whet=
her
> > the v1 changelog belonged before or after the '---' so I put it after
> > to keep the commit changelog short and concise.
> > (This is just one patch, didn't think it needed a cover letter)

Both assumptions are correct.

Happy hacking,

   Wolfram


--GOnV7v5ujai9iybn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmM5dekACgkQFA3kzBSg
Kba9hRAArC/cG2qh7P6bWfW6JgLnIYB1MLq7cfQvyoZCE1h7il8NeGSxuWzD9lEB
X3NXWRWGS2lzrOTCVly+fOUGG2Fni/a25zgUimzIruLhhZCFZnNHJXOQFkIGQhrF
TalkPbFiVyp48qOtdFfHTdhdSApo/MkiBvScAOGhjmJj9ZTLsohnwToaFeUL9mnm
Rv+PiFGPAiZFV20NVvRDml0VCyYtn107jWFYvVSTKslX8vzm6APnOZeQb5zx3bde
17xagxTkZdQOby/WS0MmZNClh3CnTbnFMFhyD0npPER9MKGK6kFSl4AJ7mu9y7Ja
fuCJU2O1JQbaAk/r5WNUAkTme3jz5m95T40YaC+UNTeaKASMYakiEDsyKusU+HYg
d72Sdu4XS2ZzSVB0fD6o8aMWdsAWiN7p4FSQWsa9vmwgegKB9dIGCJplDTh3rnAh
G8gw8IhkgnaFD65/O17foP9wfJTHbnIel5n282qa6HOU7lVjiCOkgW5+fX9LamcP
GBvoc1t5GgM/NgAWvtcNXQhxtzC6dov6RLprd7qGGCSB3OnrETkiupDCsvjVmFKT
Jy039lzZghKmHLUopeuUFJdu0FEWNmY5VRnW8MaGP/ZZmHQHu22IAtKctPMZ7nkN
ngest2RL+l1RRABNYJPTcb++Z/wNCPQrgBPVaHxvQ/SaxuBrFZ0=
=iPSU
-----END PGP SIGNATURE-----

--GOnV7v5ujai9iybn--