Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 2 Oct 2022 14:33:15 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Olivier Moysan <olivier.moysan@foss.st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        nuno.sa@analog.com, Paul Cercueil <paul@crapouillou.net>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Yannick Brosseau <yannick.brosseau@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/8] iio: adc: stm32-adc: fix channel sampling time init
Message-ID: <20221002143315.05b867a2@jic23-huawei>
In-Reply-To: <CAHp75Vf1rJRVK5Emuwk4863DTb9JjTswJefJM-1oX+2gQvLMRg@mail.gmail.com>
References: <20220928164114.48339-1-olivier.moysan@foss.st.com>
        <20220928164114.48339-2-olivier.moysan@foss.st.com>
        <CAHp75Vf1rJRVK5Emuwk4863DTb9JjTswJefJM-1oX+2gQvLMRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 28 Sep 2022 19:51:04 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Sep 28, 2022 at 7:42 PM Olivier Moysan
> <olivier.moysan@foss.st.com> wrote:
> >
> > Fix channel init for ADC generic channel bindings.
> > In generic channel initialization, stm32_adc_smpr_init() is called
> > to initialize channel sampling time. The "st,min-sample-time-ns"
> > property is an optional property. If it is not defined,
> > stm32_adc_smpr_init() is currently skipped. However stm32_adc_smpr_init()
> > must always be called, to force a minimum sampling time for
> > the internal channels, as the minimum sampling time is known.
> > Make stm32_adc_smpr_init() call unconditional.  
> 
> What is the text width here? It's okay to use Up to ~72 (or slightly
> more) as a limit and format accordingly.
> 
> > Fixes: 796e5d0b1e9b ("iio: adc: stm32-adc: use generic binding for sample-time")
> >
> > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>  
> 
> Tag blocks mustn't have the blank lines.
> 
For this one, please make it clear if this is breaking current systems
or if this is more theoretical, so I can judge whether to rush it in (and
potentially slow down the rest of this patch set!)

Jonathan