Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     Jonathan Cameron <jic23@kernel.org>
CC:     "lars@metafoo.de" <lars@metafoo.de>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] iio: pressure: mpl115: Implementing low power mode by
 shutdown gpio
Thread-Topic: [PATCH v2] iio: pressure: mpl115: Implementing low power mode by
 shutdown gpio
Thread-Index: AQHY0c9qroXigyh3d0CNZ/vjgEF5xq37ICoAgABPNeA=
Date:   Sun, 2 Oct 2022 18:07:08 +0000
Message-ID: <CO1PR11MB4835CEA31B29A8235312281096589@CO1PR11MB4835.namprd11.prod.outlook.com>
References: <20220927174212.1776567-1-rajat.khandelwal@intel.com>
 <20221002142134.4d7c5fe9@jic23-huawei>
In-Reply-To: <20221002142134.4d7c5fe9@jic23-huawei>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NgY+QIo32kOVuNQ7o1LIIM6KeWy6WDQrqJsjNZ9Y8S7DJWR3e7zKyCVdwi7R?=
 =?us-ascii?Q?aXl96Xa71YGJ6TcxEeWAUmkHvKsCKlUrxAEEVJb1biidlkNt98LmmTcxGlWs?=
 =?us-ascii?Q?MjuRitP2WiWS+vEl+Z1snTndMLb3JOAx9qpNCSslTRSqxHuZjDwabkpZzce+?=
 =?us-ascii?Q?x203PXullf3+VCKQHp7vBMHhnk/ZCmeGf1gKHsGgZg/pbGARBSI0awk/+619?=
 =?us-ascii?Q?fTcyo3WTVGAXc2mewLDqjuMtp8FBP+ekDAeFtfyFc3zDK0tKShQaZkE1OItb?=
 =?us-ascii?Q?icLfVv6qkH8CqwCvl6hsp4RddgWntLxjV8zoa3nej2kYMZX2qd/uYkjjUxlC?=
 =?us-ascii?Q?HST7WXz67pLWCTVFsisufPRwnM+z8glgQBCwV+nKucG6FM9IPFVSHBhUd98A?=
 =?us-ascii?Q?Z6GjKApzzsCxmeHeaKxXH8mB8oW2f/DnKrNyX1nyEW0QlcXniPsVvvCWhPzL?=
 =?us-ascii?Q?awVFu1t4LQZdMff7pwaK6bmU1Czx4d/cYiW8rbQ1kxWBsfxojaAbY4l68lCk?=
 =?us-ascii?Q?Cupu5USzN9rI52Pfjqlhoo4QdnLVq2G1pN/oY1jHVFPUKnzS730vIwyk0PwO?=
 =?us-ascii?Q?5Y0TKQ7kKiAaeVyCzA9LYXWrGWHoLklWPeWakZMnT2i1gKowxmo0kYxFQjwE?=
 =?us-ascii?Q?6bBNFSgtLdRc+k2CrU3USWfnZDoiyd3SsVJFSi8GwBz2vgm54Pya/mBTFwnD?=
 =?us-ascii?Q?9Bv/0zZlTsILtz8o4xwzpDy6xTm+sB/j3AZpbhXP2Z0nv5d5NQryo3XcF3wR?=
 =?us-ascii?Q?Gm0gI7KxT+dn6+f5KgFQhHVWDcUE8GNBhgxr0/MEPSTVBYh8D5ekEcKcY6h1?=
 =?us-ascii?Q?atrFRhvMaAUqrU4rcM/hHxJe9WIBJxX9YqHH6QygqHxbgd3q+OSYCbCQKZeL?=
 =?us-ascii?Q?vlvEUWyTtp+CeJyFe7fzGuR/7Zfg/M+alTho7kGgjYAOq2FxmoXvxcxJVXRk?=
 =?us-ascii?Q?govXR/WYP1IJ/zlLufAQrMb1W1mBl7hKErWH933ty/TEbEW5dlBJRrbZcogd?=
 =?us-ascii?Q?wvNLH2ik6poLNfmo2alGCEjMCJJ1oART8Lu2X4QIyewotU8WmyQ5Z4pZuN//?=
 =?us-ascii?Q?xTORoUMG3wnDRmY6E4VNcnbmwc82nCJJy1Lene1Jkl3/QblypnQxlalKR1/e?=
 =?us-ascii?Q?b6PxeTvHRr1GDYYH/TFsLY+NwwkPvisQe39wtcBg3a5bYbDpak5L+4if9BmX?=
 =?us-ascii?Q?rYAj59mNA1bPsebTnmIz8EDJ5UEbCGmnav4rLnRs0GOmOm+VPfa7rhdn9VZy?=
 =?us-ascii?Q?AZg1vIftjoislcm+3icNyxCrNcVrG1BZ3D+oJ0zGDlhWB5sUe3U62hCQ+eDO?=
 =?us-ascii?Q?IEb00fjsXfcpfkG4lHePtwKao6XS9VBpGgFHfi+w9hkH1FHMdSx9eN1G6yL3?=
 =?us-ascii?Q?+Ocfdua1zYyxFtoP7lHXmNaI2J91FW68C8PSNcwuQYTxZ8USZ9sxs+O6h77c?=
 =?us-ascii?Q?xLfNyXbB1+xLfaA0dy2VVUmZTpIDMXuvc0KqMOybr8jT9yX/P6ahIw/Bmrtw?=
 =?us-ascii?Q?Xd4L4VmR2HPLZ8NzQz6pjJQ96EIWXORfwCLW+H3S3Ea2r5tqIonYAsqunDqF?=
 =?us-ascii?Q?+QlS+DQYf9arP8wo0lOOWTj0Oiva+tTz9hCE3SxLoKKvuL+Sn04HRlS6jAi6?=
 =?us-ascii?Q?Sg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 367ce9aa-2350-4cc0-0868-08daa4a0eba3
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2022 18:07:08.0930
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zcVEOVSUXvNohXCbdKWBi0XToQsAxXkbFFdiR5tCIL+9bq6Xr/QkmyeFoTeBZTwzl1ADu+GOLugdK6ShqyRUyRrrO2Hli2LJZyUEGSZQEyo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5139
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>Ah. I missed there was a v2 and replied to v1.
No problem Jon and thanks for the suggestion. A delay of 5ms
was not worth it when calculation itself takes only ~3ms.=20
I have implemented runtime PM keeping a delay of 200 ms
which I think should suffice. Have sent you v3.=20

-----Original Message-----
From: Jonathan Cameron <jic23@kernel.org>=20
Sent: Sunday, October 2, 2022 6:52 PM
To: Khandelwal, Rajat <rajat.khandelwal@intel.com>
Cc: lars@metafoo.de; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.or=
g
Subject: Re: [PATCH v2] iio: pressure: mpl115: Implementing low power mode =
by shutdown gpio

On Tue, 27 Sep 2022 23:12:12 +0530
Rajat Khandelwal <rajat.khandelwal@intel.com> wrote:

> MPL115 supports shutdown gpio which can be used to set the default=20
> state to low power mode. Power from all internal circuits and=20
> registers is removed. This is done by pulling the SHDN pin to low.
> This patch sets the default mode to low-power and only exits when a=20
> reading is required from the chip. This maximises power savings.
>=20
> According to spec., a wakeup time period of ~5 ms exists between=20
> waking up and actually communicating with the device. This is=20
> implemented using sleep delay.
>=20
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@intel.com>
Ah. I missed there was a v2 and replied to v1.

> ---
>=20
> v2: Grammatically completing subject line
>=20
>  drivers/iio/pressure/mpl115.c | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/iio/pressure/mpl115.c=20
> b/drivers/iio/pressure/mpl115.c index 5bf5b9abe6f1..c0ad3e941d05=20
> 100644
> --- a/drivers/iio/pressure/mpl115.c
> +++ b/drivers/iio/pressure/mpl115.c
> @@ -3,13 +3,12 @@
>   * mpl115.c - Support for Freescale MPL115A pressure/temperature sensor
>   *
>   * Copyright (c) 2014 Peter Meerwald <pmeerw@pmeerw.net>
> - *
> - * TODO: shutdown pin
>   */
> =20
>  #include <linux/module.h>
>  #include <linux/iio/iio.h>
>  #include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> =20
>  #include "mpl115.h"
> =20
> @@ -27,6 +26,7 @@ struct mpl115_data {
>  	s16 a0;
>  	s16 b1, b2;
>  	s16 c12;
> +	struct gpio_desc *shutdown;
>  	const struct mpl115_ops *ops;
>  };
> =20
> @@ -102,13 +102,27 @@ static int mpl115_read_raw(struct iio_dev=20
> *indio_dev,
> =20
>  	switch (mask) {
>  	case IIO_CHAN_INFO_PROCESSED:
> -		ret =3D mpl115_comp_pressure(data, val, val2);
> +		if (data->shutdown) {
> +			gpiod_set_value(data->shutdown, 0);
> +			usleep_range(5000, 6000);
> +			ret =3D mpl115_comp_pressure(data, val, val2);
> +			gpiod_set_value(data->shutdown, 1);
> +		} else
> +			ret =3D mpl115_comp_pressure(data, val, val2);
> +
>  		if (ret < 0)
>  			return ret;
>  		return IIO_VAL_INT_PLUS_MICRO;
>  	case IIO_CHAN_INFO_RAW:
>  		/* temperature -5.35 C / LSB, 472 LSB is 25 C */
> -		ret =3D mpl115_read_temp(data);
> +		if (data->shutdown) {
> +			gpiod_set_value(data->shutdown, 0);
> +			usleep_range(5000, 6000);
> +			ret =3D mpl115_read_temp(data);
> +			gpiod_set_value(data->shutdown, 1);
> +		} else
> +			ret =3D mpl115_read_temp(data);
> +
>  		if (ret < 0)
>  			return ret;
>  		*val =3D ret >> 6;
> @@ -185,6 +199,17 @@ int mpl115_probe(struct device *dev, const char *nam=
e,
>  		return ret;
>  	data->c12 =3D ret;
> =20
> +	data->shutdown =3D devm_gpiod_get_optional(dev, "shutdown",
> +						 GPIOD_OUT_HIGH);
> +	if (IS_ERR(data->shutdown))
> +		return dev_err_probe(dev, PTR_ERR(data->shutdown),
> +				     "cannot get shutdown gpio\n");
> +
> +	if (data->shutdown)
> +		dev_dbg(dev, "low-power mode enabled");
> +	else
> +		dev_dbg(dev, "low-power mode disabled");
> +
>  	return devm_iio_device_register(dev, indio_dev);  } =20
> EXPORT_SYMBOL_NS_GPL(mpl115_probe, IIO_MPL115);