Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755985AbXFYBir (ORCPT ); Sun, 24 Jun 2007 21:38:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752347AbXFYBij (ORCPT ); Sun, 24 Jun 2007 21:38:39 -0400 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:44431 "EHLO sous-sol.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbXFYBii (ORCPT ); Sun, 24 Jun 2007 21:38:38 -0400 Date: Sun, 24 Jun 2007 18:38:18 -0700 From: Chris Wright To: James Morris Cc: Chris Wright , linux-security-module@vger.kernel.org, "Serge E. Hallyn" , Andrew Morgan , Andrew Morton , Stephen Smalley , lkml , Arjan van de Ven , Greg KH , Eric Paris Subject: Re: [PATCH][RFC] security: Convert LSM into a static interface Message-ID: <20070625013818.GC3723@sequoia.sous-sol.org> References: <20070618044017.GW3723@sequoia.sous-sol.org> <20070620171037.GA28670@sergelap.ibm.com> <20070620174613.GF3723@sequoia.sous-sol.org> <20070621160011.GB9913@sergelap.austin.ibm.com> <467CD63B.4000703@kernel.org> <20070624155100.GA5167@vino.hallyn.com> <20070624220903.GB3723@sequoia.sous-sol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14 (2007-02-12) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 32 * James Morris (jmorris@namei.org) wrote: > On Sun, 24 Jun 2007, Chris Wright wrote: > > > * James Morris (jmorris@namei.org) wrote: > > > -module_param_named(disable, capability_disable, int, 0); > > > -MODULE_PARM_DESC(disable, "To disable capabilities module set disable = 1"); > > > + > > > +static int __init capability_disable_setup(char *str) > > > +{ > > > + capability_disable = simple_strtol(str, NULL, 0); > > > + return 1; > > > +} > > > +__setup("capability_disable=", capability_disable_setup); > > > > This changes the command line argument. Other than that and a some > > sanity testing I'll take this. > > Do you mean the name change, or the logic? > > The name needs to change because kernel parameters are in a global > namespace. Sorry, I mean it's currently capability.disable (and the only reason it matters is that at one point I know there were users of it). thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/