Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92ef6be6-dc99-555d-8263-77484b7d0f12@gmail.com>
Date:   Mon, 3 Oct 2022 10:17:19 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3] Documentation/process: Add text to indicate supporters
 should be mailed
Content-Language: en-US
To:     Joe Perches <joe@perches.com>
Cc:     corbet@lwn.net, konstantin@linuxfoundation.org,
        Theodore Ts'o <tytso@mit.edu>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux@leemhuis.info, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220930064629.329514-2-bryan.odonoghue@linaro.org>
 <21f8d79a-0ad4-b28b-15d8-f4be0cfd9730@gmail.com>
 <b119fee5-807f-1940-3378-f5ad638794f5@linaro.org> <Yzen4X1Na0MKXHs9@mit.edu>
 <70759d05-2646-57e5-0b87-3a196488f622@linaro.org>
 <dabbb4aa-d5e1-10d5-082c-1386f3314fc8@linaro.org>
 <f7f6a67c5ee662f24885579ba09b281a5d597b0a.camel@perches.com>
 <de5e732e-4857-dc69-a6c1-f0c1d52f99ef@gmail.com>
 <b5731dab6be760fd226097602cf31c610d69bdac.camel@perches.com>
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <b5731dab6be760fd226097602cf31c610d69bdac.camel@perches.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 02 Oct 2022 16:55:05 -0700, Joe Perches wrote:
> On Mon, 2022-10-03 at 08:04 +0900, Akira Yokosawa wrote:
>> Hello Joe,
>>
>> Thank you for chiming in.
>>
>> On 2022/10/03 0:49, Joe Perches wrote:
>>> On Sun, 2022-10-02 at 09:58 +0200, Krzysztof Kozlowski wrote:
>>>> The easiest to achieve it is to run with --no-git-fallback and CC entire
>>>> output. However it does not mean submitter must run with
>>>> --no-git-fallback. It is only for this generic rule - CC entire output
>>>> of get_maintainers.pl.
>>>>
>>>> If you add such rule "CC entire output of get_maintainers.pl" and do not
>>>> mention no-git-fallback, some folks will think they need to CC all these
>>>> people who made one commit to your file...
>>>
>>> false.
>>>
>>> git-fallback is _not_ used when there is a listed maintainer for a
>>> specific file.
>>>
>>> If there is a use of git-fallback, it's because there is _no_
>>> specified maintainer for a specific file.
>>>
>>>    --git-fallback => use git when no exact MAINTAINERS pattern (default: 1)
>>>
>>> i.e.: It's not "your file" if you don't maintain it.
>>
>> Joe, I sometimes see unexpected output WRT --git-fallback.
>>
>> Example:
>>
>>     $ ./get_maintainer.pl -f Documentation/doc-guide/sphinx.rst
>>     Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION,commit_signer:1/1=100%)
>>   <-- ???
>>     Lukas Bulwahn <lukas.bulwahn@gmail.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
>>     <-- ???
>>     linux-doc@vger.kernel.org (open list:DOCUMENTATION)
>>
>>     linux-kernel@vger.kernel.org (open list)
>>
>> As you see, --git-fallback is used in this case. Why?
>> It looks strange to me as Jon is listed as a "maintainer".
>>
>> Having "F:	Documentation/" in MAINTAINERS does not suffice?
> 
> No.  It's not an exact pattern match as the files below the
> top level of Documentation are not specifically matched by
> "F:	Documentation/".
For me, calling this is "not an exact pattern match" sounds
inconsistent with the explanation (quoted below) near the top of
MAINTAINERS:

	F: *Files* and directories wildcard patterns.
	   A trailing slash includes all files and subdirectory files.

What am I missing?
Does this explanation needs update?

Regards,
Akira

> 
[...]