Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2236031rwb; Sun, 2 Oct 2022 18:57:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5T4ckZaHXTkeZxne9fRz1x69JTErogkXPUx8Xdk7ip/a+7OMrc626hYZE0NISnFRO1C3im X-Received: by 2002:a05:6a02:11a:b0:441:9db5:e8cc with SMTP id bg26-20020a056a02011a00b004419db5e8ccmr11930053pgb.345.1664762221884; Sun, 02 Oct 2022 18:57:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664762221; cv=none; d=google.com; s=arc-20160816; b=aDRkYAbv0GJKn3iH5CiMfA4+YjksXOakxWr6XprEdYMMQnTO2rjDzJlejTj6CKEBOT 7dA90SH1e9jvK4TkLUMIJfd5PDFOMCkJz3LYjeg746jU012kctxzn0HUy6wWB4JeA6Nu bY4qd58qivsD/Wf1NoOz2XY0W/WGT07119PDxkd5dJJaIEq6p86DS3dZ5E3PZwIuUPO4 ajr+X7Eo+NIKRZJYZumjlFqMIXpZHBaLWmOP5fRBaX7JXnc3EZQnCPA8jupR0lbxPFh7 7E71+O8EH4+IXHVogPCQ5bREaSKlFEJAKGXvAnBvEFhuEirXhQRKfCZqb6Al0FE0k9d8 9vxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=Kj9iUsN0oZC3wn1dqS/AFHCRuJoxxeZUSqMImJwTRtc=; b=UX1jNYa4H+LK2Z5KjEaMKdXsEwc19arbKon4Na/HuP7hRTsn6fO1dQABvducFFmPvA JTX8Rfu1mYyjYmeU+bTrFfMKdJvp++sHlrq15vR5RFam4JMO/hXqnOuDfud8LI1c2NJc 5OEzLTQyiXjMSDRzxQrBUkJ/agOJzj1uZJN6mWhub87JT9D60IOEn51CKdCTjoOfQXQW 8yfCx7qEyWULzHI+o+0GOclxB4YW57fMqPjAhR096QSWoumRzgy8/rxZr957566ST39O IAVvAFctzD+FcjOda6q8nzeDCVmmE9Yg5dd+IK8oaTqbHypCOlAU+EHqywkNPDWshCwv OE0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k189-20020a6384c6000000b0044f2a51ef3asi1818703pgd.565.2022.10.02.18.56.50; Sun, 02 Oct 2022 18:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbiJCB2c convert rfc822-to-8bit (ORCPT + 99 others); Sun, 2 Oct 2022 21:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiJCB2b (ORCPT ); Sun, 2 Oct 2022 21:28:31 -0400 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53AB73DBC9; Sun, 2 Oct 2022 18:28:26 -0700 (PDT) Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B947B16084F; Mon, 3 Oct 2022 01:28:24 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id D2A3C20011; Mon, 3 Oct 2022 01:28:05 +0000 (UTC) Message-ID: <7c6cbef1e9bac94267113a4c722f265b43573810.camel@perches.com> Subject: Re: [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed From: Joe Perches To: Akira Yokosawa Cc: corbet@lwn.net, konstantin@linuxfoundation.org, Theodore Ts'o , Bryan O'Donoghue , Krzysztof Kozlowski , linux@leemhuis.info, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 02 Oct 2022 18:28:21 -0700 In-Reply-To: <92ef6be6-dc99-555d-8263-77484b7d0f12@gmail.com> References: <20220930064629.329514-2-bryan.odonoghue@linaro.org> <21f8d79a-0ad4-b28b-15d8-f4be0cfd9730@gmail.com> <70759d05-2646-57e5-0b87-3a196488f622@linaro.org> <92ef6be6-dc99-555d-8263-77484b7d0f12@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_NONE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Stat-Signature: c15sbosoea1tute7j655pjpy7xzaabt6 X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: D2A3C20011 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+H7+Vkcd5CPGjNrRcZXSavSLuzcr1318Q= X-HE-Tag: 1664760485-274211 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-10-03 at 10:17 +0900, Akira Yokosawa wrote: > On Sun, 02 Oct 2022 16:55:05 -0700, Joe Perches wrote: > > On Mon, 2022-10-03 at 08:04 +0900, Akira Yokosawa wrote: > > > Hello Joe, > > > > > > Thank you for chiming in. > > > > > > On 2022/10/03 0:49, Joe Perches wrote: > > > > On Sun, 2022-10-02 at 09:58 +0200, Krzysztof Kozlowski wrote: > > > > > The easiest to achieve it is to run with --no-git-fallback and CC entire > > > > > output. However it does not mean submitter must run with > > > > > --no-git-fallback. It is only for this generic rule - CC entire output > > > > > of get_maintainers.pl. > > > > > > > > > > If you add such rule "CC entire output of get_maintainers.pl" and do not > > > > > mention no-git-fallback, some folks will think they need to CC all these > > > > > people who made one commit to your file... > > > > > > > > false. > > > > > > > > git-fallback is _not_ used when there is a listed maintainer for a > > > > specific file. > > > > > > > > If there is a use of git-fallback, it's because there is _no_ > > > > specified maintainer for a specific file. > > > > > > > > --git-fallback => use git when no exact MAINTAINERS pattern (default: 1) > > > > > > > > i.e.: It's not "your file" if you don't maintain it. > > > > > > Joe, I sometimes see unexpected output WRT --git-fallback. > > > > > > Example: > > > > > > $ ./get_maintainer.pl -f Documentation/doc-guide/sphinx.rst > > > Jonathan Corbet (maintainer:DOCUMENTATION,commit_signer:1/1=100%) > > > <-- ??? > > > Lukas Bulwahn (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%) > > > <-- ??? > > > linux-doc@vger.kernel.org (open list:DOCUMENTATION) > > > > > > linux-kernel@vger.kernel.org (open list) > > > > > > As you see, --git-fallback is used in this case. Why? > > > It looks strange to me as Jon is listed as a "maintainer". > > > > > > Having "F: Documentation/" in MAINTAINERS does not suffice? > > > > No. It's not an exact pattern match as the files below the > > top level of Documentation are not specifically matched by > > "F: Documentation/". > For me, calling this is "not an exact pattern match" sounds > inconsistent with the explanation (quoted below) near the top of > MAINTAINERS: > > F: *Files* and directories wildcard patterns. > A trailing slash includes all files and subdirectory files. > What am I missing? > Does this explanation needs update? Maybe. Suggest some text. Read about the pattern-depth entries (basically, it's the count of forward slashes '/' in a maintained file pattern) Look for MAINTAINER entries where there are /*/ entries too. For instance: MAINTAINERS-INTEL ETHERNET DRIVERS MAINTAINERS-M: Jesse Brandeburg MAINTAINERS-M: Tony Nguyen MAINTAINERS-L: intel-wired-lan@lists.osuosl.org (moderated for non-subscribers) MAINTAINERS-S: Supported MAINTAINERS-W: http://www.intel.com/support/feedback.htm MAINTAINERS-W: http://e1000.sourceforge.net/ MAINTAINERS-Q: http://patchwork.ozlabs.org/project/intel-wired-lan/list/ MAINTAINERS-T: git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git MAINTAINERS-T: git git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git MAINTAINERS-F: Documentation/networking/device_drivers/ethernet/intel/ MAINTAINERS-F: drivers/net/ethernet/intel/ MAINTAINERS:F: drivers/net/ethernet/intel/*/ <<< Here >>> MAINTAINERS-F: include/linux/avf/virtchnl.h MAINTAINERS-F: include/linux/net/intel/iidc.h So this entry is show that all of drivers/net/ethernet/intel// are directly maintained.