Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b35f756d-08e7-6eed-5992-ad63ee419e1f@os.amperecomputing.com>
Date:   Mon, 3 Oct 2022 09:06:46 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.0
Subject: Re: [PATCH v9 3/3] i2c: aspeed: Assert NAK when slave is busy
Content-Language: en-CA
To:     Wolfram Sang <wsa@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Brendan Higgins <brendan.higgins@linux.dev>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        thang@os.amperecomputing.com
References: <20220929080326.752907-1-quan@os.amperecomputing.com>
 <20220929080326.752907-4-quan@os.amperecomputing.com>
 <YzjFRrCRZBAaSRBL@shikoro>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <YzjFRrCRZBAaSRBL@shikoro>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTlHbzZKWnVXdFZ5ZDlBbFcvR1lNekY4NVd3REl6cE1jR08rcGo2bGFneFZP?=
 =?utf-8?B?ZTFrTy96Smc3UHFBU05OV1JxazZXT3dGT3IwS0p3RXo0RlpmWHZLOHR4OUg1?=
 =?utf-8?B?VmlubFQ2M3hlcW5xc05EdnBiOWt1V1RJNU9YT3JsUkZRTHM5aVFrVDhxRTRG?=
 =?utf-8?B?Ymp2YTFpb2NyaHcrdVFLVW5QVlVTU0RYSVFlay9JMzhrTmZVb05PTkR5NDVi?=
 =?utf-8?B?MytKbCsvK0lzeHZ4SElvbi9WckFXMTBXU1o1dnFaZGx3Y2oxVHNSbVdtanpq?=
 =?utf-8?B?VTFid3NjRnExR3c1Tk9rZjg0ZU0rQ0dXTHNpNXN1cG1ac2RrVWZmUTEwQStW?=
 =?utf-8?B?aERRQ2I2a2NnclI4UnJHQXhSVS9CaHFBbStUQ2l3WUl6dklGWG9JK3d6RHha?=
 =?utf-8?B?OWQwdWozVDRySTcwL1REZGozYW8xZ1F6c21EcFYvalYzMHJjclFjVHlHSXhV?=
 =?utf-8?B?eUtBYVZpMzc4blNjNSt4RW1Takx3RXF6K0VackdZZjhCdktXTlN1VzZsOEhj?=
 =?utf-8?B?K1pBNFdCeVllUTJ0bWU2dXZXcGx4eW1ENE5FZ1FhdTdZdjV6eEZLRGNnNmFK?=
 =?utf-8?B?UThsQnNUQTVsaGlrS2RBUm14OTRhdHNLM1B2M0hMYWpYS0ZsSDF0UWo0STBs?=
 =?utf-8?B?VjFOaEN5SEZoWW5lYm9JOEw3MWdpWExMNXdZQmg0ejkyd3d6OXFqcGh4NGxE?=
 =?utf-8?B?cU8yV2ZrNFd6NTdLUnpEYlhjWUxuMzA0N0RrSFU5QUc3MU1hVUxyMlJDOHVR?=
 =?utf-8?B?UzY0SW94MEJUdFdqTTVDZ2VTQ1N1QTJndklrUHc4SG9Md0gxV0ZQWFdJeHp1?=
 =?utf-8?B?WjZCSjVsYnZ4VE9QL2JPWm9HOEtkUTd0Z04yT2hQMTFlckZ5dnlmdWx4ZEg2?=
 =?utf-8?B?UjFFR3hZR3dRTjk2SEZ2SDByM0cvaEMxVWRNNGx3S3lDMXZEc0VKWndBUVBz?=
 =?utf-8?B?TWRrS3dYL1dZZ0dEakg2Y3lvNVdERWdybDJCeWt0THZDQ2tBL3lWQUsyVnZr?=
 =?utf-8?B?TWZ4WU5YaERpOUxvb05rTTJlRDVPOE11djFrTHBPMmVVVnkybG16M3FWQzZD?=
 =?utf-8?B?cWR3QWFXT01rbnFFR0hVSExnWkJ5L1gzckNaQW1FVS9kbHIzTVJQeTdnL2hO?=
 =?utf-8?B?bkFwb0Y5RDhWOTNnUEhJQXhVc1dka0J1RFczdFd2VlZHLzYzU21HaEd4M0Fs?=
 =?utf-8?B?RFcyckxiYjJjeGVVQmtDSkY5MEtlUDd4aVM1YTBIRU8wT2RpL1BGWlZsd2pz?=
 =?utf-8?B?WC9jKzkrSTcvcWR4RGVDdmkrOVVSQmRTNWRSZEkvVlIxNnE0cHNjdFRsS3NQ?=
 =?utf-8?B?c1BQUDZTNVVHUE11L09NQW5FWHpRNk5Ec3I2WWVIOFpwTXRkZzltMXEyRHJh?=
 =?utf-8?B?NXNYYVd3aEpQL2JNYTcyQWlyYjBWZytwQ1RLcW5OSWtjbnovUVNRQ2VqekRG?=
 =?utf-8?B?OCtyTFVJdGUzSzdqSWgxVVpjbHN5eEFGOHFYcHRFcWFCVUd2d0N2eExLcUx6?=
 =?utf-8?B?WWhhY3VicmJXQXBMT1AySHZER2VmL2lreG9FMlBPVUdkd09wdERiVDlhbVll?=
 =?utf-8?B?MndpcGVhV0pnbWo0WmtoeHIwL2J6MWZHRzhpMld1eFBzRW0yQnc5Q2N5RGtL?=
 =?utf-8?B?b1kxcjVhOHAyQ1JnY1ZBN3BqSitQb3hwTUwzbzJkVzI5RlRLMDdPc2FXdW5s?=
 =?utf-8?B?YkhCNlZDQjhPZTRkUUFkM3JnaHZQK0h2ajlVelAxZGlGekV0aHJabmxPZnd5?=
 =?utf-8?B?Nkwwb2hBY2Z5bUF5akVleVN3eU4zRmZFMFh0Q1BSaUtEaHd4Y3czbjU1TXJQ?=
 =?utf-8?B?YVAxVzgzQXdOSCtZVElSU2FuVWhYYmo4cm11dWtHSHdpd3VMTXV6cTVaNk5y?=
 =?utf-8?B?MVdnWlNDVjhvTGo0RUZyaUlYYXp4ZUZyY0FUcFBnOEZzWml1bzBFRUNZS0M2?=
 =?utf-8?B?cmhqSDZjNVA2Uy9CVU05SU5CMU1pbjBVTXplQnJFM2lFcGw5QmJRcUFZNnNB?=
 =?utf-8?B?cWZNUWkwWGRGendLRXZYNjkvUy9kMGgwQlc4VE1iWGVNc2E5WTNjb3VDUExz?=
 =?utf-8?B?a1lBOU9udnp4TmY4dldwZk9DL0ZKLy92RHEyWFJhNWhMU25TR2NMZ1E0K2xB?=
 =?utf-8?B?ZkgvVHllZGtvdXIwa3U2SGpQWG5aWGRDbEsrSmtJa3lFNTdzK0NxRFZvYzd4?=
 =?utf-8?Q?I+9o9dOAtyO4OZC4xFXBghQ=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1490bbca-1b1b-44cc-8ddd-08daa4e3f312
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 02:06:57.3644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sHYOweJKfXXSqA6xmj9OR7zcYXRnhtWyowJ4eH446Z5FtYN2k1dz5bxLLAtOqx7hZ8bXZOzPjd/OELqPN8sxV2jZGn/LZVHsRY1rj0ECQUg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR01MB5776
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 02/10/2022 05:55, Wolfram Sang wrote:
> 
>> +		if (ret == -EBUSY)
> 
> Since we documented this:
> 
> "+  'ret': 0 if the backend is ready, otherwise some errno"
> 
> the code above should be '(ret < 0)'
> 

Will update.
Thanks a lot for the review.

- Quan