Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAJedcCzjWw6v5Nt42jsCStdpwHuz13D+q-CD=6ycVWBczY+4mg@mail.gmail.com>
 <20220928033340.1063949-1-zyytlz.wz@163.com> <Yzmds3DXu32EeSO5@kroah.com>
In-Reply-To: <Yzmds3DXu32EeSO5@kroah.com>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Mon, 3 Oct 2022 12:36:56 +0800
Message-ID: <CAJedcCy5TbdskDVK5Z2-Bm9gTG+sbo1KkFn3_2n65Sno7xG+ag@mail.gmail.com>
Subject: Re: [PATCH] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Zheng Wang <zyytlz.wz@163.com>, 1002992920@qq.com,
        airlied@linux.ie, alex000young@gmail.com,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        jani.nikula@linux.intel.com, linux-kernel@vger.kernel.org,
        security@kernel.org, tvrtko.ursulin@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> That is a horrible way to make an api (and it should be a bool too.)
> Now every time you see this call in the code, you have to go look up
> what the last parameter means.  Just make 2 functions, one that does the
> "is error" thing, and one that does not, and that will be much easier to
> maintain and understand for the next 10+ years.

Got it. I'll figure out anothr way. :)

Thanks,
Zheng Wang