Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 08:39:22 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Pete Zaitcev <zaitcev@redhat.com>,
        Juergen Stuber <starblue@users.sourceforge.net>
Subject: Re: [PATCH] USB: make devnode() callback in usb_class_driver take a
 const *
Message-ID: <YzqDmvohy9shngxy@hovoldconsulting.com>
References: <20221001165128.2688526-1-gregkh@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221001165128.2688526-1-gregkh@linuxfoundation.org>
Precedence: bulk

On Sat, Oct 01, 2022 at 06:51:28PM +0200, Greg Kroah-Hartman wrote:
> With the changes to the driver core to make more pointers const, the USB
> subsystem also needs to be modified to take a const * for the devnode
> callback so that the driver core's constant pointer will also be
> properly propagated.
> 
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Pete Zaitcev <zaitcev@redhat.com>
> Cc: Juergen Stuber <starblue@users.sourceforge.net>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/hid/usbhid/hiddev.c     | 2 +-
>  drivers/usb/class/usblp.c       | 2 +-
>  drivers/usb/misc/iowarrior.c    | 2 +-
>  drivers/usb/misc/legousbtower.c | 2 +-
>  include/linux/usb.h             | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)

Looks correct and complete.

Reviewed-by: Johan Hovold <johan@kernel.org>