Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2446977rwb; Mon, 3 Oct 2022 00:14:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6H2hNngMwE2Ut8I+92+Y8F3ndGtFc9Vwxsff1FMQywbO2wGSjwJBT37forEGMvDcPYnFxZ X-Received: by 2002:a17:907:d04:b0:76e:e208:27ba with SMTP id gn4-20020a1709070d0400b0076ee20827bamr14678545ejc.652.1664781258231; Mon, 03 Oct 2022 00:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664781258; cv=none; d=google.com; s=arc-20160816; b=sr3eS+z1aTXoBdlj/+RcSNceUate+zah7j2E8omIcgXXsYcnqygmMKB8234UCqnnFg HN2sAvYE1lBYQe7tUfYYjexLi6G1cX4ko5lDUSiqz5h04RhYzbxnvR924GS3YGAr4LKC /KL7eZTg1euq1nYsE9Z7fDducjPFvtfwatDY7tefv+WOnaEapxc28kCnqT+tTKFahgfi qSGPW65H0mjU2DIzZNsS13MFu8zkNsAzecI9/14o1J4lIl7q2PAkgSEZS0RQXu9veOx+ BP4AaZH9rojzVFR1OCixM9Y3hUaSmbu1NqjeHpJBk+ODjOltKRyA+0xg1h4x9Xo843Nq GKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=SeK8Sk/+yiZcfff3vIcmr/JFhl6MA/TK7AvFrNExFgQ=; b=Rb1vPK+rjLc4eLxtP3QCi77W0gUvdHMXAbtTocrXpHrgLr+6+O+6fVlk4rCxQzfprK FIuHCmrtJAzEjJ/Ygux1j6NDYArdQBcXoSSs+btoY2Egu+QqMunniCTjRtT2F2HwnwK2 JONcKwOf8/1o9z73wZ5wnwtddorfgQC8FJF0IcP7xa9Q8aMi1sJlWhW6yiw2rFkCXWFx M607DFlSvdB3sMtuk7es0NQmz7l7R5JABULLOurnPDxGEMtrXozvRHQ37RGcxqdINQXh JvzZ4oHHsEF5W7a11gxM7IPVA/6N4zpRg/JLjUkLBpwF8pAul7G889uIcV5qWZXujXhU gFDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=BG53+uh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b25-20020a056402139900b004511944f801si6786857edv.270.2022.10.03.00.13.53; Mon, 03 Oct 2022 00:14:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=BG53+uh7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbiJCHIn (ORCPT + 99 others); Mon, 3 Oct 2022 03:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiJCHIl (ORCPT ); Mon, 3 Oct 2022 03:08:41 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D59356FE; Mon, 3 Oct 2022 00:08:37 -0700 (PDT) X-UUID: 2a9c42cef5bd468f848428d8ff8f9aae-20221003 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=SeK8Sk/+yiZcfff3vIcmr/JFhl6MA/TK7AvFrNExFgQ=; b=BG53+uh7uptuDhUZzLaPRcWqRWjcwXBdVEUN1zXRK+TYP+oMSEExWTJ+jK+H03J5Ns9xHm2LrtJwWK4IfPbGl2QOrgoaMvFvbWuiCezETmQQEtVmkd+TRdEcwKiXF3s/eNLiyegiqeO4uoks60rNxijVmdLtGheyH2S2WnS+TdI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:74558886-c25f-482b-948e-65c86153a918,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:90 X-CID-INFO: VERSION:1.1.11,REQID:74558886-c25f-482b-948e-65c86153a918,IP:0,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTIO N:quarantine,TS:90 X-CID-META: VersionHash:39a5ff1,CLOUDID:7e6cd6a3-dc04-435c-b19b-71e131a5fc35,B ulkID:221003150834AGMT48GA,BulkQuantity:0,Recheck:0,SF:38|28|17|19|48|823| 824,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil, COL:0 X-UUID: 2a9c42cef5bd468f848428d8ff8f9aae-20221003 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 223572744; Mon, 03 Oct 2022 15:08:32 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 3 Oct 2022 15:08:31 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 3 Oct 2022 15:08:31 +0800 From: Moudy Ho To: Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil CC: Chun-Kuang Hu , , , , , Moudy Ho Subject: [PATCH v2 0/2] Fix error handling for MDP3 Date: Mon, 3 Oct 2022 15:08:28 +0800 Message-ID: <20221003070830.23697-1-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SPF_TEMPERROR,UNPARSEABLE_RELAY,URIBL_CSS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes since v1: - Rename goto label in mdp_comp_clock_on() from "err_unwind" to "err_revert" to make more readable. Hi, This series fixes some error handling in MDP3 in response to the bug report submitted by Dan Carpenter (Message ID = YxB1E00e8D6P4W2e@kili) Moudy Ho (2): media: platform: mtk-mdp3: fix error handling in mdp_cmdq_send() media: platform: mtk-mdp3: fix error handling about components clock_on .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 51 ++++++++++--------- .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 24 ++++++--- 2 files changed, 45 insertions(+), 30 deletions(-) -- 2.18.0