Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755878AbXFYEs4 (ORCPT ); Mon, 25 Jun 2007 00:48:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753281AbXFYEst (ORCPT ); Mon, 25 Jun 2007 00:48:49 -0400 Received: from mailgw.cvut.cz ([147.32.3.235]:45050 "EHLO mailgw.cvut.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbXFYEst (ORCPT ); Mon, 25 Jun 2007 00:48:49 -0400 Message-ID: <467F492B.6000002@vc.cvut.cz> Date: Sun, 24 Jun 2007 21:48:43 -0700 From: Petr Vandrovec User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.1.4) Gecko/20070509 Iceape/1.1.2 (Debian-1.1.2-1) MIME-Version: 1.0 To: James Morris CC: Chris Wright , linux-security-module@vger.kernel.org, "Serge E. Hallyn" , Andrew Morgan , Andrew Morton , Stephen Smalley , lkml , Arjan van de Ven , Greg KH , Eric Paris Subject: Re: [PATCH try #2] security: Convert LSM into a static interface References: <20070617135239.GA17689@sergelap> <4676007F.7060503@kernel.org> <20070618044017.GW3723@sequoia.sous-sol.org> <20070620171037.GA28670@sergelap.ibm.com> <20070620174613.GF3723@sequoia.sous-sol.org> <20070621160011.GB9913@sergelap.austin.ibm.com> <467CD63B.4000703@kernel.org> <20070624155100.GA5167@vino.hallyn.com> <20070624220903.GB3723@sequoia.sous-sol.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 30 James Morris wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture. Hello, > -module_param(debug, bool, 0600); > -MODULE_PARM_DESC(debug, "Debug enabled or not"); > +static int __init root_plug_debug(char *str) > +{ > + debug = simple_strtol(str, NULL, 0); > + return 1; > +} > +__setup("root_plug_debug=", root_plug_debug); is this necessary? What about just documenting root_plug.{vendor_id,product_id,debug}, so it won't break existing root_plug users (if there are any) ? I thought that typed module_param() is prefered over untyped __setup()... Thanks, Petr - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/