Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2514513rwb; Mon, 3 Oct 2022 01:43:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QaCv92/1qxumXFaa4fW5c2thN9tsB3CXfBxSv6xsxXesxnKj257nqSbyaegqT6jOCwyKW X-Received: by 2002:a17:90b:3804:b0:205:e70c:43fc with SMTP id mq4-20020a17090b380400b00205e70c43fcmr11235798pjb.2.1664786601196; Mon, 03 Oct 2022 01:43:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664786601; cv=none; d=google.com; s=arc-20160816; b=oLSDh9Ix1RjOBBKm/SwyYVVkHvFoZvXRBn9lJpZKYX8mb1dr2anHOB6uatDPOSTZ7E Hxo03e8HMOppBJeZ9LQs9O5MksDZOleFggYI0VaL3AvMZfNCoaa2aMrfABg6oYbhPRmO JPF7EwHaFzczU9lLS/smKu/CNlFSNYKRwDdJ+3yEHBoaFMKZFXZv4TcklhpidtQZrjRs teK/N9TNf0t/iLpf7XQMvAnDcAm1yeEbgeJP/MP9dsP/ZmFN/lvG617sJtRa3V4mYAJE tt7pI68Ib0ivx2VNpPI/VLqiouH2zeNMal5/fTYjgsewQzLvd7wf+NT8qg0FcKfr/j8t IoGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BWwTc2XMYZiohvbH9aTadw/q5xMniW6K7G6FcTgeGGk=; b=RnvZEfK2orn/Ptu0tjveNbhddH1n5t+eEr/clpBPcIMvpktSWDJqGi6GnVcier9a6e o0GDGTOYI2JrBntLW2R8qGHBepi0/x+Eo5ax7p10d8x+21TVbQnmhEum/DhPQoT/0MjC U13xY1SRj9ufmyts+NCLlz1X1U4u6e1Cnzg7RB88VmGmzQxt/uzwK9MzVXdaiL1Hj2+d RCziLbr6Dye1tbXJrvqoF5WmFz9lyJLVM3/l3zWbw0dkvMTXuOjfhYfEfyrEKRLzjBek Uzc/+E/eNHUKtIoxlgU4hCGvlQKl8zKgIPP20CltMfEtCU4HKg8TKWlXy0iWQmzrxzE5 s8HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=09iJRUrE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c2-20020aa781c2000000b0053bafb8e916si8784107pfn.162.2022.10.03.01.43.09; Mon, 03 Oct 2022 01:43:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=09iJRUrE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231712AbiJCHh6 (ORCPT + 99 others); Mon, 3 Oct 2022 03:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbiJCHgI (ORCPT ); Mon, 3 Oct 2022 03:36:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6207A52FFA; Mon, 3 Oct 2022 00:22:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4A601B80E8A; Mon, 3 Oct 2022 07:22:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2EF9C43141; Mon, 3 Oct 2022 07:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664781721; bh=JABYIPv91GI+S0ua6dZSI1yJNmbGkgRRzkrWid95eYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=09iJRUrEmQaGbBAFYUXtuvo5qsrUXkSoGXBmQg4LNTWsK8eIu9WERr7IXWvEvoSHy yGCaFZBzHOKOSu9qPDUFLsB2j2N/IBTDEpZ/mtmiqTIAvd2JnngVeB6AxfC6DPifqn Keg3ot3TxQnn5bgx65eInGDpueb2xb+FevA8HDIk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Dmitry Torokhov , Sasha Levin Subject: [PATCH 5.10 40/52] Input: melfas_mip4 - fix return value check in mip4_probe() Date: Mon, 3 Oct 2022 09:11:47 +0200 Message-Id: <20221003070719.929247894@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221003070718.687440096@linuxfoundation.org> References: <20221003070718.687440096@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit a54dc27bd25f20ee3ea2009584b3166d25178243 ] devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER), add a minus sign to fix it. Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220924030715.1653538-1-yangyingliang@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/melfas_mip4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index f67efdd040b2..43fcc8c84e2f 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1453,7 +1453,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) "ce", GPIOD_OUT_LOW); if (IS_ERR(ts->gpio_ce)) { error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) + if (error != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get gpio: %d\n", error); return error; -- 2.35.1