Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2521439rwb; Mon, 3 Oct 2022 01:52:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cQowcNoJwvBoEOTep9QUGbKl9CwkCBYkU5JwR8V7EUMkPX8p3Py2LE4DHD8oslCcSWPqa X-Received: by 2002:a05:6a00:804:b0:544:4e98:3ff3 with SMTP id m4-20020a056a00080400b005444e983ff3mr21425669pfk.36.1664787143980; Mon, 03 Oct 2022 01:52:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664787143; cv=none; d=google.com; s=arc-20160816; b=nwunDdFm+ohxMFX6GU1j7+evrEkrAruB+rz1J29BSk3t5Ax1TAjAmRhDRFFCv34ziR balGBcNX8myXSWb7RmxBo00sYRP0wTUCiXwo2Ur8dGVwSyFOY/C0et8HkAeL/y3xRWMI PHMpWAAKA9hRvV4IV0SexbPbwnHs+ty5BXXDCNINcpAEUgkdxUSTafWhhp3Gum9yEkg0 /edxhk3iit+lZzahFS/zOre9sQy1l7IKbW7qC/QnZtPdgnAbcUbcqKf3XsI3r4TSIbFA ySbHutUOkfzPXWzg4OveSJT7USfJTDFm8ndrD3wrj8MZIbFQH1NG9P7IPQm17Euy9adB KMSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4A+RIwkpmBYMjLfwGcjXPg3fKUBO8uZ8NdBeag7cE8k=; b=NakNUEcCUtp9wOVTmkVDqSUWhldEEVL7OdHBFWKmoc9yYFx8uJRo274fKpgYPo+1IA 2Xh5vwXgFxMza8v2SBAjjYQG90LTRxGx+2GaSACJxFXNOMh9ibSqbivWnfd+dQH2h0fi aOFql+cbc6Klt/wqx0yuWX/zAry0gWTm8qhQHCrs7HgeT4nH+nw7W2sSD7xjivmtPaHp Q3jj9ImiqKOA5nC7YKSYIymkx48j27/m2HbSbSd8Vmby/HiH0p80bvRl4vsM5WgJH3tY /gsnucKqk3FBWPBZhwMKHvj5Dh0sMbGCS5ouFRTBRZJGagWrmAgx6FrZrHY09vFk6P9C oh/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EhHDRfsj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mu6-20020a17090b388600b00205593e76e8si14937254pjb.81.2022.10.03.01.52.12; Mon, 03 Oct 2022 01:52:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EhHDRfsj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232057AbiJCHoy (ORCPT + 99 others); Mon, 3 Oct 2022 03:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232165AbiJCHno (ORCPT ); Mon, 3 Oct 2022 03:43:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D95F9543DE; Mon, 3 Oct 2022 00:25:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4D197B80E96; Mon, 3 Oct 2022 07:25:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7110C433B5; Mon, 3 Oct 2022 07:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664781917; bh=dn25CVpD2oaYtaktFbYJOqPGka3DxfJ6hLgw9cNW8sQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EhHDRfsjIQVsvfb29GUQi5a7H3pKnJQeOjC+1v1DoEG+of/TaBV5mncZWGDgomw1a AqTft7SFsyiyIoYzgwfXPgMQ6RW7sQrCmkQoIABCQjVFYYUcjA3nKUkNxjQnvdc8Xj W0US4NxLZr2v2a9850BZoJgkLwlSSLn9Sh5UwZJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.19 20/25] Input: melfas_mip4 - fix return value check in mip4_probe() Date: Mon, 3 Oct 2022 09:12:23 +0200 Message-Id: <20221003070716.014220255@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221003070715.406550966@linuxfoundation.org> References: <20221003070715.406550966@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit a54dc27bd25f20ee3ea2009584b3166d25178243 ] devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER), add a minus sign to fix it. Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220924030715.1653538-1-yangyingliang@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/melfas_mip4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 430a2bc5f7ca..5d947e721fa5 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1462,7 +1462,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) "ce", GPIOD_OUT_LOW); if (IS_ERR(ts->gpio_ce)) { error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) + if (error != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get gpio: %d\n", error); return error; -- 2.35.1