Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2530448rwb; Mon, 3 Oct 2022 02:03:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Ml9dyJrQthk/XhXionfI8nOvseONfhF8s8fJSTgqNNrB44QwhVkUIQNsN2c8bE53T8xvg X-Received: by 2002:a17:90a:b00b:b0:203:a6de:5b0f with SMTP id x11-20020a17090ab00b00b00203a6de5b0fmr10954119pjq.134.1664787795493; Mon, 03 Oct 2022 02:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664787795; cv=none; d=google.com; s=arc-20160816; b=HY24/P5es4GaImuuCalT4zXT3Sj51EVJq5ZkIOa560/nVZUNy7ETQoBmT/yZBGQXEg unPuAQFo8qk22CuwI2S2gJVjIGxYHWrH9jpzELiZ7WMwK6vk3FwNYH/HsDVhEGfz+H0T nfDS/P79PUJmM46IgxNeeWLiH1wJGjprgkD1B4KF3OhYxnJpTORA7E1mD76nDjbGNIAp 1ioj58gNu5yHRLrJIHLjlqCHBdJ15t9EwpU2qRx9mGysquLkhnUT0rSPQ9laly/lDgpP p6DQQ4+H/rkOV0Nz83iaaPkMsXYSKG3/3NUcto4jnWCBgNkVWWu0ff2eg/7kxR2mziHV eaSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:from; bh=lOUdKjM63vhO0T+j6pqlxE6SWF9QKCLU2WE1cQBJyRw=; b=xFS4fdXZdvcPLXgR5YUaUpu33ZR8wTUwnqgcfwmrlIhqYtKlQ0IUYm+cLAIslpzWsA VGB47aqPR0OAKcJHX1fGEejATiUPtsRd6wshbnSzwUSsorxU+wvmZQbFPbYC3XNG75dA HOovi68DRAbCPdJSuGZnXCTGR5G/FY0zZcVtd0bInGg5lRLYl3WAw3io0BKKRiTB30gr 7sWQjjfz5KOq9ATywRDF67VK1zud5ZDO+nZO8/5NYTod5ovgZC/7j02YikqrPiswEa52 X5+fxQuh6rnRH2IMKjVkkjezN6Bj3tFi3PWBJQNUBmU0vAqhOG2RuqLW0W0rKeGoF0CX +5vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=ctaTHnJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j14-20020aa783ce000000b00536c7c210d3si9137253pfn.171.2022.10.03.02.03.03; Mon, 03 Oct 2022 02:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cutebit.org header.s=mail header.b=ctaTHnJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbiJCIjB (ORCPT + 99 others); Mon, 3 Oct 2022 04:39:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbiJCIi3 (ORCPT ); Mon, 3 Oct 2022 04:38:29 -0400 Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD43D5817E; Mon, 3 Oct 2022 01:12:06 -0700 (PDT) From: =?UTF-8?q?Martin=20Povi=C5=A1er?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1664784710; bh=lOUdKjM63vhO0T+j6pqlxE6SWF9QKCLU2WE1cQBJyRw=; h=From:To:Cc:Subject:Date; b=ctaTHnJQldRcCXLIX3r9q0j72Cn3manep7GcIAh19t36JjO3NQDMExm86acu7uVEo qWjlJ/n3u2kegGNwFWia9TgCMlu3xkYfUmPgjXW9RwpusOv+vfjCpAT+NyAurrkBb7 +5qiyUyma8iXCPVAsaMzxbWfHs4tD3rJe0jgaaYY= To: Vinod Koul Cc: =?UTF-8?q?Martin=20Povi=C5=A1er?= , asahi@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 1/2] dmaengine: apple-admac: Fix grabbing of channels in of_xlate Date: Mon, 3 Oct 2022 10:10:52 +0200 Message-Id: <20221003081053.1826-1-povik+lin@cutebit.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_FAIL,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_xlate callback is supposed to return the channel after already having 'grabbed' it for private use, so fill that in. Fixes: b127315d9a78 ("dmaengine: apple-admac: Add Apple ADMAC driver") Signed-off-by: Martin PoviĊĦer --- drivers/dma/apple-admac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c index d1f74a3aa999..6780761a1640 100644 --- a/drivers/dma/apple-admac.c +++ b/drivers/dma/apple-admac.c @@ -490,7 +490,7 @@ static struct dma_chan *admac_dma_of_xlate(struct of_phandle_args *dma_spec, return NULL; } - return &ad->channels[index].chan; + return dma_get_slave_channel(&ad->channels[index].chan); } static int admac_drain_reports(struct admac_data *ad, int channo) -- 2.33.0