Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for
 apptrust
Thread-Topic: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for
 apptrust
Thread-Index: AQHY1DNZUjZtLK0dzEirZyaNJNiZ+634H/uAgAQj3gCAABBpAIAAB0yA
Date:   Mon, 3 Oct 2022 08:17:30 +0000
Message-ID: <Yzqc85mqkuakokCE@DEN-LT-70577>
References: <20220929185207.2183473-1-daniel.machon@microchip.com>
 <20220929185207.2183473-5-daniel.machon@microchip.com>
 <87zgegu9kq.fsf@nvidia.com> <YzqJEESxhwkcayjs@DEN-LT-70577>
 <87lepxxrig.fsf@nvidia.com>
In-Reply-To: <87lepxxrig.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?++L/NxK/LO5EItgK0rIWaQGtJbOyMw7IM/ZtyNbt2ggBUWYqxvvoCC7vg7tT?=
 =?us-ascii?Q?hfRzk3ZUcGDRNC2bWZNymA10XHpGkz/7fMWY9E9BRv3XslQPb9UcM1/9bY0t?=
 =?us-ascii?Q?oIHUndcAtAETScvFu4M+Lbzgn18F2HKtUqCTNR0gC+L5jbDcjtdqoqouf5vM?=
 =?us-ascii?Q?Dlsr+28pllkomJG3wczdzOPJ1PG7XZl/VCubuKX2HCURI4mg3+8MT9pCheYb?=
 =?us-ascii?Q?9In1w1hX9VNAUfX3t/1lQJ/96OufpFskHymum3ePjdGJRCSgtEEI8yfOCY+W?=
 =?us-ascii?Q?rypKfoLbNDs/gfqtKvxy0QjvobowVu7VqfLUz2AaV2J2UflSnsWpdZkammVm?=
 =?us-ascii?Q?qgFkxN6c17uoi69kPB+Y8UvRaoUgbwef1TifjuvHW2LFyvaqsOfQ2FPkIBL3?=
 =?us-ascii?Q?kb2YSHjtqH8iP4cS7IL3KEdGwTWUQiNsqe9XEzQ6aEvUvvn54ZJrWb5cswHR?=
 =?us-ascii?Q?k5X2agApEUxLWDAiJEu4b0DFJS3CCVvuVhuwfUE+GOpe0bFN77ikSjDD1qH9?=
 =?us-ascii?Q?vS3tXAUMtmtuS8nXyulf8/NvbfPmaaGFv9GmxRcBZwO4TYs9fbjVP3S/77Hb?=
 =?us-ascii?Q?w7nx3vuZDSAMU8QGRbERio/kk7kmE74TrR2nUfi3PAgfv3B7+CL4tmraPnmc?=
 =?us-ascii?Q?2sS87MHH581H3Y7cTn9AN9kZed5rj4QqtNtE023REBhRbldq+1KIg2+JQd7G?=
 =?us-ascii?Q?nj6fMe6zWDI2qPOgpZy6Dt5nOfj5H/IZriGQEhXmzb6Ub4I8xpLBpdutKJm6?=
 =?us-ascii?Q?u5Ookb3Spw7YzVlrBdguxg50VkcXvNb/ZRZ2mY13P8iKVs/DEldtWWKScJEx?=
 =?us-ascii?Q?Qb4ep9Yphdyjq9sX7aPZ+NYqXcCMC1kcQHAJ2xZi9MVnpmKfU/cmjH3Ew489?=
 =?us-ascii?Q?G0sDqezRnel8zrQLOfMp933aBAAOrnPQtHC1cMAy2pE9kYhhJCPZECbIT9yi?=
 =?us-ascii?Q?17NLkskuI+tpXMPQEfQ7GO9Mls26PnO3BWxM5X6cgTyjJvhC/bDcbCWkCrhI?=
 =?us-ascii?Q?OSosn8sH+791Sin+1ylLJa32ZGmS+PzXBucAsHahafqNagqUY2HZdWwO00lR?=
 =?us-ascii?Q?BQrLmoctCKLwHt1x6KfBOdNweXM402eE7LR94oDe7kvsrDn+97fqD0wv81JJ?=
 =?us-ascii?Q?KQGqRnhqjsPGrRQLfVRsDtfAIQykaw/mK4HqfXajB53xFe/zdT92SwkdzR++?=
 =?us-ascii?Q?uZQAq7Eu/lrfAjAFACz5lDi/cq2CDHkpiEuniQOpfz6QmnAffp8xMDpeICCV?=
 =?us-ascii?Q?k7aSjPpVqs2vL1dGEw6+od75tTNyUP1KH4SAB6+3lAlzxBkXl6wou0qKsUg9?=
 =?us-ascii?Q?MLYjDjpafT4uv/0eVbRR52ibyjCr3t5b9t1HHmUvij1cgSQZtuwo91+tQsln?=
 =?us-ascii?Q?3S/PCT1b3zMFhRUJwArNdOVPj09Z+nmtRRGiqRS0mDE9EhBzJZdNvjgBKVuX?=
 =?us-ascii?Q?HWI9ymrypRLQw1haXMiRHbTfO4v01g0W9CJjEP97t3c6NAjBkz7MhHs83283?=
 =?us-ascii?Q?E32E99Tb/jM7fHPOXLReJnDVfLVgk8lRImtgAcWKvaa3jG5zdSMb2SxpP9N2?=
 =?us-ascii?Q?tS3uWxhuc3GdLN3F4eVv0PBMOAWZ43fiH8FspgQ323WzIP7ERQU+FOSIrXrW?=
 =?us-ascii?Q?5ItDFnc1bulMHrPLrZijks0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <851C4612D281AF4FBAA77DBF115A39CC@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5580.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0de1cbc0-2e9f-4dea-2568-08daa517b75a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 08:17:30.5003
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gfHBfflbgL56ppc1NVEMG+2wQRUr+FF276Yd70Pj0hzAkjL7Bz4H61TzYhZqxzOMf2JziWk+vu/5MnaKxUsT1408gpzMJDKv+1C+iMcoaGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6393
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >> > Make use of set/getapptrust() to implement per-selector trust and tr=
ust
> >> > order.
> >> >
> >> > Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
> >> > ---
> >> >  .../ethernet/microchip/sparx5/sparx5_dcb.c    | 116 +++++++++++++++=
+++
> >> >  .../ethernet/microchip/sparx5/sparx5_main.h   |   3 +
> >> >  .../ethernet/microchip/sparx5/sparx5_port.c   |   4 +-
> >> >  .../ethernet/microchip/sparx5/sparx5_port.h   |   2 +
> >> >  .../ethernet/microchip/sparx5/sparx5_qos.c    |   4 +
> >> >  5 files changed, 127 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/dr=
ivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > index db17c124dac8..10aeb422b1ae 100644
> >> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > @@ -8,6 +8,22 @@
> >> >
> >> >  #include "sparx5_port.h"
> >> >
> >> > +static const struct sparx5_dcb_apptrust {
> >> > +     u8 selectors[256];
> >> > +     int nselectors;
> >> > +     char *names;
> >>
> >> I think this should be just "name".
> >
> > I dont think so. This is a str representation of all the selector value=
s.
> > "names" makes more sense to me.
>=20
> But it just points to one name, doesn't it? The name of this apptrust
> policy...

It points to a str of space-separated selector names.
I inteded it to be a str repr. of the selector values, and not a str
identifier of the apptrust policy. Maybe sel(ector)_names?

>=20
> BTW, I think it should also be a const char *.

Ack.

>=20
> >> > +} *apptrust[SPX5_PORTS];
> >> > +
> >> > +/* Sparx5 supported apptrust configurations */
> >> > +static const struct sparx5_dcb_apptrust apptrust_conf[4] =3D {
> >> > +     /* Empty *must* be first */
> >> > +     { { 0                         }, 0, "empty"    },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP }, 1, "dscp"     },
> >> > +     { { DCB_APP_SEL_PCP           }, 1, "pcp"      },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP,
> >> > +         DCB_APP_SEL_PCP           }, 2, "dscp pcp" },
> >> > +};
> >> > +=