Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2554657rwb; Mon, 3 Oct 2022 02:28:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Nu7rVAZvInzlGmvrfkFuOv84x97npmmStXUQfUaTQ1wQG1a6rHpV3oSBOjBxwDNAnIByF X-Received: by 2002:a17:906:8251:b0:781:8016:2dc9 with SMTP id f17-20020a170906825100b0078180162dc9mr14697918ejx.488.1664789308594; Mon, 03 Oct 2022 02:28:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664789308; cv=none; d=google.com; s=arc-20160816; b=Co6itaz6bpZZoQRMWqo4ErEWb9Jwu+F5W/ztpgY/umD/MqSWG1+4Nh0o/lpF1x6OoG Hr+sq6hNQrbG2INLV7vrfFdoXLRSIClp6xbu67zHxrHtqRKy3BT5NDDnwqUkdYkyKPaC iuIOshEJ5ND6MG6QKcCC81WJQmgJMHaaNhpZGhLbBlMrU60m6GMWVjaymFajZY988K/X WtAE1dL2Z0v5KiC7Ye0jDyTrzWPLgYhKVLftmnb8gsc9+ITrRRK7i5BPUMnu4QyEOGpP Nz8tOtyqi+NaEb8eXevKLMnu9dKi1epkOjlub7z6aj2tdUg7IDi4NvsvRmd+Wfkt9QSJ ruhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JjSIqvSvODn3NK/Ii0MBrZe4YlDP7W4a/O5RLw82x9M=; b=WIIsz8fYMEQtzmoE6sUHx3woLtbzx2YuAQtg7rf3KhoL6YHHXA9Y62mDKwBJLbMgXa nZ7ld3wJS98h8eMOaYaWaVo6Fw51cy92BSmjQXEcBR8/RNFW+2Q6FPVzn5ZEDfEUINcl HbbI2f58HugPBo6OKTjhNnSk0l5oa6i4QEImOuoJLflC4z8MLbCrbw7QN/HEj5HGIrHI oa11fcCSmB8GcGctRez29FIytCoq9iPSFTZkNiDtuVybJEXkSJPOlBlvaeOgWR6IOFb4 0uLSN6GjovZEqQ5ntko8wh4vMtsba3qHa7zzNZDs7k7LHUGfrk5xlEdu5wn57RaDj5Ed l1wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v68Eg1GZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a170906318200b00783ac0b4d32si6604255ejy.941.2022.10.03.02.28.02; Mon, 03 Oct 2022 02:28:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v68Eg1GZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232040AbiJCHov (ORCPT + 99 others); Mon, 3 Oct 2022 03:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbiJCHnY (ORCPT ); Mon, 3 Oct 2022 03:43:24 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61BA029816; Mon, 3 Oct 2022 00:25:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B75EB80E8B; Mon, 3 Oct 2022 07:18:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1E5FC433B5; Mon, 3 Oct 2022 07:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664781534; bh=+VAuBlT2qbjuexas2uWO4klILw2NI4Bx5UICdkowzKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v68Eg1GZP3feD8T2qggA7KeJCJ3Tqvskw1oBPWlFKBXe7r2yg6KtYvEs7Q8s7fIyf 0CqcqyfczZWMIoi0KYPEHfJ94quCj4GHYLcRei1XWfqLJsogS5Mt9D+wb7eNRfrfLp ACE23Nx9+n+GEhQ40hThbDXqg9ErIjw11i3lpkGk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Dmitry Torokhov , Sasha Levin Subject: [PATCH 5.15 54/83] Input: melfas_mip4 - fix return value check in mip4_probe() Date: Mon, 3 Oct 2022 09:11:19 +0200 Message-Id: <20221003070723.357996608@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221003070721.971297651@linuxfoundation.org> References: <20221003070721.971297651@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit a54dc27bd25f20ee3ea2009584b3166d25178243 ] devm_gpiod_get_optional() may return ERR_PTR(-EPROBE_DEFER), add a minus sign to fix it. Fixes: 6ccb1d8f78bd ("Input: add MELFAS MIP4 Touchscreen driver") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220924030715.1653538-1-yangyingliang@huawei.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/melfas_mip4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 2745bf1aee38..83f4be05e27b 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1453,7 +1453,7 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) "ce", GPIOD_OUT_LOW); if (IS_ERR(ts->gpio_ce)) { error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) + if (error != -EPROBE_DEFER) dev_err(&client->dev, "Failed to get gpio: %d\n", error); return error; -- 2.35.1