Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 10:20:37 +0200
From:   =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
To:     =?utf-8?B?TWHDrXJh?= Canal <mcanal@igalia.com>
CC:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        "Melissa Wen" <mwen@igalia.com>,
        =?utf-8?B?QW5kcsOp?= Almeida <andrealmeid@igalia.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Daniel Latypov <dlatypov@google.com>,
        David Gow <davidgow@google.com>,
        "Arthur Grillo" <arthur.grillo@usp.br>,
        Isabella Basso <isabbasso@riseup.net>,
        <magalilemes00@gmail.com>, <tales.aparecida@gmail.com>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] drm/tests: Split
 drm_test_dp_mst_sideband_msg_req_decode into parameterized tests
Message-ID: <20221003082037.7xwtb62rjqh6josw@nostramo>
References: <20221001223422.857505-1-mcanal@igalia.com>
 <20221001223422.857505-2-mcanal@igalia.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221001223422.857505-2-mcanal@igalia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmNTc1dHTGtFSkp1NlZlaXZjUVI2eUcwSjd6RkdRYkQ5THpwbjI2VDNuU2li?=
 =?utf-8?B?Z2IxaEcvQjVWMlhFRjNubWRKeVJJSmFaQnFOZytLSkdiQlV5KzFvOG1tYi82?=
 =?utf-8?B?ZE5tS1lvUGNBbjdmWG9mb2p5MlR2NXR3dmV3b3F2UEhsMDBVUU5PYmhjZnk4?=
 =?utf-8?B?NEQvSjJacFoyVGFkVGp3MDJlR1BTOFVTNjBRWlFqbm9IUDZSWkR1T3l3c3pG?=
 =?utf-8?B?Z0l2RjEyeXhWNGpRclgwYmxDdW9US3NEWUY5VERYVmd6WHBmWC9hZXJTc0Mz?=
 =?utf-8?B?MVYySHNsbkFZcEpIc05abGRRaW5DQU4zZ3FjR1FzQzJEbW03S0IvQmlYYU5S?=
 =?utf-8?B?UU9HallxNWJvL2U0dS9xTko1WXorVUZQeDlHNUkwdy9Ic2VhSkF0REovVDBh?=
 =?utf-8?B?dy9UNm9BSEFFRmo3WE1XQ3B2SUtYRG5zdzc0QVhFbCsxekhSQlR1UFQ5aHpG?=
 =?utf-8?B?ck1jK090WS9McjFjSlhjb1cxb3ZIRkR2YUc5REVObWY0ZkNZRkJER1ZJaFNY?=
 =?utf-8?B?Wm1aZ3Y2WXZhRHBxRFdoS1pJSjBVRmc4R09sc1hnR0xkQjNsMTZtM1p1N0h1?=
 =?utf-8?B?NWVjbWZpYytrU2ROSVRxOWNXNUxyZ25FcHduSFRuWHFZMEtHc3NtVTZWTGFY?=
 =?utf-8?B?UmFsbE14RTRwZ1dPZ2hxclpVQkV2Sm5RRGtXN0RKN2dHTnA5c2YrdEdvUTRZ?=
 =?utf-8?B?MEJVdGJaLzVCR1J2RG1PVmR1QjNpeFg4enQxa2p3WUlXc0FhQjVveFJSQTJ5?=
 =?utf-8?B?NDZsWDZwSHp4c2wzVStsNUVXUWREbUQ4K1JhMjArZllDMFFrL212UVgvbW8r?=
 =?utf-8?B?aHNwQ0lGaVBqbVJXbGRyM2F4Z3czS0NUcmd3QWgzcThKaUFsWXl1dnBuTlRt?=
 =?utf-8?B?OVJvcmpQWk05QnFGNitRcUc2dm1LckN2Q200NmFxa0daam5ISkhBRnlaQXV0?=
 =?utf-8?B?VEdZNy81dWdDWVo0am9tenlLVlQxRko2U3FCNkdrZGJOWHl1SzBGcm1Pc3hq?=
 =?utf-8?B?ZmwreFhKYVp0cGh2RUtQY0t1S0lZK3VQRWRZd3prZC80c3IyQzRXRkFQZGZW?=
 =?utf-8?B?aEJWTmg3ZDdBYUErUkNMRWJWSWhPbDNWZ05QM3JWbXVSVXZDSHliTUhidEhI?=
 =?utf-8?B?T0dqcDZZK3ZENng3Y0FnVjFzNXBrOURlUzVpQVpEL3FnM2Z5dU8weURXZnpG?=
 =?utf-8?B?OHBOVFVlYWk2ekQ0NFUzdG1kWEZCb0NyRy9aYnlGQ25HUXl0TTkyWElMZVBT?=
 =?utf-8?B?K2NWVGxzbkJ1ZHQ3eFVBZlVmTmdQd2hnZjcwWW9zdlExN3poQlB0MFBlR0dT?=
 =?utf-8?B?OVlnTFM5LzFQQzB5dlpaSFVhQkxJcDJSeERaMy9MaENwbFJFWlhOTTZBNmVE?=
 =?utf-8?B?NUxhSU16SWIyMWY2eWhrQWZQSDZtVGdoVE1iL1Nab2FxZUF4TDZpa2tSSytR?=
 =?utf-8?B?dmVvNy9URE03ay9HU3V6WER1UGdIdzNocEJaUUxHOWVHWkRzY3hPbmt1OTlK?=
 =?utf-8?B?OFpqVWZaR1ZjR0VQQTUzdnNmSDVIUnB3Q2FsOHdTdXRtclBFU3dZZk0vdGkw?=
 =?utf-8?B?MFpYbVpsZmc1K01nYjdNQzB3RnNlYUM2dlR4a0M0NDluU0hrZml3WTJ3UHBL?=
 =?utf-8?B?dGkxUktvbTJLaXZYRnFDd2xuVGtJRWo5MnFSUXo1M3VHdXV2TFFNVWNkV2Qr?=
 =?utf-8?B?UkdEbVliUWtPdE53TGdZZWxzeVo0YjEwbXRTbnNOMkxRSVVZUDVCTTYzK2JY?=
 =?utf-8?B?MXZYM09HREl6dElJYUZIc2lmUHNtaGJxTHBzdlBXdWxNUDNCNkd5NWZNYnZE?=
 =?utf-8?B?d2dZSTVTajJoQ2Iwb20va3ZTQ09ZWVRhUFdRMUc3YWRCeDhhbGtsT3FRdFJE?=
 =?utf-8?B?V2V0T1RkKzNIdUdUVHRnOHJ5Ukg2azF3WFNOYzdGRG0xbmZnRy8vcHA0ZGpV?=
 =?utf-8?B?ZGZHelhYS3J3V2dteW5TQ01lZEEzMUlyei9iaHA0S3FSTlR4RnNJMEZXTDRE?=
 =?utf-8?B?MDhFOWRTd0NJeVBHRzl4b1JXZ0JQMkQ0QzMxVjF5RUJTdjJpSjkvOUVzMnRM?=
 =?utf-8?B?V1ZEaGpRZ1NoTGNGYWtpZzZaNG10bWF6emtjaVJEZkI3V3AxcE1iRit4NHpW?=
 =?utf-8?B?L2wrUXhteDNtdkRRYVp0THFzRXFqSlZxVlpQU3hSRnNRRUFTenRkZFIxOUpu?=
 =?utf-8?B?U0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 819c9142-8df8-43d0-b590-08daa51828ec
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 08:20:41.2164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fOF6P8DgZ5ajdUuNKYTcBmBezHyywMSA21ZLPnzsbXoNPM7HUj3OvnEVmjtld1BBnzlJ7TTNFdD+K7d/aaDV3Z8rin332kJ6hpLgfVLnvHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4932
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 01, 2022 at 07:34:22PM -0300, Maíra Canal wrote:
> The drm_test_dp_mst_sideband_msg_req_decode repeats the same test
> structure with different parameters. This could be better represented
> by parameterized tests, provided by KUnit.
> 
> In addition to the parameterization of the tests, the test case for the
> client ID was changed: instead of using get_random_bytes to generate
> the client ID, the client ID is now hardcoded in the test case. This
> doesn't affect the assertively of the tests, as this test case only compare
> the data going in with the data going out and it doesn't transform the data
> itself in any way.
> 
> So, convert drm_test_dp_mst_sideband_msg_req_decode into parameterized
> tests and make the tests' allocations and prints completely managed by KUnit.
> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>

Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

Thanks!
-Michał

> ---
> v1 -> v2: https://lore.kernel.org/dri-devel/20220925222719.345424-1-mcanal@igalia.com/T/#m056610a23a63109484afeafefb5846178c4d36b2
> - Mention on the commit message the change on the test case for the client ID (Michał Winiarski).
> 
> v2 -> v3: https://lore.kernel.org/dri-devel/20220927221206.55930-1-mcanal@igalia.com/T/#m2dc961da2d4921566cd0f9a8ed9d2d33a1cf4416
> - Mention on the commit message that the "random" usage is not incompatible with parameterized tests (Michał Winiarski).
> ---
>  .../gpu/drm/tests/drm_dp_mst_helper_test.c    | 370 ++++++++++++------
>  1 file changed, 243 insertions(+), 127 deletions(-)