Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
References: <20220929185207.2183473-1-daniel.machon@microchip.com>
 <20220929185207.2183473-5-daniel.machon@microchip.com>
 <87zgegu9kq.fsf@nvidia.com> <YzqJEESxhwkcayjs@DEN-LT-70577>
User-agent: mu4e 1.6.6; emacs 28.1
From:   Petr Machata <petrm@nvidia.com>
To:     <Daniel.Machon@microchip.com>
CC:     <petrm@nvidia.com>, <netdev@vger.kernel.org>,
        <davem@davemloft.net>, <maxime.chevallier@bootlin.com>,
        <thomas.petazzoni@bootlin.com>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for
 apptrust
Date:   Mon, 3 Oct 2022 10:01:24 +0200
In-Reply-To: <YzqJEESxhwkcayjs@DEN-LT-70577>
Message-ID: <87lepxxrig.fsf@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 08:04:27.1347
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cbe28790-047f-4dc5-1f49-08daa515e481
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT084.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7123
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


<Daniel.Machon@microchip.com> writes:

>> > Make use of set/getapptrust() to implement per-selector trust and trust
>> > order.
>> >
>> > Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
>> > ---
>> >  .../ethernet/microchip/sparx5/sparx5_dcb.c    | 116 ++++++++++++++++++
>> >  .../ethernet/microchip/sparx5/sparx5_main.h   |   3 +
>> >  .../ethernet/microchip/sparx5/sparx5_port.c   |   4 +-
>> >  .../ethernet/microchip/sparx5/sparx5_port.h   |   2 +
>> >  .../ethernet/microchip/sparx5/sparx5_qos.c    |   4 +
>> >  5 files changed, 127 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> > index db17c124dac8..10aeb422b1ae 100644
>> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
>> > @@ -8,6 +8,22 @@
>> >
>> >  #include "sparx5_port.h"
>> >
>> > +static const struct sparx5_dcb_apptrust {
>> > +     u8 selectors[256];
>> > +     int nselectors;
>> > +     char *names;
>> 
>> I think this should be just "name".
>
> I dont think so. This is a str representation of all the selector values.
> "names" makes more sense to me.

But it just points to one name, doesn't it? The name of this apptrust
policy...

BTW, I think it should also be a const char *.

>> > +} *apptrust[SPX5_PORTS];
>> > +
>> > +/* Sparx5 supported apptrust configurations */
>> > +static const struct sparx5_dcb_apptrust apptrust_conf[4] = {
>> > +     /* Empty *must* be first */
>> > +     { { 0                         }, 0, "empty"    },
>> > +     { { IEEE_8021QAZ_APP_SEL_DSCP }, 1, "dscp"     },
>> > +     { { DCB_APP_SEL_PCP           }, 1, "pcp"      },
>> > +     { { IEEE_8021QAZ_APP_SEL_DSCP,
>> > +         DCB_APP_SEL_PCP           }, 2, "dscp pcp" },
>> > +};
>> > +