Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>
CC:     Lee Jones <lee.jones@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        "Z.Q. Hou" <zhiqiang.hou@nxp.com>, Biwen Li <biwen.li@nxp.com>,
        Sean Anderson <sean.anderson@seco.com>
Subject: Re: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Topic: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Index: AQHYopBXddIttVt6zkGyOalTC33MGK201CiAgEgAhQA=
Date:   Mon, 3 Oct 2022 09:45:43 +0000
Message-ID: <20221003094542.tlh6xoee77akuubn@skbuf>
References: <20220728144254.175385-1-vladimir.oltean@nxp.com>
 <20220818141309.ifl3kddmxojqc2jl@skbuf>
In-Reply-To: <20220818141309.ifl3kddmxojqc2jl@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WGDuOzWK52UKV+gFgswKKNUOLSel7/RJ4QH+IPmV3y6jivMnT+IlKeJSIb6Q?=
 =?us-ascii?Q?dnV6+TYaGx0iLIhNZtISz00azXFnM/tFQu7K9EP8uMxFyTIfhZWjU7OVjDWj?=
 =?us-ascii?Q?7vmwmc8piMQfuAy9Swi5cItL3tLIQT71BhQOuda4zCfOCwBtinH5s0ILAGYx?=
 =?us-ascii?Q?ITmKlNDYIHlEslTRLw/9tDL6ReMKUq/doBpe5w1xZvhKKyALWmwQHD50zslX?=
 =?us-ascii?Q?BwyAJodhWEEFYXh3VeD2kp40b2BlJdGvhPsuFgV0SWLP6Ig9xf/oRRNuolUg?=
 =?us-ascii?Q?bc2apJWQQGjYuzNyNV0L1FpkwGFSkvd6Nd5wa+Ed3cWfkQxIyvaKJ/irWJ+v?=
 =?us-ascii?Q?syjBbBCF/c0BeT7tNxWVAvQxayzYUmmE4Yu1JfPQz9ibF9atAQ7Z3+0igNGy?=
 =?us-ascii?Q?MiFIdQZUJOZVwO6bQsRKQDFPFz/faKJ8xxg95FfMYnwTL+6ix5/94+ypWXfR?=
 =?us-ascii?Q?xoytcHhjZcc4XHJZviGQ+2Bt1jBTu9yFQ4PGncf4y4gHkNkKDU2r75IVNl/n?=
 =?us-ascii?Q?d7YC4PY6ER+FxDzcsk+81WmCw2qf1D7ul+lyUh/qgBtVQcQVa1Og4BRDoMv+?=
 =?us-ascii?Q?UBpeDE/7IBxLPAF9iGTlbOCOKSuO6ewtHgAKSgVuF9sU58LsXcBZsKgOa/Ce?=
 =?us-ascii?Q?mRqy8CKrxVsy4qXFANodcb5ssoRnYH1AluoEUv6WGM0DITwDW7sez0GqCzK2?=
 =?us-ascii?Q?yZeC3SzG0E9I0UTVT5FQKLPhEHqF8iIggBdGA5CFgV1+iOnVmnvqnGPzJJ7i?=
 =?us-ascii?Q?9IJ9RWht6BCWqhiXp0JQ/rNti2yIBG04tgZedDZ1k4SjJAKT/DBF/Vfng0uM?=
 =?us-ascii?Q?I6o6jyxbJLWD1LSZQmx0rtK1HQqOEgqo7iBqsOmMbQsLGWXlvdABSxLdZVvX?=
 =?us-ascii?Q?5AHgswnymWSqY+QY4JHBrowA9dFGCi76yvipDbuhUdjQaxHLhrMra+NFR7LJ?=
 =?us-ascii?Q?1QQJBTzq3W12uMb0cbTkW2WNFy0xlEbD3sF1UyLpYHac1f09DOxEgJjCS9Cq?=
 =?us-ascii?Q?zWwd2wJiNaglSM5luzOF6z4Lkd7kOpLuJGyG9mcbLWuylv23uxiev0pQ1Dzz?=
 =?us-ascii?Q?HpUueVI8zm+MuseW4Xuxn7vfyp83d9VhjGEN5WrL2LJK3wpe9CH6gz3Jq32+?=
 =?us-ascii?Q?S07805oAxHn57I4IRdB0RnOnZRjl4eZLbG2v4rNIPR/EHV29EyC7AzWpGQPW?=
 =?us-ascii?Q?vpZl/eeFKuVjzKL9Kvcnwxpsr+wF2B9TwGk8l18VMG4YZcrdxu+S25WwKOce?=
 =?us-ascii?Q?dvQsLI6pxmORKjbR7q5qwkbYr0hdDq/JsrfLvIdgYZ7jK3tXfGCDPXTqNqcF?=
 =?us-ascii?Q?UYHHono+vBY+j/1/UP3P6lpFqhVRHF/T0uGqd4Kdl7lzBHb3aaLWGBD+IMvf?=
 =?us-ascii?Q?i29ws0PsMHYobV9HePsgHasHc+ESLVZmRk/Nq4LN6BspH1Vhw/eINiWZYOLx?=
 =?us-ascii?Q?gQZryoef0t0EOwv6HLZGblH7Mq1CHIm8yMuKQw+WnhOgYswnxqbkW0gp5233?=
 =?us-ascii?Q?ywJDSKR4GRDv+n9/XutQRhZzSfD115t29MDSlN2xJd5ewTBRUKd7fR47wamz?=
 =?us-ascii?Q?P5jKdjpAUoKcgI0vRO9s/y9XbcbrBEwtgZNCLcdtHyxoIAL2S7DosWPpUNoC?=
 =?us-ascii?Q?Bw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CAB27A2CCDE9914B87BCD935FDAF8BB4@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30e0bd5e-8eb4-4bf2-8d2d-08daa5240a6a
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 09:45:43.8038
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tWWh2Pm7nSFwtTxrIQIknU3YOM8SlAGLZ17k/KyjxTd3oplpQkR04prcQ9Uqiw6r86OyHrutSYJsnbqcrQlhIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6773
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc, Arnd,

On Thu, Aug 18, 2022 at 05:13:09PM +0300, Vladimir Oltean wrote:
> Hi,
>=20
> On Thu, Jul 28, 2022 at 05:42:54PM +0300, Vladimir Oltean wrote:
> > The irqchip->irq_set_type method is called by __irq_set_trigger() under
> > the desc->lock raw spinlock.
> >=20
> > The ls-extirq implementation, ls_extirq_irq_set_type(), uses an MMIO
> > regmap created by of_syscon_register(), which uses plain spinlocks
> > (the kind that are sleepable on RT).
> >=20
> > Therefore, this is an invalid locking scheme for which we get a kernel
> > splat stating just that ("[ BUG: Invalid wait context ]"), because the
> > context in which the plain spinlock may sleep is atomic due to the raw
> > spinlock. We need to go raw spinlocks all the way.
> >=20
> > Make this driver ioremap its INTPCR register on its own, and stop
> > relying on syscon to provide a regmap. Since the regmap we got from
> > syscon belonged to the parent and the newly ioremapped region belongs
> > just to us, the offset to the INTPCR register is now 0, because of the
> > address translation that takes place through the device tree.
> >=20
> > One complication, due to the fact that this driver uses IRQCHIP_DECLARE
> > rather than traditional platform devices with probe and remove methods,
> > is that we cannot use devres, so we need to implement a full-blown
> > cleanup procedure on the error path.
> >=20
> > Fixes: 0dcd9f872769 ("irqchip: Add support for Layerscape external inte=
rrupt lines")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
>=20
> Just checking in on this patch to make sure it hasn't been forgotten.

Is there something else I need to do such that this patch gets accepted?

Thanks,
Vladimir=