Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Daniel.Machon@microchip.com>
To:     <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, <davem@davemloft.net>,
        <maxime.chevallier@bootlin.com>, <thomas.petazzoni@bootlin.com>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <Lars.Povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <UNGLinuxDriver@microchip.com>, <joe@perches.com>,
        <linux@armlinux.org.uk>, <Horatiu.Vultur@microchip.com>,
        <Julia.Lawall@inria.fr>, <vladimir.oltean@nxp.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app
 object
Thread-Topic: [PATCH net-next v2 1/6] net: dcb: add new pcp selector to app
 object
Thread-Index: AQHY1DNRRCKA3W+lZk2MiTdViI2XRa335cAAgARc1ICAABepAIAAFpsA
Date:   Mon, 3 Oct 2022 09:33:41 +0000
Message-ID: <YzquziZD+T145jo0@DEN-LT-70577>
References: <20220929185207.2183473-1-daniel.machon@microchip.com>
 <20220929185207.2183473-2-daniel.machon@microchip.com>
 <87leq1uiyc.fsf@nvidia.com> <YzqH/zuzvh35PVvF@DEN-LT-70577>
 <87czb9xpsi.fsf@nvidia.com>
In-Reply-To: <87czb9xpsi.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ht9j2MPYFBWcIMBtm3mwsF7zs4RnyWF07D9DxwT/fufjjk+RxS1is8+n0KTa?=
 =?us-ascii?Q?L59mxvSfDtri0tCgh5LvA9HDIvsKA7tic6mU+zsCN6c1WMc6EWujMrY1eSKN?=
 =?us-ascii?Q?E/OJN4yTbqeTAsAvV9kIGel2XwEXGIVBVfeNfgVal29GmFUbPSGy3LBLs3e8?=
 =?us-ascii?Q?4V2c9pbjJ6hYnA44Dv1f4NvxkjcroVZXFqQPbHrj/8n/Df0ZKxKEPXIX6s63?=
 =?us-ascii?Q?8Chzu23akCqlu3M5/D0fpgT8HbI6DfwN6UUG/P29mQ5Dse4RLWsL50eZi06L?=
 =?us-ascii?Q?p1EzYie15EeXGgoQsrOY34GHV75zYT960Imqd5SbDaOGGZtblXqJZ1/7c6Pw?=
 =?us-ascii?Q?M4fjyQn0USlw7GUeEqKsI/K1WNpbUm2F1a1FAPSWpgcJme16260fTkKoAj6P?=
 =?us-ascii?Q?7K8W9Q6wEkREkkS5XF0Q/ig2xftD9L6k3iHnklsu/ucb56DIDjYJ0S+jw+zs?=
 =?us-ascii?Q?t28TdLCaacaIiAcrJIK1fbSsjKzUQh8+MRhDp1CaTX4RBieYR6+l3zVS7HVs?=
 =?us-ascii?Q?nnq7bNMvRDTj7AwgGIG9NzdFAPVWsI3KugubJqTPpoFszZiXALovDj6tVgf2?=
 =?us-ascii?Q?vNx4MpCKbydAm/IwFwzQx6H9Tve3e6Fd73Zh4L6DtapiRVppCrKoRvdyXNo+?=
 =?us-ascii?Q?HFfO/wtJp7vlxfzso987f4OdraQvgmJjmlVXRxsGHdC+fuoz4DB/hF1KFKn6?=
 =?us-ascii?Q?WJ0CV8UHzHOqw/t+LHpd9+xeci1iP7AiU0LnpSSAPTr0qlt1azQnpvCv165+?=
 =?us-ascii?Q?nNdEm/bhi7xcbr8lmOasqjPn9gWDW6wYpM7CC8IBL+Fer0SDu4c2eCqny1zs?=
 =?us-ascii?Q?RezBZEkQDU177ZEtMolAT4kkJ0COLhsKTKMqvujDOQsNFX1FJDSzJLXY2c+f?=
 =?us-ascii?Q?e0z1UUkX5UtwqzePHqkInC3H7uHIzB7CRt6QdFXPpveTd2jZHscP8WQ7Iz2k?=
 =?us-ascii?Q?e6d6m6AtX8epKhNQtoiwo7JBHsRGdG6NnRnjC7fI0cJ0xSUy4BAzSP29ou5b?=
 =?us-ascii?Q?SBUmWEsGajIawyI9t98tME6AumKsduRe92KGLLSqyaNYtPmG3plUfZXdCC14?=
 =?us-ascii?Q?DA2Mqag0xAZLe+vvu2IlgJ0+y6Txt6m/0R6zBixDChF62k7JxS8V4FVuB8EK?=
 =?us-ascii?Q?zwKMR/FQynZ01SB+PBgBqHkNyamhgl9wWvu7m9noxLJTczJjHlGIKppaVZ5s?=
 =?us-ascii?Q?xllKwkbpaL3TEQliPbGGXAwNBbmmPZwfTC7n0SO7IHnDOYt/0h8mWTjuhZoB?=
 =?us-ascii?Q?jNCiDOKm3yYnw9duU/o9mV9nVITt5wxkOihWy0aAIt2398/Vnqg81wv633/3?=
 =?us-ascii?Q?9tUDl2GeeUI5dcLQ55SvpCYn4kJGUY+IVb7lPSSHoErRineu6RfIwJJ2RcqZ?=
 =?us-ascii?Q?bfP3IzwTdzbHnenFHYi2/DCWUR2YB4mocfqICyvZmNMgW+CAuI8/oQiVNg/+?=
 =?us-ascii?Q?dsUpwU3srM4DPCYHmGMvpqmGXHuEgg+2ExZF4RakbyCkLHiu1k7h2O5S3s+d?=
 =?us-ascii?Q?jXa5B+T9SQPUzO3iqVgGJHZ5mc67LqIfuU6naLonwl55IAZ4TZx6WG3e32ou?=
 =?us-ascii?Q?ctR9bmLHd3BvHzvgxJz5N2Q+W/QyagxIXGpmkSb5DFnndvqGySXcFSR0W8rJ?=
 =?us-ascii?Q?u+O+wfaDSl7hwAMHXv7PaLc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FBA6F8A70B557043B45BD38B9C893BF5@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5580.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 929a3a86-d031-4ec2-7521-08daa5225bc0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 09:33:41.3000
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LSArfjyfkncSFNAZMMsB0XTTDEPOzM1remYOGq/tCw4gR2mPAUbTy4UYI9PQp0OcK+/qv5qBJgnpqZQmtbh3cehpHVm8IRKr7wJweHVAiOA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6889
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Den Mon, Oct 03, 2022 at 10:22:48AM +0200 skrev Petr Machata:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e content is safe
>=20
> <Daniel.Machon@microchip.com> writes:
>=20
> > Right, I see your point. But. First thought; this starts to look a litt=
le
> > hackish.
>=20
> So it is. That's what poking backward compatible holes in an existing
> API gets you. Look at modern C++ syntax for an extreme example :)
>=20
> But read Jakub's email. It looks like we don't actually need to worry
> about this.
>=20
> > Looking through the 802.1Q-2018 std again, sel bits 0, 6 and 7 are
> > reserved (implicit for future standard implementation?). Do we know of
> > any cases, where a new standard version would introduce new values beyo=
nd
> > what was reserved in the first place for future use? I dont know myself=
.
> >
> > I am just trying to raise a question of whether using the std APP attr
> > with a new high (255) selector, really could be preferred over this new
> > non-std APP attr with new packed payload.
>=20
> Yeah. We'll need to patch lldpad anyway. We can basically choose which
> way we patch it. And BTW, using the too-short attribute payload of
> course breaks it _as well_, because they don't do any payload size
> validation.

Right, unless we reconstruct std app entry payload from the "too-short"
attribute payload, before adding it the the app list or passing it to the=20
driver.

Anyway. Considering Jakub's mail. I think this patch version with a non-std
attribute to do non-std app table contributions separates non-std from std
stuff nicely and is preffered over just adding the new selector. So if we c=
an=20
agree on this, I will prepare a new v. with the other changes suggested.

Wrt. lldpad we can then patch it to react on attrs or selectors > 7.=