Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2760124rwb; Mon, 3 Oct 2022 05:19:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM63Tp5xkIVRPJRxu3DhMEojuhgNEWwXVyrIhaOl9tADszzaneOeUr8qBSrYGcLp2TY+mEk+ X-Received: by 2002:a17:902:8215:b0:178:6946:a282 with SMTP id x21-20020a170902821500b001786946a282mr22041870pln.162.1664799597882; Mon, 03 Oct 2022 05:19:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664799597; cv=none; d=google.com; s=arc-20160816; b=nu5oxSNJSg8m9sdiTbyPLwQxbFJFX/Ozt++m7+m4yvy42bqvl8KCX/uL7jbSKy9n+u 9uxDHw/gq4gGSojNcj8KZLC6fAkcgLLYaSds2e/NZEjQAnrFCgusWOGNiAzqx55dqe5u tjPAzRGLASUl3VQYdv0vtqCIhT93LGvWjdmQ9IIBth3kpcrA4OZeylW4sja5vrjgHDnU vf/Au2Y9SHbHtLHOtRMhJlEgrPA+Pv+X7jyhDWda9P7ALu3nVoxUWrog9wQbAiprfLA7 27NhCIheZXCLaUd7IZ+JO2gqcTk36kG9OE0HEctxDbdW+rVsbr6rrpYBDk+VFTG9GuQt qRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=xXuUHdqe1zy4qmzfT9fy0vYFOm3cax0mv3koY5tclaM=; b=fOeN78JtxRzcX1JogBDqkTEhdD4jF0Z4aJTbVNnktu9DhH58haCnz+svSMZ1UM6btG QnFUcgplkYjMxc2NBCa4MkBrYtM/2j+tMxqgkprmcAhfiYsgzVKJ01zOM6Mkfdm9LdOa VhlC/dsjbEd/xi0lIKuuW3korA3s6d9odwgh+VT5F9cAru72UNXaiDFYm3fFE7PMCKdu fhdyXQiHyd6TqLgkj+tQW4kWFsnkhFHz4r3/UStGyFR4u7G9Mi9LiqzTaMFHgvBuxP9+ JOuTHSxR8kIXH4VizP3QzpjFuy0WI4JjIpqsIkxbiUGoBedQ+i3GaZRkU/BkuIAYOVUJ Qu1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j0gXbmZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020a170902cf0300b0017d2311af5dsi7388947plg.69.2022.10.03.05.19.45; Mon, 03 Oct 2022 05:19:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=j0gXbmZO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbiJCLu2 (ORCPT + 99 others); Mon, 3 Oct 2022 07:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbiJCLuT (ORCPT ); Mon, 3 Oct 2022 07:50:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C293057C; Mon, 3 Oct 2022 04:50:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5038BB81092; Mon, 3 Oct 2022 11:50:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 0B894C43470; Mon, 3 Oct 2022 11:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664797815; bh=vVimnp4wVXRu2RYMM8Bka2hvV81/4nCHp6+HBBhBgLM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=j0gXbmZOcqXbIU7h3x1NeJeBYgxZ0GHHufhCjmh9DZ1bwhqWJI5+Sb1Ru48O/gBIY Z0eDjFrdDnHAvRN3GBuAGMieErcDdP/tyb+FODrVtNlyQa3ckebIMKxchMc9Lg9Joz iHrHFGSAA/g3jTQ+nILE/ttgbU4Mt7TpKYmveELVCTukfkBMW+Gu8ByML4nh//rhff sfNFUS7LkI6pRpH+lRqcOp5Bpni+KL9sr9L/a0FVKLvKINOgAackwLcHLpVC0mWIoE eGNLCUDbYA/F0y/r3r8d9RVeZW1qdavs9mC1l365pCVdUXuU34VjCaqgRVdqmEbF54 ftNIob+zukrWA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E16B9E52505; Mon, 3 Oct 2022 11:50:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] bnx2x: fix potential memory leak in bnx2x_tpa_stop() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166479781491.26331.11983869215638641295.git-patchwork-notify@kernel.org> Date: Mon, 03 Oct 2022 11:50:14 +0000 References: <20220930062843.5654-1-niejianglei2021@163.com> In-Reply-To: <20220930062843.5654-1-niejianglei2021@163.com> To: Jianglei Nie Cc: aelior@marvell.com, skalluru@marvell.com, manishc@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 30 Sep 2022 14:28:43 +0800 you wrote: > bnx2x_tpa_stop() allocates a memory chunk from new_data with > bnx2x_frag_alloc(). The new_data should be freed when gets some error. > But when "pad + len > fp->rx_buf_size" is true, bnx2x_tpa_stop() returns > without releasing the new_data, which will lead to a memory leak. > > We should free the new_data with bnx2x_frag_free() when "pad + len > > fp->rx_buf_size" is true. > > [...] Here is the summary with links: - bnx2x: fix potential memory leak in bnx2x_tpa_stop() https://git.kernel.org/netdev/net/c/b43f9acbb894 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html