Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2802374rwb; Mon, 3 Oct 2022 05:56:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6iKZx/hg9llC0cUacQTvyzpUBMplkjD4nEX+k3SzkRgMcDz2qy2ePk5NSg8WnUcRA/fqGh X-Received: by 2002:a05:6402:11cc:b0:458:f610:8404 with SMTP id j12-20020a05640211cc00b00458f6108404mr4710787edw.75.1664801801165; Mon, 03 Oct 2022 05:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664801801; cv=none; d=google.com; s=arc-20160816; b=e/UGh1efkL+7oCLKdBU0imAEXvzlJDSQroIoXx+v7FJ053KAfHjwrtASEbbDFc9hu6 JTMosMB7cdtHEriNR/6r7NLKilSNqDU97XTXJ61Xc9XFxJ2PApdZNg2TPrvhC7VKkV/m FYveMHDDoC74hVZSzl16INjvdUx8raB2v+VkCUxDURLfvGg7cCj0cB0FBzqFusvUDcFn txF/YJasw8LLCWQ0ZIATyfH8xf27sqA+s0Hcc75clTQTp0typCIwE7kfFG3LU10ad3ou OAg3KppGXH+qrobxZ9ukXqreZ7WxHvexjdIzjxzLCN9yJHuGEXfanSHxyA/MshiLpb2Z hWbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=u5qE1Yzg4uUDLp5cSlrxrUwdpRevNlLzCrYAaWk6cjI=; b=lecr2GxTchDsgsXz8WGz8mOnqvJUDT4846lF15KrYffBz2gvq+laei7+SQqOtDMhVc UtNlPWNYAE4b9UHGYx+ojLoA0xLV2oVRCBKIYOOmexWZfHfog2VZyUt6MzJm6vcY5/js orTb/3w1G3uj377dcM2XbseAcXADjNW66wObDBce95EF37PEwncEECit+slRqB+4KPIF scHigmYgScRkwhi+mqmsGN8o0dQACcmNjwBDT49JUS23EjkSYnb5VNQPbG12T5MyzICk M7C0P+bKa6gQ4BZg7LFFBICYu7fJUy2l+VxJmlXKo8flQJyiNF3cVr5d6FIvY27pUSQk A89g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=km4rRLgJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy1-20020a170906fe0100b0073155abc1b8si7790682ejb.154.2022.10.03.05.56.13; Mon, 03 Oct 2022 05:56:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=km4rRLgJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbiJCMh2 (ORCPT + 99 others); Mon, 3 Oct 2022 08:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiJCMh0 (ORCPT ); Mon, 3 Oct 2022 08:37:26 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 615602AC49; Mon, 3 Oct 2022 05:37:25 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E08D16602266; Mon, 3 Oct 2022 13:37:22 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664800643; bh=mUEUSYdWSHm5PqjemMFwDRgFrWK0rEzlRVBCVzPa5AY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=km4rRLgJ9osYdiqu021ka1hijqBvRELrqXVrNphErcGXJf2zBbfRY1f2tkmMWfyHc gUxymPh4hVGr5UR8DTCr42sYLeY/C0He98FoPef3luP+fCeQ2sJ1usZPwGS2rv6MWo +x1Q5FHRq34wpebYpk7+qH6tYRxDNwq6kun/odnwIk5ag/VTcoKtsiZAjPus77efAh 5sf+n5TXzBZz5d5kNcm6ElR3A1JzUd4z9GpceJG7c73H5AChPcAJYmiWkjYMBaXw91 bF0DmZI35LPfBAa4poewYnQ6pF2xNpxqzS2HwOsLqucWU1+h0l23eGbevqOUHaw2Q3 vqREkgRZPNbIg== Message-ID: Date: Mon, 3 Oct 2022 14:37:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 2/2] media: platform: mtk-mdp3: fix error handling about components clock_on Content-Language: en-US To: Moudy Ho , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil Cc: Chun-Kuang Hu , linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20221003070830.23697-1-moudy.ho@mediatek.com> <20221003070830.23697-3-moudy.ho@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221003070830.23697-3-moudy.ho@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 03/10/22 09:08, Moudy Ho ha scritto: > Add goto statement in mdp_comp_clock_on() to avoid error code not being > propagated or returning positive values. > This change also performs a well-timed clock_off when an error occurs, and > reduces unnecessary error logging in mdp_cmdq_send(). > > Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver") > Signed-off-by: Moudy Ho Reviewed-by: AngeloGioacchino Del Regno