Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2871738rwb; Mon, 3 Oct 2022 06:46:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6imXiaqeBL+/YMBMvVYVWVGO9Z+afEjGpbiS5O5JNJTUz4d+z9sLodH4tjGvGBBWI50lnX X-Received: by 2002:a05:6402:1e8d:b0:441:58db:b6a2 with SMTP id f13-20020a0564021e8d00b0044158dbb6a2mr18213400edf.277.1664804760049; Mon, 03 Oct 2022 06:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664804760; cv=none; d=google.com; s=arc-20160816; b=LHYJ7Vm+ikME4eyoNsxulPYekbx92bMbu+Aas+55gt+M9MFb6Ct3I1EfyoYb8opD40 Dd1norffJbedqRoZBk9ch6KVrCICdzQPBqz5ArCnW9LgFnzOGV79keAAd9sOtIwddUrY wrVTKMwnajMnGXD4A3lP/TFs4sd1dN4gFUcXsVu57uNz2pVTfFglgMy5Xpil5uBLAISz QWUAOtQADnOO3X825h4+gMtlVpKGqIVyNRCwgkx+mCgxYiKD4/gbnkaiBHv+EoGTKB7F cK969RzEpKWG1c3coVGr1B3cnVZZLd9v6KEsmAQ9QPiY6jht7SmLi/GKzpjlcOW4Shi4 Q4dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=eWlt+DkLoPtLTcMntu/Est1VYDCDRL0KLk/6rYDuqBk=; b=yBHMKfdho+adF9MC3fLy0X3n3vGWa5pMQD5V3XH/a7AsVRD4Set6JVs4whLMP931/g KJ9s8yc1pHmdPlEjpW/9oKCNt635X50SuHP0y/xuhIdYU/ImXW93yQawNhIauVSPr/3V W4IM4rLzEiJJ/AwnR24T7QDO6IhHCqaplRoYVsN7z6dYC1hDtf04v657aPGroBFTThJN X4w5PuwcLNCTRbOW5e/VYTIY2UcScUgV5Ky97T1eDUjYrBAZM9xv0UMLvZHINnjq4FUJ oN3OwPAYpEFu/s+xbax0LDb60TvX8QDiGQk/0ExP5/Dz5Ni6VH+cXqTgXbPHPTniBW0A uKhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bIhzD5rd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go12-20020a1709070d8c00b0078043d1e9fbsi8560882ejc.354.2022.10.03.06.45.33; Mon, 03 Oct 2022 06:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bIhzD5rd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbiJCNbS (ORCPT + 99 others); Mon, 3 Oct 2022 09:31:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbiJCNbQ (ORCPT ); Mon, 3 Oct 2022 09:31:16 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07E82EF2F for ; Mon, 3 Oct 2022 06:31:14 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id k3-20020a05600c1c8300b003b4fa1a85f8so5850322wms.3 for ; Mon, 03 Oct 2022 06:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=eWlt+DkLoPtLTcMntu/Est1VYDCDRL0KLk/6rYDuqBk=; b=bIhzD5rd35NW3dhNR/3KSyDQPcg0xBDSFAEfNDCnp00rL+oyEbu+wYpdqqmjl8DGKc 1ISoib/HmH5JT7X5F0Xa0J2XMhXTSiboJZCyS1lp1yZlHO2FeEttsVYDirFiNWT8heLl ycHF2pcADOXR35uFV1bUzVqgcSY9xbSjRmnHizoZ8S7EpOqCWRJ2l3FXvBogJBNmZRNV vHA7PlUw7vLmgXgzn9eeA5VAw6eA87gHpd3ZTwtXZQZI+DQLF5G1HRcudYrwtZAVa++U Lva4G5Ys6T8ek0fuYrNLMVQFTPNdu/GGeEl28dj9ESS4/OB/aL4H0rK0pjgGO43+VmKy Pjxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=eWlt+DkLoPtLTcMntu/Est1VYDCDRL0KLk/6rYDuqBk=; b=5d4gv/PS2dMHq7lGI7KpLj+g3grAoO9i7dps4l9HVl9ucsOpdd8QJCijVAUC60wBKN kSvgspRZ21isbKuv3UkzZ61bOnX7wJj0IwM7KIvYvmuZgp3ljG4ig7jJKvguP/FSy07+ ujbI4NWmjH8uZ+15oGxV1sho+WHmSLF5HEll1aGn4moZWZlzedP0RYjBQe+CxO6zq99/ SigdnLL3ElCBBYuti1od6tuj8J8vKIKA9yksxCDInHYxM8wLk6ekT1pfGvge6+b+bWcR va//N1GGHVdqvu/h4R820Bdl5kWe7frmoVUko9pdOqVcgmlsz7wtp4QHLMukdKWhFpCR 99gw== X-Gm-Message-State: ACrzQf1fiBWnKNKnISRKYWTqdYLpHVcyhWXkYnL7dvNjhRvpDAtIQ7If lTWOwKrt++rQJX9D9FjDyc3riA== X-Received: by 2002:a05:600c:214e:b0:3b4:709b:b0d with SMTP id v14-20020a05600c214e00b003b4709b0b0dmr7191663wml.4.1664803873458; Mon, 03 Oct 2022 06:31:13 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:f3a:9f5e:1605:a75a? ([2a05:6e02:1041:c10:f3a:9f5e:1605:a75a]) by smtp.googlemail.com with ESMTPSA id n2-20020a05600c3b8200b003a540fef440sm16868737wms.1.2022.10.03.06.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 06:31:12 -0700 (PDT) Message-ID: <96462a60-417d-bf99-1a15-af0cce47aeb6@linaro.org> Date: Mon, 3 Oct 2022 15:31:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Content-Language: en-US To: Marek Szyprowski , rafael@kernel.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org References: <20221003092602.1323944-1-daniel.lezcano@linaro.org> <20221003092602.1323944-20-daniel.lezcano@linaro.org> <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> From: Daniel Lezcano In-Reply-To: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On 03/10/2022 14:50, Marek Szyprowski wrote: > Hi Daniel, > > On 03.10.2022 11:25, Daniel Lezcano wrote: >> The generic version of of_thermal_get_crit_temp() can be used. Let's >> remove this ops which is pointless. >> >> Signed-off-by: Daniel Lezcano > > This patch breaks Exynos thermal driver as it introduces a NULL pointer > dereference in exynos_tmu_initialize(): > Thanks for testing and reporting, I've just sent a fix for that (unfortunately can not be tested from my side) -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog