Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2879671rwb; Mon, 3 Oct 2022 06:52:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM43rQ3nzjz+OhzFgjMvDKJu+MXADpkLLmu35Gddo/OxRYpihnOHs4Bwh1hXxZBgB8Xh5GG7 X-Received: by 2002:a17:902:c411:b0:17f:63a3:cb26 with SMTP id k17-20020a170902c41100b0017f63a3cb26mr2900739plk.23.1664805169833; Mon, 03 Oct 2022 06:52:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664805169; cv=none; d=google.com; s=arc-20160816; b=BC5pmkLLbzdpZx3zy5YZ6vbZwY7li8cQNST4/eWIdyhC2CdB725v5KqGLfov6PfNPd EVO6r1bx3pfZO9OOR3OHLhyENGouGLcy+TWuejtfdD4A5dIVJNLWkIUuvsAwyqJofktb wtCx9buNSAHvIvEMfizctNi6NMZa0JdVJArDDi0++SuMHXw2lpacj9qBNI/e1mHBP75a FZvvY2IiHwYgnLHtAL8DxizGyao/3nVLzVDYS9a4kEoNLRI5XfeSKQcMhrFzw9J2XI6L VSjWcOX0f7eK42brMEddfFM/mx5AZSVpKLDrO/iinuDDH3po+nNch8TH7tTMldPvtfBS bq6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ggu8Cn7z/zwCPwUOnXaMQWi6G7iy2Vg9dkgcI3YeUzI=; b=lGu25ap8fpWIdR2Jr4tqt+UgcybuyfSdpulJ7qbMoXL+drcAwes+yGm+Mufx4CCVki eHpEPFKY2ZfwijvDRVnwkqrY77JaX0zzolBfvlIvhbtqVckbdNJ7ibzBh6M600G7twz9 TjpDfPW0xjgrzz2DtjQCXmnou41PBdYhvKbGfRb7Jt6jaVk63o5/Y2yziPt4+3IFghNx ZkxHEC7am2XpmKCCZC9Wb11N8gIrpt1vxwctaIVBeAiU5+QprUyV1uddCSXMCuiDYtYH GLFYSoDwM744Njxx93+Ewk6WKKv2MbWG5nd+IWYper3vUDa8JIF1T9IQuD66BC++mOJz h3Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=blxP0LKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o20-20020a17090ac71400b0020382775a6fsi8898514pjt.149.2022.10.03.06.52.38; Mon, 03 Oct 2022 06:52:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=blxP0LKU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbiJCNlG (ORCPT + 99 others); Mon, 3 Oct 2022 09:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbiJCNlE (ORCPT ); Mon, 3 Oct 2022 09:41:04 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3F4742AE0 for ; Mon, 3 Oct 2022 06:41:02 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id u26so8015519lfk.8 for ; Mon, 03 Oct 2022 06:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ggu8Cn7z/zwCPwUOnXaMQWi6G7iy2Vg9dkgcI3YeUzI=; b=blxP0LKU/Yr0QMAPggTAcnD9Uyt1RtfvFtMBCpwQo7QwfEj2AEmc1al7DRvqU8xRxI 1/prE7hOQzEbcSpYG3qh/5abjmVbaMr/1Sq2yesVH+iixgVgmC2GxWIjHioHpT845KzW NdXmka3mSvSO4VQGgVmTR708lfqQd8xTe6+rCMLtI6fecHGz7TIZfsWy0iT4o27xN+54 gGqoZuC2PIn5fwXsBbfUcNiNBucgmNiXvVbzeGOadsVrFEhW4uQY+L8icwfTeoll2xKN 2MUSACr9Njb5J8sg0kVHTdsu25NPOCre49cmV02Xh+Ei0b3H/dHvPPLcANyp/fOZMBfJ ka2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ggu8Cn7z/zwCPwUOnXaMQWi6G7iy2Vg9dkgcI3YeUzI=; b=ghjJ+pC/b7QFJ+rz4tkg3RpLKHzhYGJwn1qjyENy3+TUtUZDq7BI4uGv/92Z/INICq Ak9Oh7z3Ep3YgNi3U9WZapXoSwr3KhYcmKx4yuXsAvz4uBQ9ijw62hMiZKeO5D5HKn19 oVjE2tLSyHStXzHOl25qp+WgMntl2bZB0UuSRvAQdEK09r7tOxvos0rWEG+iiV1cDAAq q7gXfdGNYSdtaS1hO3wjRQjW6jY9v4qegOjyxK6zOBjCK2SPiMHwp/NLCzCoIrp0l8XP 6UR5vwgwtEiWLh3HqDY26lRbIhluEeO3SqNscyKqua1hxm4DL+wU9NloUIzpxL7kvRfR KkzQ== X-Gm-Message-State: ACrzQf2PGGASqAI1wVUcgk2Utf1xHrf5Y+fWdJEzufH8WDmxIjHnrOQL 2rm5umRdXAIIahmBluNB3mzjnA== X-Received: by 2002:ac2:58ce:0:b0:4a2:2a6b:939b with SMTP id u14-20020ac258ce000000b004a22a6b939bmr3437214lfo.274.1664804460987; Mon, 03 Oct 2022 06:41:00 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id m14-20020a056512114e00b00494706193adsm1463333lfg.208.2022.10.03.06.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 06:41:00 -0700 (PDT) Message-ID: <905a82ae-c4f6-ea6c-7396-05acfc4fc53e@linaro.org> Date: Mon, 3 Oct 2022 15:40:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Content-Language: en-US To: Daniel Lezcano , rafael@kernel.org, m.szyprowski@samsung.com Cc: Bartlomiej Zolnierkiewicz , Amit Kucheria , Zhang Rui , Alim Akhtar , "open list:SAMSUNG THERMAL DRIVER" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list References: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com> <20221003132943.1383065-1-daniel.lezcano@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221003132943.1383065-1-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2022 15:29, Daniel Lezcano wrote: > The driver is assuming the get_critical temperature exists as it is > inherited by the thermal of ops. But this one has been removed in > favor of the generic one. > > Use the generic thermal_zone_get_crit_temp() function instead > > Fixes: 13bea86623b ("thermal/of: Remove of_thermal_get_crit_temp(") > Reported-by: Marek Szyprowski > Signed-off-by: Daniel Lezcano Looks good. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof