Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2982835rwb; Mon, 3 Oct 2022 08:08:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4qwowhUea09lUOB16bjqBIrizdn57tyeE5TO4lnx1Q7WpoeMNL9u3rDp0IV6fznFo6rec5 X-Received: by 2002:a05:6402:2947:b0:451:32a:2222 with SMTP id ed7-20020a056402294700b00451032a2222mr18703376edb.376.1664809714802; Mon, 03 Oct 2022 08:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664809714; cv=none; d=google.com; s=arc-20160816; b=ZdSYC7K652FPVqr8s4AhRbQM/uqJvRW0oYRmT0bWK/kiy3K+kH0ZvuzfIVcXA1k8Qp v9c8wMczEhS8ScRCx5bxN78xM9UW2d+2IhmZh1PLjiITbLA0USYDrcaNU/xwG/+OwJfz sGI1NcMPPHcLd4AFpUG5LAYuYFW9UZZcR2J2LFssGm+fwZnK4klUphtzWLwU6BcfZc9Y /GIu1ArXSLbdnciu1kjsZVi0YpVaUyId74HkXTt5dyKpsM5aj03RNzLWUADB20krTj99 ra0o+1U1qS20Ld80ITcmA2vpvPOtsC+4ZyWpu49jnxCysLsfTr0t7RdI44x0P/JXrfdD H0fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=BLvlOmvRxpgO+TTH0ILMl7lfs1xgK9QENZ3NYOD5Ank=; b=X+Rpidzb64yLeYdc0/GOkFqYyeYAaGR7jgT0UiTU49p/353uQVtDeD6MHrR/va182V zaZA0CYU69/SpQxTzvg6+1x+csUEyfWFgSqUrBvQjjkA9leg5WxEpzWC80vrhNdsganH VCEVK5l+MZttNwqz7BGrVmv/Geo5yuzWsufENRlKmK6CxJ63daTi1VQ+zhNil8txqWUV B/II0ytZXfRi4juuqBQfwsJmZMrS9tb3PkqRcqVteEgX8kpbg8CEa9zuTSfi/4wNkXmP ucK0Ke6c9RNdoMq8QuDKcXBHlscgWC+uhMradWq1O2ks/+DLoqMXSg0H1W5vWVdShiMJ eAyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bKKmwqDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bx26-20020a0564020b5a00b00458f6e66baesi2766100edb.278.2022.10.03.08.08.04; Mon, 03 Oct 2022 08:08:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bKKmwqDi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbiJCOtX (ORCPT + 99 others); Mon, 3 Oct 2022 10:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiJCOtV (ORCPT ); Mon, 3 Oct 2022 10:49:21 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438812D1CD for ; Mon, 3 Oct 2022 07:49:20 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 412806601B15; Mon, 3 Oct 2022 15:49:18 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664808558; bh=HMJJedZ83ECC+x6hsoS3IT6zUsXmxODD6JoL9d+MOk4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bKKmwqDiGUX8P7pi5iudzEBAHgo6QPgSQSaIRUA8VwQpOxYylMbvKiHLiE6HzVVLQ 59Aa/HOk9w5lsVMA2bNPbAnljVVMn3LkXvDqp0rsMgq31zGaoDEdyN/WEomf+mRbe8 ogitZ/cxP8mimOjgwPiYNamq7gBCX5eYnzIi1C858ejw9268gHs7cjMdPpzkEKq9xj DqrB5q8HLxnwSvpF+VImR8Q2rysNRvGxM926j5m4rkrTCOwos5Htb5vua7WZ9953RE yscljx1g+U4KCT/zWwGqBZnqOSHZovEBSznkA+BNBW+ZgCEX0bBox/Vbt7qhdjS6O+ yGNRGPK72oXyA== Message-ID: <6812059d-fb1f-f594-7f9e-eb62defadd09@collabora.com> Date: Mon, 3 Oct 2022 16:49:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v8, 2/4] mailbox: mtk-cmdq: instead magic number with GCE_CTRL_BY_SW Content-Language: en-US To: Yongqiang Niu , CK Hu , Chun-Kuang Hu Cc: Jassi Brar , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang References: <20220930160638.7588-1-yongqiang.niu@mediatek.com> <20220930160638.7588-3-yongqiang.niu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220930160638.7588-3-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 30/09/22 18:06, Yongqiang Niu ha scritto: > instead magic number with GCE_CTRL_BY_SW > > Signed-off-by: Yongqiang Niu Please fix the commit title and description... an idea: mailbox: mtk-cmdq: Use GCE_CTRL_BY_SW definition instead of number P.S.: I agree with CK, please send this as a separate commit. Regards, Angelo