Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 08:22:09 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumit Garg <sumit.garg@linaro.org>
CC:     Jens Wiklander <jens.wiklander@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        <op-tee@lists.trustedfirmware.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>
Subject: Re: [PATCH 0/4] Remove get_kernel_pages()
Message-ID: <Yzr+IU2IMkvJQqbu@iweiny-mobl>
References: <20221002002326.946620-1-ira.weiny@intel.com>
 <CAFA6WYN+3inY6MYrMFY0qhmifCYtj_immFMFN6jC1BamQCYGWQ@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFA6WYN+3inY6MYrMFY0qhmifCYtj_immFMFN6jC1BamQCYGWQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PMRanG+i6kqOd4UJASa2ht0mOWO/B1S4mUZ3qhRHy9oPiGQcOr7qwXfk6TeE?=
 =?us-ascii?Q?Kh1ZrMKPCUfl7g6ThAIBOenMks2lQMdBVxII8MJTzs5tJJ0D3EsDsMaAS5Yn?=
 =?us-ascii?Q?yf38EqcgGYxoi36dgwXcNH0uiw50Czi9VTW9DznN36k1jetcckDWWwyPMYvM?=
 =?us-ascii?Q?HvuJUXjgjUV9RhURD9v03T1S4qVBMe/9LEdrttp0k05xaZEAAJL45kJn3i70?=
 =?us-ascii?Q?IaFy8k87sPZ2ny6jVFZMczqxl06inEEkragZTSNjz4ShRswfkbumCad1nLN8?=
 =?us-ascii?Q?TG6Sh2THtDvJ6esBcrK3rtC7gSwcsE8S8NjnDGai+iobtGAMW9XV/FAJbEpd?=
 =?us-ascii?Q?m3b+rbY+IMzD5aWimTou+uexlOPcrzX9lH2fWyEODthQReHi4Nfg4I3f4JR/?=
 =?us-ascii?Q?VYZ4POylreBdmnPDSEfM+wg33DZqQPIGlfmPBUmaWoTVapMa35ZUal0DLuGX?=
 =?us-ascii?Q?exXvcSl5+DHCGKaTPzdZnLHPwv/TZSNQZGEmzHD2dpUZbaF4m9O0+3PrT/Iq?=
 =?us-ascii?Q?NrhhxZEMwJ6fhpxfipJIQTvIc6ykmAl5NSPhVtFFTwWU7EKyMddTNLY9+S89?=
 =?us-ascii?Q?yRUy+jD+KduaR98xLjGtRvipPVKtTciFzGe55eyXVNoE+CsAYinaUSca5FsC?=
 =?us-ascii?Q?vhn+/Sq8hhdm+JYgl7qj8DGhxNHfxrb9Av3t+n9aYEdNGasVi8Pl6VN6GDp3?=
 =?us-ascii?Q?OHDFiS2RPJyIW7HA3igSzjXL1jWGSap+rgnWac83skZD94T1rhe77t7F7VOk?=
 =?us-ascii?Q?QIS26jjkpd4rr5ieNkZvUKTzwIETrwXhAFwudbnT7V/aGNAJte0AwtBcYCqV?=
 =?us-ascii?Q?diI2dtgglYZ4vRM38vEdHiY08vJ4viByoDPt5kmuH2sTb0AUxunSAiWpeXZq?=
 =?us-ascii?Q?iXzsdJjaHRY5ISmrLt3pBhUhXV9ct4XxFXOKpiDrrznxMnTfAaKijNc1KIWD?=
 =?us-ascii?Q?KOz6fLuurVRvPlFpACtTE5DCE4c2eX5y+f+ogpmTl1vbP8aB4yQmPrkD/G6b?=
 =?us-ascii?Q?rWD8J09bUveM1Z06f1B++Pv/UjW/FWtw40p1xarNGskyoasyBYVktR5TFRwZ?=
 =?us-ascii?Q?bbiKqEGFEfFG4Te72X5D08OS5i6G8JYWilMvM4ydghP6INd8Z4l1rEUZHRDM?=
 =?us-ascii?Q?p0FAsQIMxH62UgRFwQyQr2FexwuBPlQCu5xQE6bDmL1rGiHhmplb9oy1+HY3?=
 =?us-ascii?Q?ZwYy/QyvBOOLH9ar2P0iYC14Z1tVMRJ6fom3EPf/XTcYF2sjlKJ6fCnIF9UT?=
 =?us-ascii?Q?lfHYs//6++Ost/kWg6hKV8d33V5wKvH5T5Am0qPzCt7nPGOwaizoDJoAJqJ2?=
 =?us-ascii?Q?u0pn2WSItGw6DtjtOdEfaaOpAXD4x8E6IO8zHqak0bKvL0R6Abv2J/rTQl2G?=
 =?us-ascii?Q?wC37pHCyIoHtSZ3QhArSA7MI34SdcUOj6xlt5karMuk2dGSzumQrHDPKw0Nz?=
 =?us-ascii?Q?9+buwtrFEOiVBJOblIDNXA1uSwpYJ1fqsslMth78ML+hxXEcSaFqm827tdfV?=
 =?us-ascii?Q?VTDs+jCxgOETXcf5BjYXv1W7ppHDJz4VBLv6Fnj42fL5co4cHprZevEeNFeY?=
 =?us-ascii?Q?F4wEU1zZn8FhXl4pDX2pPDNgc0Yut5ofpSif37T7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e50ba78-7eab-43a8-e792-08daa5530c66
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 15:22:13.6379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x38oWLmHcCGtxIAm83aOrXkqOJceTTkr+VWdeQGTZ/otrh1+NtE0ICxGz3P9MA8n20Q4Zs5lKULJGIVxBvM2/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6700
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 03, 2022 at 02:55:02PM +0530, Sumit Garg wrote:
> Hi Ira,
> 
> On Sun, 2 Oct 2022 at 05:53, <ira.weiny@intel.com> wrote:
> >
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > get_kernel_pages() only had one caller [shm_get_kernel_pages()] which did not
> > need the functionality it provided.  Furthermore, it called kmap_to_page()
> > which we are looking to removed.
> >
> > Alter shm_get_kernel_pages() to no longer call get_kernel_pages() and remove
> > get_kernel_pages().  Along the way it was noted that shm_get_kernel_pages()
> > does not have any need to support vmalloc'ed addresses either.  Remove that
> > functionality to clean up the logic.
> >
> > This series also fixes and uses is_kmap_addr().
> 
> From the above description, I am failing to see the motivation behind
> this change. Can you elaborate here?

Al Viro found[1] that kmap_to_page() is broken.  But not only was it broken but
it presents confusion over how highmem should be used because kmap() and
friends should not be used for 'long term' mappings.

[1] https://lore.kernel.org/lkml/YzSSl1ItVlARDvG3@ZenIV

> 
> Also, since you are targeting to remove kmap_to_page(), is there any
> alternative way to support highmem for future TEE bus drivers?  As I
> can see higmem being enabled for multiple Arm defconfigs [1] which can
> also support TEE (an example which already does it:
> arch/arm/configs/imx_v6_v7_defconfig).

With TEE how are the highmem pages used?  Right now the code does not seem to
use any user pages.  So I can't really say how this should work.  Why does the
kernel need a mapping of those pages?

Ira

> 
> [1] git grep CONFIG_HIGHMEM arch/arm/
> 
> -Sumit
> 
> >
> > Ira Weiny (4):
> >   highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings
> >   tee: Remove vmalloc page support
> >   tee: Remove call to get_kernel_pages()
> >   mm: Remove get_kernel_pages()
> >
> >  drivers/tee/tee_shm.c            | 41 ++++++++++++--------------------
> >  include/linux/highmem-internal.h |  5 +++-
> >  include/linux/mm.h               |  2 --
> >  mm/swap.c                        | 30 -----------------------
> >  4 files changed, 19 insertions(+), 59 deletions(-)
> >
> >
> > base-commit: 274d7803837da78dfc911bcda0d593412676fc20
> > --
> > 2.37.2
> >