Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3104268rwb; Mon, 3 Oct 2022 09:42:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4bCKX1OfvV+XtSIs2fiV7aaN++leNJ19oZ6vqp226GvuZo20aHRDCUv2PpO4vBiXaDY5s0 X-Received: by 2002:a17:903:2c5:b0:179:e92a:7e3b with SMTP id s5-20020a17090302c500b00179e92a7e3bmr22162600plk.171.1664815329803; Mon, 03 Oct 2022 09:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664815329; cv=none; d=google.com; s=arc-20160816; b=MGaLdEIgwvdnGUK1NKbEq8WnwPxh11GvHRFhhA+4GA1R5m+pxyuFfnOmNNCwRpw6bj jIv1zVr4G+JI0DJh3u+hbbSBXOr/E73lAIUKGgWiSt5FGicEgJOl14r0jSTIQO2wc7nG TzMB5HlZ/ufwqBBWFlBAO3JEiLlyimWFI5cTtUwBrRuCa/yHprkAcJ/AVdvyfHFLoaJw ukaAo1mh1AdfrWXhYIGt7GTSd4547XNcArs2PXzeAnVbzmeHMvzBdeFkcGQc1gSQBl93 XkAQUD7UJ4QS+ra+CWq+AcfZQWCc1DXbdrrYlK+hZ+afMPtSogp9OYjfzHdaSlglMXCK IFNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Xm6T6u54O2R9F7vYSZ9lG+CxOS8xX4jm0KQIA5Ujrr0=; b=KJedNG+Gq8/oEXxFCbPwnVqm95+XHHA3UPufxFeJrtFUiUdWRS9o1TUYqlqAIhpCwk UhKCcL75zxgJPCuDK8CkcsI4ODawb9XZ8bw5ROVy9s1IdKOnSE+HIRAa/1liqWqW4bNU 4EWa+Y6gegRPphUx+RkxsdExRAudkdSB9G2uKdOjWXJxKPMKfrU9t9l7eLEQucRHjQTH 9wO52J1CJWadRHOPr/3LsI9HpbHcMzteUwM5iwcXkxdf7NyZEp7M7jDRFXvM6SXtSK2e KXB3W2SrjOEZ76wNzGwEc7zeQwO7vuOiX23mbQqZzSuIFXUxU9HpkTSefMIZMfWdS7oZ B13g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a056a0023d500b0053f25053193si8737617pfc.77.2022.10.03.09.41.57; Mon, 03 Oct 2022 09:42:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbiJCQYQ (ORCPT + 99 others); Mon, 3 Oct 2022 12:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiJCQYN (ORCPT ); Mon, 3 Oct 2022 12:24:13 -0400 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4325D1CB3E; Mon, 3 Oct 2022 09:24:13 -0700 (PDT) Received: by mail-oi1-f176.google.com with SMTP id g130so11758744oia.13; Mon, 03 Oct 2022 09:24:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Xm6T6u54O2R9F7vYSZ9lG+CxOS8xX4jm0KQIA5Ujrr0=; b=P5zTYSyqo+aw/k4TVEmG+XgdRcaBEZMnsJcc43Q+O+MEhyya6NbEoCgZiIcBCF68Zb bbAOjoW0h5ja5XLBngZORaxKexIadEun9tmp9Eopwc0MZ3+OWimGioWW77TdgLN6G+0x q1IldlipkNzRp0FRHslswtcfE7aELkeRGK/8BAKKYtnSHDVwzL8VvKBBDv+1JgQvymQs HRVT7tfhTxT/Eism+QpJWgpRy8bucOEMtN4g74N/wGPexyFGBSdYA8+pysbsjpah/N3V WhWxGPnkx2h3WWyWID2euVKcwDBPtXvY0Y7yyYbX+tY4fKKfu5QnMTZOjHHEK3Zw78Z8 1Caw== X-Gm-Message-State: ACrzQf0VvBC2cQEprrfJI3Dp9//xAVJvCI0wzjngvW3WLYAclC2O1hHr WufLH5FLR3/OkQG+ALMwUQ== X-Received: by 2002:aca:5b0a:0:b0:34f:eeab:b853 with SMTP id p10-20020aca5b0a000000b0034feeabb853mr4461049oib.182.1664814252475; Mon, 03 Oct 2022 09:24:12 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i8-20020a056870890800b001328ce69d36sm403463oao.9.2022.10.03.09.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 09:24:12 -0700 (PDT) Received: (nullmailer pid 2406847 invoked by uid 1000); Mon, 03 Oct 2022 16:24:11 -0000 Date: Mon, 3 Oct 2022 11:24:11 -0500 From: Rob Herring To: Pierre Gondois Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand Subject: Re: [PATCH] of: base: Shift refcount decrement in of_find_last_cache_level() Message-ID: <166481423257.2406482.16532672531113101637.robh@kernel.org> References: <20220930144936.2882481-1-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220930144936.2882481-1-pierre.gondois@arm.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Sep 2022 16:49:36 +0200, Pierre Gondois wrote: > Currently, of_find_next_cache_node() and of_property_read_u32() > are called on objects after their refcount have been decremented. > Re-order the calls to decrement the refcount after the function > calls. > > Signed-off-by: Pierre Gondois > --- > drivers/of/base.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Applied, thanks!