Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?UTF-8?q?Micha=C5=82=20Grzelak?= <mig@semihalf.com>
To:     mw@semihalf.com
Cc:     davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
        krzysztof.kozlowski@linaro.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        mig@semihalf.com, netdev@vger.kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, upstream@semihalf.com
Subject: Re: [PATCH v2] dt-bindings: net: marvell,pp2: convert to json-schema
Date:   Mon,  3 Oct 2022 19:06:13 +0200
Message-Id: <20221003170613.132548-1-mig@semihalf.com>
In-Reply-To: <CAPv3WKcW+O_CYd2vY2xhTKojVobo=Bm5tdFdJ8w33FHximPTcA@mail.gmail.com>
References: <CAPv3WKcW+O_CYd2vY2xhTKojVobo=Bm5tdFdJ8w33FHximPTcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 02/10/2022 10:23, Marcin Wojtas wrote:
>niedz., 2 paź 2022 o 10:00 Krzysztof Kozlowski
><krzysztof.kozlowski@linaro.org> napisał(a):
>>
>> On 01/10/2022 17:53, Michał Grzelak wrote:
>> > Hi Krzysztof,
>> >
>> > Thanks for your comments and time spent on reviewing my patch.
>> > All of those improvements will be included in next version.
>> > Also, I would like to know your opinion about one.
>> >
>> >>> +
>> >>> +  marvell,system-controller:
>> >>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> >>> +    description: a phandle to the system controller.
>> >>> +
>> >>> +patternProperties:
>> >>> +  '^eth[0-9a-f]*(@.*)?$':
>> >>
>> >> The name should be "(ethernet-)?port", unless anything depends on
>> >> particular naming?
>> >
>> > What do you think about pattern "^(ethernet-)?eth[0-9a-f]+(@.*)?$"?
>> > It resembles pattern found in net/ethernet-phy.yaml like
>> > properties:$nodename:pattern:"^ethernet-phy(@[a-f0-9]+)?$", while
>> > still passing `dt_binding_check' and `dtbs_check'. It should also
>> > comply with your comment.
>>
>> Node names like ethernet-eth do not make much sense because they contain
>> redundant ethernet or eth. AFAIK, all other bindings like that call
>> these ethernet-ports (or sometimes shorter - ports). Unless this device
>> is different than all others?
>>
>
>IMO "^(ethernet-)?port@[0-9]+$" for the subnodes' names could be fine
>(as long as we don't have to modify the existing .dtsi files) - there
>is no dependency in the driver code on that.

Indeed, driver's code isn't dependent; however, there is a dependency
on 'eth[0-2]' name in all relevant .dts and .dtsi files, e.g.:

https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/armada-375.dtsi#L190
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi#L72

Ports under 'ethernet' node are named eth[0-2], thus those and all .dts files 
including the above would have to be modified to pass through `dtbs_check'.

Best regards,
Michał