Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6c0cda1-b30d-5ca9-54e5-0643f7d5ffd9@wanadoo.fr>
Date:   Mon, 3 Oct 2022 21:16:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] HID: alps: Simplify the .remove function
Content-Language: en-US
To:     Marcus Folkesson <marcus.folkesson@gmail.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-input@vger.kernel.org
References: <33cf94ec234b88ffc79eb4496c640093aa8c5e70.1664721476.git.christophe.jaillet@wanadoo.fr>
 <YzsCdyPxrNcHE3XF@gmail.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <YzsCdyPxrNcHE3XF@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 03/10/2022 à 17:40, Marcus Folkesson a écrit :
> Hi Christophe!
> 
> On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
>> If the .remove function of a 'hid_driver' is NULL, the default behavior is
>> to call hid_hw_stop().
>>
>> So alps_remove() can be removed here, it is just hand-writing what
>> already exists.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
> 
> 
> There is already a patch out there :-)

Great,

But I always find it funny when something that is there since many years 
(819d64e51d62 - 2016-06-23) is fixed twice in a row from unrelated work!

CJ

> 
> https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/
> 
> Best regards,
> Marcus Folkesson