Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 12:31:36 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "J. R. Okajima" <hooanon05g@gmail.com>
CC:     Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on
 kmap_local_page()
Message-ID: <Yzs4mL3zrrC0/vN+@iweiny-mobl>
References: <YzN+ZYLjK6HI1P1C@ZenIV>
 <YzSSl1ItVlARDvG3@ZenIV>
 <YzpcXU2WO8e22Cmi@iweiny-desk3>
 <7714.1664794108@jrobl>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7714.1664794108@jrobl>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RF6EuDME7UFl9VhUa/qzFglKMis3c/UOY2fc+youN9UL91oe8tD80rtwsuiw?=
 =?us-ascii?Q?0JeFn2VlTiPl8vNR/rwdbh8lRANvlI8N7HiEQqItOccNDZoISCAuNdwXIE9p?=
 =?us-ascii?Q?vh5dp2GOasNj0T69pYG8m/7EtbdQgFrofvEDSK9uXKMbhy7uWQj4X4hOee+k?=
 =?us-ascii?Q?OQxlAumXyxrlPvp2lcEmPPHD1ki89Dhhyt5bV4PnxLRIgV/63gO5/GaOO51w?=
 =?us-ascii?Q?oB4kbMFcP/97bII00FJ+2imtVWLudy721SwQ7YATiYNxZdWFyaU0pZ5EvPhG?=
 =?us-ascii?Q?SZqUWczA5/dk19pZcBctvGqYDTp/dtLSrEQry7CcWol8QCuNMBoRbB582yNy?=
 =?us-ascii?Q?NsIPPhShH1TKWI9oBqcJT6w7bX8B2Mw6lRnBx5Mtr/b0QjQykyB8xT+X0CZ9?=
 =?us-ascii?Q?cnWXQwx/YaXoO6pHVVOwiY2lqhOUYqqN1WqPIKWl0AgiYuwEa3rwCOZ2dsIi?=
 =?us-ascii?Q?E/qhsf2q00xaCdKtW74Xf6u62lVX+M5P2IUW6gCc9g2o+4pgv4wh3FD3RiiM?=
 =?us-ascii?Q?cwapD4plQ9dNaIubiR//p01dtjLrC1ND6snwewQIoB34oizeYXSr4BucOImO?=
 =?us-ascii?Q?BdkJHNqh5fBeHtHbRevnOiJE0F07S5nIcSBO+uFJ4vxJmWhKABdrCRvbDlsF?=
 =?us-ascii?Q?Mmnf3HFICX9Zra0tj0gIlNceHhlvw+wynFiuT2iJa+WXGoxuXVsb/X5UIHSI?=
 =?us-ascii?Q?reu2Rm5HNmi6gQKpcRs4QHBq6d8GcIV1x3oZPnbFpgw4ThZfd40aobWS4vu1?=
 =?us-ascii?Q?6sONmbmmEEvfPo4MO3KpcA6VZGX6jPj+tyN5RLOwmcab4+HuqE7V4hDIBNUw?=
 =?us-ascii?Q?1nSm9t1sNae0dRZoZWXIlA/l46F71WMKE6n1CC9T81P0Vb/iBjjyHSQg4KLj?=
 =?us-ascii?Q?MzlFO2asuSlN/DNccjOr4s/sQw+OF3mgL4Yax1dyR58Fuu0dBpCQMqhDh5j6?=
 =?us-ascii?Q?Os06ZMwtzbQJowjhC/clKcpROIOM5IkX/nIj7f1kFiUimGdFu35G210ziqY1?=
 =?us-ascii?Q?9UnroTtl6eEyPUIWIOm3O4Rry11/JVRBd7/0a3F/noTNcVDb6qhiCZayFUTL?=
 =?us-ascii?Q?CFWPmd+d+8atSSIyKsfxkBj/6M/lYnzsxKicjxg3lt5RZC25WeQxfZy5yF4R?=
 =?us-ascii?Q?unY3+4pS7K1rYEStOBucA+0ImDaWW3p8r2S5s8wuFWxGYZcFx716DKnMaOjN?=
 =?us-ascii?Q?V/4c/PNtBy6vW7fGavsLb/PGEazd2G5Umf0SHJbVyDLZVrYBVbMmOKn7Mb9a?=
 =?us-ascii?Q?q22Y4Grtcwvw3qElpPBomSIshgr0YpHJYrrZ29hw6sAEe9BnizZzdNwoKB9U?=
 =?us-ascii?Q?yfqiq03Z7gbgpzevNErOnjBHUmYvfxFCO8awnL9Bgql0saN3b/UTs/NsOmxj?=
 =?us-ascii?Q?EUAX3Ck1CKI1K8VMmdlBGvADqTiGC57dCTeVB9OaQHdjq4JQCFLjctY8NeDT?=
 =?us-ascii?Q?2TvM3PTvANxcMdYEPQX7NHarcinCSaskzsC286wh15M7VIjPZGQcJ+9HAMKl?=
 =?us-ascii?Q?2fpRZ+KO9wy8UQj+WhK1C+A9LA+MEDAmKf5SjSXxJnBSd78YkSRBsqja+ngl?=
 =?us-ascii?Q?gJ2sxzdUejYLIXnCkB0ICAQzjvaBFXiAGGg/bCeg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 11d87c5e-a9bb-4aec-892b-08daa575e57e
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 19:31:40.7940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j4ZTEptTVgkclaGn4wiZogz6hFjrU6pvkzMytpD8U4ItqAaCOzRHcyBM0mfI7mRO0bNrMmgEmpU7euKbb6WVzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6096
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 03, 2022 at 07:48:28PM +0900, J. R. Okajima wrote:
> Ira Weiny:
> > On Wed, Sep 28, 2022 at 07:29:43PM +0100, Al Viro wrote:
> > > On Tue, Sep 27, 2022 at 11:51:17PM +0100, Al Viro wrote:
> > > > [I'm going to send a pull request tomorrow if nobody yells;
> > > > please review and test - it seems to work fine here, but extra
> > > > eyes and extra testing would be very welcome]
> 
> I tried gdb backtrace 'bt' command with the new core by v6.0, and it
> doesn't show the call trace correctly. Is it related to this commit?
>

Are you also getting something like this?

BFD: warning: /mnt/9p/test-okajima/core is truncated: expected core file size >= 225280, found: 76616

I did not see that before.  I'm running through this patch vs a fix to
kmap_to_page()[1] and I may have gotten the 2 crossed up.  So I'm retesting
with your test below.

Ira

[1] https://lore.kernel.org/linux-mm/20221003040427.1082050-1-ira.weiny@intel.com/
 
> test program
> ----------------------------------------
> void f(int n)
> {
> 	printf("%d\n", n);
> 	if (!n)
> 		kill(getpid(), SIGQUIT);
> 	f(--n);
> }
> 
> int main(int argc, char *argv[])
> {
> 	f(atoi(argv[1]));
> 	return 0;
> }
> ----------------------------------------
> ulimit -c unlimited
> coredump 2
> gdb coredump core
> bt
> ----------------------------------------
> expected result
> kill
> f
> f
> f
> main
> ----------------------------------------
> actual result
> ??
> ??
> ----------------------------------------
> 
> 
> J. R. Okajima