Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 14:17:12 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Akinobu Mita <akinobu.mita@gmail.com>
Cc:     Wei Yongjun <weiyongjun1@huawei.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Isabella Basso <isabbasso@riseup.net>,
        Vlastimil Babka <vbabka@suse.cz>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4 -next] fault-injection: make some stack filter attrs
 more readable
Message-Id: <20221003141712.ff7aceb8e29073f3aa9be2ec@linux-foundation.org>
In-Reply-To: <CAC5umyhZrUsOCDbWPznRpuaDwScHf7yKA5m8X8jwVztm6B+meA@mail.gmail.com>
References: <20220817080332.1052710-1-weiyongjun1@huawei.com>
        <20220817080332.1052710-4-weiyongjun1@huawei.com>
        <CAC5umyhZrUsOCDbWPznRpuaDwScHf7yKA5m8X8jwVztm6B+meA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 19 Aug 2022 22:24:10 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:

> 2022年8月17日(水) 16:45 Wei Yongjun <weiyongjun1@huawei.com>:
> >
> > Attributes of stack filter are show as unsigned decimal, such
> > as 'require-start', 'require-end'. This patch change to
> > show them as unsigned hexadecimal for more readable.
> >
> > Before:
> >   $ echo 0xffffffffc0257000 > /sys/kernel/debug/failslab/require-start
> >   $ cat /sys/kernel/debug/failslab/require-start
> >   18446744072638263296
> >
> > After:
> >   $ echo 0xffffffffc0257000 > /sys/kernel/debug/failslab/require-start
> >   $ cat /sys/kernel/debug/failslab/require-start
> >   0xffffffffc0257000
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> >  lib/fault-inject.c | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> > index 515fc5aaf032..deca05e7c9b3 100644
> > --- a/lib/fault-inject.c
> > +++ b/lib/fault-inject.c
> > @@ -179,6 +179,14 @@ static void debugfs_create_ul(const char *name, umode_t mode,
> >
> >  #ifdef CONFIG_FAULT_INJECTION_STACKTRACE_FILTER
> >
> > +DEFINE_SIMPLE_ATTRIBUTE(fops_xl, debugfs_ul_get, debugfs_ul_set, "0x%llx\n");
> > +
> > +static void debugfs_create_xl(const char *name, umode_t mode,
> > +                             struct dentry *parent, unsigned long *value)
> > +{
> > +       debugfs_create_file(name, mode, parent, value, &fops_xl);
> > +}
> 
> How about using an existing `debugfs_create_xul()` instead of defining
> a local helper function?

Could we please have a response to this?