Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3403009rwb; Mon, 3 Oct 2022 14:36:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM50l6K95uc7ZwV6DtKI8N6bi5oiGQj9uaaZngAfagY7ZUE7EOICFLE+IpcPvusy+AGqko9F X-Received: by 2002:a17:902:c40d:b0:17f:59d8:7f72 with SMTP id k13-20020a170902c40d00b0017f59d87f72mr7288756plk.91.1664832996444; Mon, 03 Oct 2022 14:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664832996; cv=none; d=google.com; s=arc-20160816; b=n0a4BDOuwXMyNlL/mmUFiVtUrPxBS4zIqYh2b/mdNmSV8djmxaAVh681MpZtIo2L5w FhvzICpQ85sjJmqjm1vONQixYTrT+GLHdC6utW6JVjd2wu1rBDi2HNpJpyj3tAfrnCog +Ozr5kRz2nUZRO46hrrAboAkvJk7SIGkhu2bzd05ky2deovEgRTRxpuu+xzl1r4U+shf eHI0JK6txcNF85OAACrn7hckcd/epzsmtic/k3ktEiYz1Ne4hZwEw+j57UzlgbjDR/k0 Q/owRW8vCk/rri4+qtFquB5y2lJtY+JzdDJv5uMSxQefTbpY67mFQ1zdrFHQDd2hjM1/ d8ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=pnq0BaudZyE1ZHxTQZ750T5B67Ec7e9t5He2lFafMcA=; b=Ja0TA5y0e54HLZoALqNW0AJ7FG0hS9DPNmFOwDIgfs4kf2ftValcRSPp+tJOQniTUI n9pWMOfGb8KmqDLujyb5tpKF0L2bgJjzWacsngf9Aw3gw6oFuWVW6ZPej6i/JsD2cZv3 9jHU2umMmILluQtC4zuV83gkvNKcOXzisICTuI5diY8rHt/i8niLZF/EAl5rBR56ggjf r6yBOJCKsSgt85jrzyZyPtKDf6L19Rwh0LxBW0+oagAkhe3uoRL6d/wwXCaML2td2QEt z1K2afNhoinxeCdd4fPlgCtQ362ipgcAT03dsUhWRI8gUOsRf6LmJ+l6i13fQ9R3Tif7 IAhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pd8zZNsc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a63db42000000b0041be4782428si11925022pgi.122.2022.10.03.14.36.24; Mon, 03 Oct 2022 14:36:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pd8zZNsc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbiJCVYj (ORCPT + 99 others); Mon, 3 Oct 2022 17:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbiJCVWc (ORCPT ); Mon, 3 Oct 2022 17:22:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 700DA1AD89; Mon, 3 Oct 2022 14:13:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C34260109; Mon, 3 Oct 2022 21:13:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CBB1C433D6; Mon, 3 Oct 2022 21:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664831614; bh=pnq0BaudZyE1ZHxTQZ750T5B67Ec7e9t5He2lFafMcA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=pd8zZNscdLlS2ClcQX4kihUyKO9nhPkWked48xr6jfJ7drq1I+7ya4OV45jaqsrkR mtD6ZwvWWfO4azJyzLaAUAzUYhrey2xoz/TdQLT7wdkfohrKJqX/zHmvFtlCOhSAcW /bGF+REjjjMo+czhAZrnMGfSd3hakzpZqVmIKYEvl/IRWwau9a/X4XteMgqoP8D+F+ SxWud7q+sh54HEJWdM5vGmXjj+Z+Mqu0z6rqC5dQpX17nJOb36ip5RYKqa3pwlTlpn aWmlZGlF7zgWvtqqA4BSB8Yjq2LAAR3buz8KVkttDwNBRkEl+Cos8eI/n3iELP3zei RcG3fqoCo4dOA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220408130617.14963-1-hanyihao@vivo.com> References: <20220408130617.14963-1-hanyihao@vivo.com> Subject: Re: [PATCH] clk: clk-xgene: simplify if-if to if-else From: Stephen Boyd Cc: kernel@vivo.com, Yihao Han To: Michael Turquette , Yihao Han , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 03 Oct 2022 14:13:32 -0700 User-Agent: alot/0.10 Message-Id: <20221003211334.5CBB1C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Yihao Han (2022-04-08 06:06:09) > Replace `if (!pclk->param.csr_reg)` with `else` for simplification > and add curly brackets according to the kernel coding style: >=20 > "Do not unnecessarily use braces where a single statement will do." >=20 > ... >=20 > "This does not apply if only one branch of a conditional statement is > a single statement; in the latter case use braces in both branches" >=20 > Please refer to: > https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html >=20 > Signed-off-by: Yihao Han > --- Applied to clk-next