Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Oct 2022 00:37:16 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     "J. R. Okajima" <hooanon05g@gmail.com>
Cc:     Ira Weiny <ira.weiny@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH][CFT] [coredump] don't use __kernel_write() on
 kmap_local_page()
Message-ID: <YztyLFZJKKTWcMdO@ZenIV>
References: <YzN+ZYLjK6HI1P1C@ZenIV>
 <YzSSl1ItVlARDvG3@ZenIV>
 <YzpcXU2WO8e22Cmi@iweiny-desk3>
 <7714.1664794108@jrobl>
 <Yzs4mL3zrrC0/vN+@iweiny-mobl>
 <YztfvaAFOe2kGvDz@ZenIV>
 <4011.1664837894@jrobl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4011.1664837894@jrobl>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Tue, Oct 04, 2022 at 07:58:14AM +0900, J. R. Okajima wrote:
> Al Viro:
> > Argh....  Try this:
> >
> > fix coredump breakage caused by badly tested "[coredump] don't use __kernel_write() on kmap_local_page()"
> 
> Thanx, it passed my local test.
> 
> 
> > * fix for problem that occurs on rather uncommon setups (and hadn't
> > been observed in the wild) sent very late in the cycle.
> 
> If the commit was merged in RC versions, I guess someone found the
> problem earlier.

Most likely - the breakage is really not hard to trigger ;-/

	Linus, which way would you prefer to handle that?  It's
a brown paperbag stuff - the worst I had in quite a while.
Mea maxima culpa ;-/

One variant would be to revert the original patch, put its
(hopefully) fixed variant into -next and let it sit there for
a while.  Another is to put this incremental into -next and
merge it into mainline once it gets a sane amount of testing.

	Up to you...