Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 3 Oct 2022 16:43:44 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     Chen Zhongjin <chenzhongjin@huawei.com>,
        linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH -next] module: Remove unused macros module_addr_min/max
Message-ID: <YztzsFsytGnMtQAq@bombadil.infradead.org>
References: <20220924072216.103876-1-chenzhongjin@huawei.com>
 <alpine.LSU.2.21.2209301329490.11771@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.21.2209301329490.11771@pobox.suse.cz>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Fri, Sep 30, 2022 at 01:37:25PM +0200, Miroslav Benes wrote:
> Hi,
> 
> On Sat, 24 Sep 2022, Chen Zhongjin wrote:
> 
> > Unused macros reported by [-Wunused-macros].
> > 
> > These macros are introduced to record the bound address of modules.
> > 
> > '80b8bf436990 ("module: Always have struct mod_tree_root")'
> > This commit has made struct mod_tree_root always exist, which means
> > we can always referencing mod_tree derectly rather than using this
> > macro.
> > 
> > So they are useless, remove them for code cleaning.
> 
> a nit, but I would rephrase the changelog a bit...
> 
> "
> Commit 80b8bf436990 ("module: Always have struct mod_tree_root") made 
> "struct mod_tree_root" always present and its members addr_min and 
> addr_max can be directly accessed.
> 
> Macros module_addr_min and module_addr_min are not used anymore, so remove 
> them.
> "
> 
> > Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> 
> Anyway
> 
> Reviewed-by: Miroslav Benes <mbenes@suse.cz>

Thanks all, I've changed the commit message as suggested by Miroslav,
and will queue this up for 6.2.

  Luis