Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3576360rwb;
        Mon, 3 Oct 2022 17:56:50 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM5WH0uNuxe5Fg0oviNFwSc5HDa2njaFU+fqRslRabFqsEDCQ5GD91mZPIZ55q7vwv2hLT3T
X-Received: by 2002:a05:6402:d05:b0:425:b7ab:776e with SMTP id eb5-20020a0564020d0500b00425b7ab776emr21949092edb.142.1664845010030;
        Mon, 03 Oct 2022 17:56:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1664845010; cv=none;
        d=google.com; s=arc-20160816;
        b=UI7zqujJoS7h0x1Xw5+CFPzwaXA9jDNQMPcr5wnXBGOT+xRRJbpDw8zh6syyEGDPZb
         bQ0Hf/WrlpwpFU6IdImLTRg9LY2AgCacJxYRLZssatIwMOlwtXru7j8K0d+mefBt5LAP
         fA6m5dzd5n+TzDyhND7KwU+WwBAc10a/x/yobIdd7vBzPNLsAsBu7IU/JpV/342zjaEm
         GdvusbGUxyXmyNtZLUzzD2FsNmChTxAMlKXJR9MoF5GA+8pq1b2GyljQWe0Ku2ZH6YDr
         6d9u9DAoNBBLzfvXRn9u8h1X0zpO7r4p9Ljc2ahpq6KtIpeMbeGnVn1qMfeBzSP4we6L
         T03Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=rkOffV+pvITSUHBtolrjUBZbWCb73yHk84uDjbAO6TY=;
        b=HfkBl6L/y6XBlHJlI/AbBld+0CSJPvWNfcO0RBdjsZiGm9a5LQqIapKs+7BdSDOHLP
         7+1LMXmPckc56eLDRW8MViIQz8RzOP26pCdOs9VTYDP0PdUeeo8BgtnJ+1pVHvG6QlTf
         1TePtfLxh1Op8IdZ8W7/TrzTa0n/C/u5cpXHNARpCf40Zhjcum0t/4WE5AL+4EAPmv9q
         9qleOD6EgH8TgCUmZiMgL/E/9fSrBqNMRjqCuythS6+iTnFLTKOWJ7q4ZcwsfpqCm2wT
         WLaDfSXO/FY6kL6UTVy6YZUqVESc1vKT8CbNyBxPaFPm4TPNec2d5iQkNahnoUEOB324
         O1Tg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mQi4ybdp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id ss2-20020a170907c00200b007882926c091si6439567ejc.768.2022.10.03.17.56.25;
        Mon, 03 Oct 2022 17:56:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mQi4ybdp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229915AbiJDAIx (ORCPT <rfc822;anenbupt@gmail.com> + 99 others);
        Mon, 3 Oct 2022 20:08:53 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58204 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229640AbiJDAIv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2022 20:08:51 -0400
Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ADA0F5AE;
        Mon,  3 Oct 2022 17:08:50 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by sin.source.kernel.org (Postfix) with ESMTPS id 778FCCE0F7F;
        Tue,  4 Oct 2022 00:08:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D3DDC433C1;
        Tue,  4 Oct 2022 00:08:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1664842126;
        bh=YNqwNduPcb5thmEiOwSsCHdrAP2D+Xzxs6/sckI4nI8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=mQi4ybdpjq2Vt0bvLT682IVB4ICnquisO8ekuTRRQ4XG3kXB34jKCKngUOyH2F9XK
         Z4c/QxaQlNsgMgT1kHuzKJMFRS3nn5HMtBTobnPebEEES6+yXCJQbPtrQQY6rF7DoZ
         ETqzD+VDJOh8QD7Tz63C1BUlh1dNX4YhEmO1wJhUREx5vAb5aqEPPLPG7Brn/z1mtE
         1k7ia8ECHD9KdLbmbSIimnwBDJhCI7mYnTiEU1QMGXG4ZyFXg/0H/q1VZZHXtwC0ty
         7GJgzoojgtpkrazTSai+GNNZm8FKfuTKsx5c/OhTrq76EBRoKGCochLYmLoO0sxo2H
         bvVf/hvi9iTkQ==
Date:   Mon, 3 Oct 2022 17:08:45 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Divya Koppera <Divya.Koppera@microchip.com>
Cc:     <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net] net: phy: micrel: Fixes FIELD_GET assertion
Message-ID: <20221003170845.1fec4353@kernel.org>
In-Reply-To: <20221003063130.17782-1-Divya.Koppera@microchip.com>
References: <20221003063130.17782-1-Divya.Koppera@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 3 Oct 2022 12:01:30 +0530 Divya Koppera wrote:
> FIELD_GET() must only be used with a mask that is a compile-time
> constant. Mark the functions as __always_inline to avoid the problem.
> 
> Fixes: 21b688dabecb6a ("net: phy: micrel: Cable Diag feature for lan8814 phy")

Does not apply cleanly to net, please rebase & resend.